* [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
@ 2018-11-01 23:38 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2018-11-01 23:38 UTC (permalink / raw)
To: LKML
Cc: Geert Uytterhoeven, Miquel Raynal, Yoshinori Sato, Rich Felker,
Jacopo Mondi, Magnus Damm, linux-mtd, linux-sh, Andrew Morton
From: Randy Dunlap <rdunlap@infradead.org>
arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
<mtd/onenand.h>, and doing so causes a build warning, so drop
that header file.
In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
struct mtd_oob_ops *ops);
Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-mtd@lists.infradead.org
Cc: linux-sh@vger.kernel.org
---
arch/sh/boards/mach-kfr2r09/setup.c | 1 -
1 file changed, 1 deletion(-)
--- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
+++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
@@ -25,7 +25,6 @@
#include <linux/memblock.h>
#include <linux/mfd/tmio.h>
#include <linux/mmc/host.h>
-#include <linux/mtd/onenand.h>
#include <linux/mtd/physmap.h>
#include <linux/platform_data/lv5207lp.h>
#include <linux/platform_device.h>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
@ 2018-11-01 23:38 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2018-11-01 23:38 UTC (permalink / raw)
To: LKML
Cc: Geert Uytterhoeven, Miquel Raynal, Yoshinori Sato, Rich Felker,
Jacopo Mondi, Magnus Damm, linux-mtd, linux-sh, Andrew Morton
From: Randy Dunlap <rdunlap@infradead.org>
arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
<mtd/onenand.h>, and doing so causes a build warning, so drop
that header file.
In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
struct mtd_oob_ops *ops);
Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-mtd@lists.infradead.org
Cc: linux-sh@vger.kernel.org
---
arch/sh/boards/mach-kfr2r09/setup.c | 1 -
1 file changed, 1 deletion(-)
--- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
+++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
@@ -25,7 +25,6 @@
#include <linux/memblock.h>
#include <linux/mfd/tmio.h>
#include <linux/mmc/host.h>
-#include <linux/mtd/onenand.h>
#include <linux/mtd/physmap.h>
#include <linux/platform_data/lv5207lp.h>
#include <linux/platform_device.h>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
2018-11-01 23:38 ` Randy Dunlap
@ 2018-11-02 7:52 ` jacopo mondi
-1 siblings, 0 replies; 6+ messages in thread
From: jacopo mondi @ 2018-11-02 7:52 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Geert Uytterhoeven, Miquel Raynal, Yoshinori Sato,
Rich Felker, Jacopo Mondi, Magnus Damm, linux-mtd, linux-sh,
Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]
Hi Randy,
thanks for the patch.
On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
> <mtd/onenand.h>, and doing so causes a build warning, so drop
> that header file.
>
> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
> struct mtd_oob_ops *ops);
>
> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
Not sure if this is worth pointing out, but this commit only resorts
headers. The one introducing the warning is actually 33893d7aa.
I felt like reporting this, as introducing a "Fixes" line for that
commit too would help backporting maybe?
In any case:
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-sh@vger.kernel.org
> ---
> arch/sh/boards/mach-kfr2r09/setup.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
> @@ -25,7 +25,6 @@
> #include <linux/memblock.h>
> #include <linux/mfd/tmio.h>
> #include <linux/mmc/host.h>
> -#include <linux/mtd/onenand.h>
> #include <linux/mtd/physmap.h>
> #include <linux/platform_data/lv5207lp.h>
> #include <linux/platform_device.h>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
@ 2018-11-02 7:52 ` jacopo mondi
0 siblings, 0 replies; 6+ messages in thread
From: jacopo mondi @ 2018-11-02 7:52 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Geert Uytterhoeven, Miquel Raynal, Yoshinori Sato,
Rich Felker, Jacopo Mondi, Magnus Damm, linux-mtd, linux-sh,
Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]
Hi Randy,
thanks for the patch.
On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
> <mtd/onenand.h>, and doing so causes a build warning, so drop
> that header file.
>
> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
> struct mtd_oob_ops *ops);
>
> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
Not sure if this is worth pointing out, but this commit only resorts
headers. The one introducing the warning is actually 33893d7aa.
I felt like reporting this, as introducing a "Fixes" line for that
commit too would help backporting maybe?
In any case:
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-sh@vger.kernel.org
> ---
> arch/sh/boards/mach-kfr2r09/setup.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
> @@ -25,7 +25,6 @@
> #include <linux/memblock.h>
> #include <linux/mfd/tmio.h>
> #include <linux/mmc/host.h>
> -#include <linux/mtd/onenand.h>
> #include <linux/mtd/physmap.h>
> #include <linux/platform_data/lv5207lp.h>
> #include <linux/platform_device.h>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
2018-11-02 7:52 ` jacopo mondi
@ 2018-11-02 16:07 ` Randy Dunlap
-1 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2018-11-02 16:07 UTC (permalink / raw)
To: jacopo mondi
Cc: LKML, Geert Uytterhoeven, Miquel Raynal, Yoshinori Sato,
Rich Felker, Jacopo Mondi, Magnus Damm, linux-mtd, linux-sh,
Andrew Morton
On 11/2/18 12:52 AM, jacopo mondi wrote:
> Hi Randy,
> thanks for the patch.
>
> On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
>> <mtd/onenand.h>, and doing so causes a build warning, so drop
>> that header file.
>>
>> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
>> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
>> struct mtd_oob_ops *ops);
>>
>> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
>
> Not sure if this is worth pointing out, but this commit only resorts
> headers. The one introducing the warning is actually 33893d7aa.
>
> I felt like reporting this, as introducing a "Fixes" line for that
> commit too would help backporting maybe?
Oops, thanks, I'll fix that and send a v2 with your Ack.
> In any case:
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
>
> Thanks
> j
>
>>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Cc: Rich Felker <dalias@libc.org>
>> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: linux-mtd@lists.infradead.org
>> Cc: linux-sh@vger.kernel.org
>> ---
>> arch/sh/boards/mach-kfr2r09/setup.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
>> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
>> @@ -25,7 +25,6 @@
>> #include <linux/memblock.h>
>> #include <linux/mfd/tmio.h>
>> #include <linux/mmc/host.h>
>> -#include <linux/mtd/onenand.h>
>> #include <linux/mtd/physmap.h>
>> #include <linux/platform_data/lv5207lp.h>
>> #include <linux/platform_device.h>
>>
>>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning
@ 2018-11-02 16:07 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2018-11-02 16:07 UTC (permalink / raw)
To: jacopo mondi
Cc: LKML, Geert Uytterhoeven, Miquel Raynal, Yoshinori Sato,
Rich Felker, Jacopo Mondi, Magnus Damm, linux-mtd, linux-sh,
Andrew Morton
On 11/2/18 12:52 AM, jacopo mondi wrote:
> Hi Randy,
> thanks for the patch.
>
> On Thu, Nov 01, 2018 at 04:38:30PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
>> <mtd/onenand.h>, and doing so causes a build warning, so drop
>> that header file.
>>
>> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
>> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
>> struct mtd_oob_ops *ops);
>>
>> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
>
> Not sure if this is worth pointing out, but this commit only resorts
> headers. The one introducing the warning is actually 33893d7aa.
>
> I felt like reporting this, as introducing a "Fixes" line for that
> commit too would help backporting maybe?
Oops, thanks, I'll fix that and send a v2 with your Ack.
> In any case:
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
>
> Thanks
> j
>
>>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Cc: Rich Felker <dalias@libc.org>
>> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: linux-mtd@lists.infradead.org
>> Cc: linux-sh@vger.kernel.org
>> ---
>> arch/sh/boards/mach-kfr2r09/setup.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- linux-next-20181101.orig/arch/sh/boards/mach-kfr2r09/setup.c
>> +++ linux-next-20181101/arch/sh/boards/mach-kfr2r09/setup.c
>> @@ -25,7 +25,6 @@
>> #include <linux/memblock.h>
>> #include <linux/mfd/tmio.h>
>> #include <linux/mmc/host.h>
>> -#include <linux/mtd/onenand.h>
>> #include <linux/mtd/physmap.h>
>> #include <linux/platform_data/lv5207lp.h>
>> #include <linux/platform_device.h>
>>
>>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-02 16:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 23:38 [PATCH resend] arch/sh: mach-kfr2r09: fix struct mtd_oob_ops build warning Randy Dunlap
2018-11-01 23:38 ` Randy Dunlap
2018-11-02 7:52 ` jacopo mondi
2018-11-02 7:52 ` jacopo mondi
2018-11-02 16:07 ` Randy Dunlap
2018-11-02 16:07 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.