All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harish Chegondi <harish.chegondi@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs
Date: Wed, 23 Oct 2019 00:24:40 -0700	[thread overview]
Message-ID: <bce95a8734ab5ed10c9f26395671ca0995767d2a.1571813756.git.harish.chegondi@intel.com> (raw)
In-Reply-To: <cover.1571813756.git.harish.chegondi@intel.com>

display_pipe_crc_irq_handler() skips the first CRC for all GPUs and the
second CRC for GEN8+ GPUs. The second CRC is invalid even for BYT which
is a GEN7 GPU. So, skip the second CRC even for GEN7 GPUs.

v2: Rebase

Cc: Jani Saarinen <jani.saarinen@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Harish Chegondi <harish.chegondi@intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=103191
---
 drivers/gpu/drm/i915/i915_irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 572a5c37cc61..312ca9d5292a 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1565,11 +1565,11 @@ static void display_pipe_crc_irq_handler(struct drm_i915_private *dev_priv,
 	 * bonkers. So let's just wait for the next vblank and read
 	 * out the buggy result.
 	 *
-	 * On GEN8+ sometimes the second CRC is bonkers as well, so
+	 * On GEN7+ sometimes the second CRC is bonkers as well, so
 	 * don't trust that one either.
 	 */
 	if (pipe_crc->skipped <= 0 ||
-	    (INTEL_GEN(dev_priv) >= 8 && pipe_crc->skipped == 1)) {
+	    (INTEL_GEN(dev_priv) >= 7 && pipe_crc->skipped == 1)) {
 		pipe_crc->skipped++;
 		spin_unlock(&pipe_crc->lock);
 		return;
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-10-23  7:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  5:58 [PATCH 0/1] Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Harish Chegondi
2019-05-16  5:58 ` [PATCH 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Harish Chegondi
2019-05-16  8:30   ` Jani Nikula
2019-05-16 12:46   ` Maarten Lankhorst
2019-05-16 12:55     ` Jani Nikula
2019-05-16 13:30       ` Ville Syrjälä
2019-05-16 15:46         ` Jani Nikula
2019-05-16 21:02         ` Chegondi, Harish
2019-05-16 20:52       ` Chegondi, Harish
2019-10-23  7:24   ` [PATCH v2 0/1] Invalid CRCs causing CRC mismatch test failures Harish Chegondi
2019-10-23  7:24     ` Harish Chegondi [this message]
2019-10-23 22:15       ` [PATCH v2 1/1] drm/i915: skip the second CRC even for GEN 7 GPUs Chegondi, Harish
2019-10-23 22:15         ` [Intel-gfx] " Chegondi, Harish
2019-10-23  8:08     ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork
2019-05-16  6:33 ` ✓ Fi.CI.BAT: success for Reg: igt@kms_pipe_crc_basic@* CRC mismatch test failures Patchwork
2019-05-16  7:51 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bce95a8734ab5ed10c9f26395671ca0995767d2a.1571813756.git.harish.chegondi@intel.com \
    --to=harish.chegondi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.