* [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License
@ 2019-03-01 1:11 Madhumitha Prabakaran
2019-03-01 1:11 ` [PATCH 1/2] Staging: vt6655: Modify comment style of SPDX License Identifier Madhumitha Prabakaran
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-01 1:11 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
This patchset fixes the comment styles of SPDX-License Identifier based
on License Identifier syntax.
Madhumitha Prabakaran (2):
Staging: vt6655: Modify comment style of SPDX License Identifier
Staging: vt6655: Fix comment style of SPDX License Identifier
drivers/staging/vt6655/channel.h | 2 +-
drivers/staging/vt6655/desc.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] Staging: vt6655: Modify comment style of SPDX License Identifier
2019-03-01 1:11 [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License Madhumitha Prabakaran
@ 2019-03-01 1:11 ` Madhumitha Prabakaran
2019-03-01 1:11 ` [PATCH 2/2] Staging: vt6655: Fix " Madhumitha Prabakaran
2019-03-01 7:57 ` [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-01 1:11 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix warning by changing comment style based on header file type as per
License identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/channel.h b/drivers/staging/vt6655/channel.h
index 53f623a4af65..0d2709607456 100644
--- a/drivers/staging/vt6655/channel.h
+++ b/drivers/staging/vt6655/channel.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] Staging: vt6655: Fix comment style of SPDX License Identifier
2019-03-01 1:11 [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License Madhumitha Prabakaran
2019-03-01 1:11 ` [PATCH 1/2] Staging: vt6655: Modify comment style of SPDX License Identifier Madhumitha Prabakaran
@ 2019-03-01 1:11 ` Madhumitha Prabakaran
2019-03-01 7:57 ` [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-01 1:11 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Modify comment style of SPDX License Identifer based on header file type
as per License identifer syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/desc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/desc.h b/drivers/staging/vt6655/desc.h
index b4a0037b40c1..d4572847b08a 100644
--- a/drivers/staging/vt6655/desc.h
+++ b/drivers/staging/vt6655/desc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License
2019-03-01 1:11 [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License Madhumitha Prabakaran
2019-03-01 1:11 ` [PATCH 1/2] Staging: vt6655: Modify comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-01 1:11 ` [PATCH 2/2] Staging: vt6655: Fix " Madhumitha Prabakaran
@ 2019-03-01 7:57 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-03-01 7:57 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: forest, outreachy-kernel
On Thu, Feb 28, 2019 at 07:11:37PM -0600, Madhumitha Prabakaran wrote:
> Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
>
> This patchset fixes the comment styles of SPDX-License Identifier based
> on License Identifier syntax.
>
> Madhumitha Prabakaran (2):
> Staging: vt6655: Modify comment style of SPDX License Identifier
> Staging: vt6655: Fix comment style of SPDX License Identifier
You really are doing the same thing to two different files, so this
could be:
Staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
Staging: vt6655: desc.h: Fix comment style of SPDX License Identifier
right? That makes it more obvious what is going on here, and you don't
have to "reword" the subject lines to be different in tiny ways.
Also, this is a v2 series, right? Please make it v3 next time you
resend it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] Staging: vt6655: Modify comment style of SPDX License Identifier
@ 2019-03-01 0:43 Madhumitha Prabakaran
2019-03-01 0:43 ` [PATCH 2/2] Staging: vt6655: Fix " Madhumitha Prabakaran
0 siblings, 1 reply; 5+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-01 0:43 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix warning by changing comment style based on header file type as per
License identifier syntax.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/channel.h b/drivers/staging/vt6655/channel.h
index 53f623a4af65..0d2709607456 100644
--- a/drivers/staging/vt6655/channel.h
+++ b/drivers/staging/vt6655/channel.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
* All rights reserved.
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-01 7:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 1:11 [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License Madhumitha Prabakaran
2019-03-01 1:11 ` [PATCH 1/2] Staging: vt6655: Modify comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-01 1:11 ` [PATCH 2/2] Staging: vt6655: Fix " Madhumitha Prabakaran
2019-03-01 7:57 ` [PATCH 0/2] Staging: vt6655: Fix comment style of SPDX-License Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-03-01 0:43 [PATCH 1/2] Staging: vt6655: Modify comment style of SPDX License Identifier Madhumitha Prabakaran
2019-03-01 0:43 ` [PATCH 2/2] Staging: vt6655: Fix " Madhumitha Prabakaran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.