Re: [PATCH 1/3] hwsim: check if radio name was already set

Re: [PATCH 1/3] hwsim: check if radio name was already set

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

On 2/18/22 13:55, James Prestwood wrote:
> This was caught by static analysis and shouldn't ever happen.
> ---
>   tools/hwsim.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/hwsim.c b/tools/hwsim.c
> index 3ff3faab..8c076f51 100644
> --- a/tools/hwsim.c
> +++ b/tools/hwsim.c
> @@ -639,6 +639,9 @@ static void get_radio_callback(struct l_genl_msg *msg, void *user_data)
>   			break;
>   
>   		case HWSIM_ATTR_RADIO_NAME:
> +			if (name)
> +				return;
> +

I changed this to break instead of return.

>   			name = l_strndup(data, len);
>   			break;
>   		}
> 

Applied, thanks.

Regards,
-Denis

[PATCH 1/3] hwsim: check if radio name was already set

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

This was caught by static analysis and shouldn't ever happen.
---
 tools/hwsim.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/hwsim.c b/tools/hwsim.c
index 3ff3faab..8c076f51 100644
--- a/tools/hwsim.c
+++ b/tools/hwsim.c
@@ -639,6 +639,9 @@ static void get_radio_callback(struct l_genl_msg *msg, void *user_data)
 			break;
 
 		case HWSIM_ATTR_RADIO_NAME:
+			if (name)
+				return;
+
 			name = l_strndup(data, len);
 			break;
 		}
-- 
2.34.1