All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org,
	drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org,
	linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org
Subject: Re: rename ->make_request_fn and move it to the block_device_operations
Date: Tue, 30 Jun 2020 07:57:29 -0600	[thread overview]
Message-ID: <bd1443c0-be37-115b-1110-df6f0e661a50@kernel.dk> (raw)
In-Reply-To: <20200629193947.2705954-1-hch@lst.de>

On 6/29/20 1:39 PM, Christoph Hellwig wrote:
> Hi Jens,
> 
> this series moves the make_request_fn method into block_device_operations
> with the much more descriptive ->submit_bio name.  It then also gives
> generic_make_request a more descriptive name, and further optimize the
> path to issue to blk-mq, removing the need for the direct_make_request
> bypass.

Looks good to me, and it's a nice cleanup as well. Applied.

-- 
Jens Axboe
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org,
	drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org,
	linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-nvdimm@lists.01.org, linux-nvme@lists.infradead.org,
	linux-s390@vger.kernel.org
Subject: Re: rename ->make_request_fn and move it to the block_device_operations
Date: Tue, 30 Jun 2020 07:57:29 -0600	[thread overview]
Message-ID: <bd1443c0-be37-115b-1110-df6f0e661a50@kernel.dk> (raw)
In-Reply-To: <20200629193947.2705954-1-hch@lst.de>

On 6/29/20 1:39 PM, Christoph Hellwig wrote:
> Hi Jens,
> 
> this series moves the make_request_fn method into block_device_operations
> with the much more descriptive ->submit_bio name.  It then also gives
> generic_make_request a more descriptive name, and further optimize the
> path to issue to blk-mq, removing the need for the direct_make_request
> bypass.

Looks good to me, and it's a nice cleanup as well. Applied.

-- 
Jens Axboe

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-bcache@vger.kernel.org, linux-xtensa@linux-xtensa.org,
	linux-nvdimm@lists.01.org, linux-s390@vger.kernel.org,
	dm-devel@redhat.com, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
	drbd-dev@lists.linbit.com
Subject: Re: rename ->make_request_fn and move it to the block_device_operations
Date: Tue, 30 Jun 2020 07:57:29 -0600	[thread overview]
Message-ID: <bd1443c0-be37-115b-1110-df6f0e661a50@kernel.dk> (raw)
In-Reply-To: <20200629193947.2705954-1-hch@lst.de>

On 6/29/20 1:39 PM, Christoph Hellwig wrote:
> Hi Jens,
> 
> this series moves the make_request_fn method into block_device_operations
> with the much more descriptive ->submit_bio name.  It then also gives
> generic_make_request a more descriptive name, and further optimize the
> path to issue to blk-mq, removing the need for the direct_make_request
> bypass.

Looks good to me, and it's a nice cleanup as well. Applied.

-- 
Jens Axboe


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-bcache@vger.kernel.org, linux-xtensa@linux-xtensa.org,
	linux-nvdimm@lists.01.org, linux-s390@vger.kernel.org,
	dm-devel@redhat.com, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
	drbd-dev@lists.linbit.com
Subject: Re: rename ->make_request_fn and move it to the block_device_operations
Date: Tue, 30 Jun 2020 07:57:29 -0600	[thread overview]
Message-ID: <bd1443c0-be37-115b-1110-df6f0e661a50@kernel.dk> (raw)
In-Reply-To: <20200629193947.2705954-1-hch@lst.de>

On 6/29/20 1:39 PM, Christoph Hellwig wrote:
> Hi Jens,
> 
> this series moves the make_request_fn method into block_device_operations
> with the much more descriptive ->submit_bio name.  It then also gives
> generic_make_request a more descriptive name, and further optimize the
> path to issue to blk-mq, removing the need for the direct_make_request
> bypass.

Looks good to me, and it's a nice cleanup as well. Applied.

-- 
Jens Axboe


  parent reply	other threads:[~2020-06-30 13:57 UTC|newest]

Thread overview: 143+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 19:39 rename ->make_request_fn and move it to the block_device_operations Christoph Hellwig
2020-06-29 19:39 ` Christoph Hellwig
2020-06-29 19:39 ` Christoph Hellwig
2020-06-29 19:39 ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 01/20] nfblock: stop using ->queuedata Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 21:47   ` Geert Uytterhoeven
2020-06-29 21:47     ` Geert Uytterhoeven
2020-06-29 21:47     ` Geert Uytterhoeven
2020-06-29 21:47     ` Geert Uytterhoeven
2020-06-29 21:47     ` Geert Uytterhoeven
2020-06-29 19:39 ` [PATCH 02/20] simdisk: " Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 03/20] drbd: " Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 04/20] null_blk: stop using ->queuedata for bio mode Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 05/20] ps3vram: stop using ->queuedata Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 06/20] rsxx: " Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 07/20] umem: " Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 08/20] zram: " Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 09/20] bcache: stop setting ->queuedata Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 10/20] dm: stop using ->queuedata Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 11/20] fs: remove a weird comment in submit_bh_wbc Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-30 13:54   ` Jens Axboe
2020-06-30 13:54     ` Jens Axboe
2020-06-30 13:54     ` Jens Axboe
2020-06-30 13:54     ` Jens Axboe
2020-06-29 19:39 ` [PATCH 12/20] block: remove the request_queue argument from blk_queue_split Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 13/20] block: tidy up a warning in bio_check_ro Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 14/20] block: remove the NULL queue check in generic_make_request_checks Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 15/20] block: remove the nr_sectors variable " Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 16/20] block: move ->make_request_fn to struct block_device_operations Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 17/20] block: rename generic_make_request to submit_bio_noacct Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 18/20] block: refator submit_bio_noacct Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-07-02 14:10   ` Qian Cai
2020-07-02 14:10     ` Qian Cai
2020-07-02 14:10     ` Qian Cai
2020-07-02 14:10     ` Qian Cai
2020-07-02 15:14     ` Christoph Hellwig
2020-07-02 15:14       ` Christoph Hellwig
2020-07-02 15:14       ` Christoph Hellwig
2020-07-02 15:14       ` Christoph Hellwig
2020-07-02 15:14       ` Christoph Hellwig
2020-07-02 15:52       ` Naresh Kamboju
2020-07-02 15:52         ` Naresh Kamboju
2020-07-02 15:52         ` Naresh Kamboju
2020-07-02 15:52         ` Naresh Kamboju
2020-07-02 15:15     ` Naresh Kamboju
2020-07-02 15:15       ` Naresh Kamboju
2020-07-02 15:15       ` Naresh Kamboju
2020-07-02 15:15       ` Naresh Kamboju
2020-06-29 19:39 ` [PATCH 19/20] block: shortcut __submit_bio_noacct for blk-mq drivers Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39 ` [PATCH 20/20] block: remove direct_make_request Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-29 19:39   ` Christoph Hellwig
2020-06-30 13:57 ` Jens Axboe [this message]
2020-06-30 13:57   ` rename ->make_request_fn and move it to the block_device_operations Jens Axboe
2020-06-30 13:57   ` Jens Axboe
2020-06-30 13:57   ` Jens Axboe
2020-06-30 15:43   ` Jens Axboe
2020-06-30 15:43     ` Jens Axboe
2020-06-30 15:43     ` Jens Axboe
2020-06-30 15:43     ` Jens Axboe
2020-06-30 18:19     ` Christoph Hellwig
2020-06-30 18:19       ` Christoph Hellwig
2020-06-30 18:19       ` Christoph Hellwig
2020-06-30 18:19       ` Christoph Hellwig
2020-06-30 18:21       ` Jens Axboe
2020-06-30 18:21         ` Jens Axboe
2020-06-30 18:21         ` Jens Axboe
2020-06-30 18:21         ` Jens Axboe
2020-06-30 18:55         ` Jens Axboe
2020-06-30 18:55           ` Jens Axboe
2020-06-30 18:55           ` Jens Axboe
2020-06-30 18:55           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd1443c0-be37-115b-1110-df6f0e661a50@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=hch@lst.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.