* [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c
@ 2020-05-04 9:44 Mauro Carvalho Chehab
2020-05-04 14:10 ` Dave Hansen
0 siblings, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2020-05-04 9:44 UTC (permalink / raw)
To: Linux Doc Mailing List, Shuah Khan
Cc: Mauro Carvalho Chehab, linux-kernel, Jonathan Corbet,
Andrew Morton, Dave Hansen, Stephen Rothwell, Sandipan Das,
Ram Pai, Thiago Jung Bauermann, linux-kselftest
Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book")
from Jun 7, 2019 converted protection-keys.txt file to ReST.
A recent change at protection_keys.c partially reverted such
changeset, causing it to point to a non-existing file:
- * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
+ * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
It sounds to me that the changeset that introduced such change
4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
could also have other side effects, as it sounds that it was not
generated against uptream code, but, instead, against a version
older than Jun 7, 2019.
Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
tools/testing/selftests/vm/protection_keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c
index fc19addcb5c8..fdbb602ecf32 100644
--- a/tools/testing/selftests/vm/protection_keys.c
+++ b/tools/testing/selftests/vm/protection_keys.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
/*
- * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
+ * Tests Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
*
* There are examples in here of:
* * how to set protection keys on memory
--
2.25.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c
2020-05-04 9:44 [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c Mauro Carvalho Chehab
@ 2020-05-04 14:10 ` Dave Hansen
2020-05-04 14:38 ` Sandipan Das
0 siblings, 1 reply; 4+ messages in thread
From: Dave Hansen @ 2020-05-04 14:10 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Doc Mailing List, Shuah Khan
Cc: linux-kernel, Jonathan Corbet, Andrew Morton, Stephen Rothwell,
Sandipan Das, Ram Pai, Thiago Jung Bauermann, linux-kselftest
On 5/4/20 2:44 AM, Mauro Carvalho Chehab wrote:
> Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book")
> from Jun 7, 2019 converted protection-keys.txt file to ReST.
>
> A recent change at protection_keys.c partially reverted such
> changeset, causing it to point to a non-existing file:
>
> - * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
> + * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
>
> It sounds to me that the changeset that introduced such change
> 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
> could also have other side effects, as it sounds that it was not
> generated against uptream code, but, instead, against a version
> older than Jun 7, 2019.
>
> Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thanks for finding this! The patch set which moved protection-keys.txt
out of x86 code probably just missed this when it got rebased. It
originated well before June 2019, iirc.
Acked-by: Dave Hansen <dave.hansen@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c
2020-05-04 14:10 ` Dave Hansen
@ 2020-05-04 14:38 ` Sandipan Das
2020-05-08 15:54 ` shuah
0 siblings, 1 reply; 4+ messages in thread
From: Sandipan Das @ 2020-05-04 14:38 UTC (permalink / raw)
To: Dave Hansen, Mauro Carvalho Chehab
Cc: Linux Doc Mailing List, Shuah Khan, linux-kernel,
Jonathan Corbet, Andrew Morton, Stephen Rothwell, Ram Pai,
Thiago Jung Bauermann, linux-kselftest
On 04/05/20 7:40 pm, Dave Hansen wrote:
> On 5/4/20 2:44 AM, Mauro Carvalho Chehab wrote:
>> Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book")
>> from Jun 7, 2019 converted protection-keys.txt file to ReST.
>>
>> A recent change at protection_keys.c partially reverted such
>> changeset, causing it to point to a non-existing file:
>>
>> - * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
>> + * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
>>
>> It sounds to me that the changeset that introduced such change
>> 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
>> could also have other side effects, as it sounds that it was not
>> generated against uptream code, but, instead, against a version
>> older than Jun 7, 2019.
>>
>> Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Thanks for finding this! The patch set which moved protection-keys.txt
> out of x86 code probably just missed this when it got rebased. It
> originated well before June 2019, iirc.
>
That's right. Sorry about that. Must have missed it when rebasing the
older pkey selftest patches. Thanks for fixing this Mauro.
Acked-by: Sandipan Das <sandipan@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c
2020-05-04 14:38 ` Sandipan Das
@ 2020-05-08 15:54 ` shuah
0 siblings, 0 replies; 4+ messages in thread
From: shuah @ 2020-05-08 15:54 UTC (permalink / raw)
To: Sandipan Das, Dave Hansen, Mauro Carvalho Chehab, Andrew Morton
Cc: Linux Doc Mailing List, linux-kernel, Jonathan Corbet,
Stephen Rothwell, Ram Pai, Thiago Jung Bauermann,
linux-kselftest, shuah
On 5/4/20 8:38 AM, Sandipan Das wrote:
>
>
> On 04/05/20 7:40 pm, Dave Hansen wrote:
>> On 5/4/20 2:44 AM, Mauro Carvalho Chehab wrote:
>>> Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book")
checkpatch doesn't like this commit description.
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 1eecbcdca2bd ("docs: move
protection-keys.rst to the core-api book")'
#72:
Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api
book")
>>> from Jun 7, 2019 converted protection-keys.txt file to ReST.
>>>
>>> A recent change at protection_keys.c partially reverted such
>>> changeset, causing it to point to a non-existing file:
>>>
>>> - * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
>>> + * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
>>>
>>> It sounds to me that the changeset that introduced such change
>>> 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
>>> could also have other side effects, as it sounds that it was not
>>> generated against uptream code, but, instead, against a version
>>> older than Jun 7, 2019.
>>>
>>> Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
WARNING: Unknown commit id '4645e3563673', maybe rebased or not pulled?
#87:
Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru
to a generic name")
This commit didn't land in Linux 5.7-rc4 yet looks like. Probably in mm
or doc tree and has dependency on it?
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-08 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 9:44 [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c Mauro Carvalho Chehab
2020-05-04 14:10 ` Dave Hansen
2020-05-04 14:38 ` Sandipan Das
2020-05-08 15:54 ` shuah
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.