From: Pu Wen <puwen@hygon.cn>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Brian Woods <brian.woods@amd.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2 03/14] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU
Date: Tue, 19 Mar 2019 19:32:22 +0800 [thread overview]
Message-ID: <bd5c83cd-cb9d-d4c2-0fd1-6d226de6ea8a@hygon.cn> (raw)
In-Reply-To: <5C8F5DE0020000780021FB8E@prv1-mh.provo.novell.com>
On 2019/3/18 16:59, Jan Beulich wrote:
>>>> On 16.03.19 at 11:11, <puwen@hygon.cn> wrote:
>> On 2019/3/15 20:41, Jan Beulich wrote:
>>>>>> On 21.02.19 at 10:50, <puwen@hygon.cn> wrote:
>>>> --- a/xen/arch/x86/cpu/vpmu_amd.c
>>>> +++ b/xen/arch/x86/cpu/vpmu_amd.c
>>>> @@ -545,6 +545,8 @@ int __init amd_vpmu_init(void)
>>>> switch ( current_cpu_data.x86 )
>>>> {
>>>> case 0x15:
>>>> + case 0x17:
>>>> + case 0x18:
>>>> num_counters = F15H_NUM_COUNTERS;
>>>> counters = AMD_F15H_COUNTERS;
>>>> ctrls = AMD_F15H_CTRLS;
>>>
>>> Unless you know what AMD Fam18 will look like, you can't do it
>>> like this. Fam18 really needs to be further qualified by a vendor
>>> check at this point in time.
>>
>> Hygon will negotiate with AMD to make sure that only Hygon should use
>> Fam18h.
>
> In the success case of which please state this in the description.
> Until those negotiations have succeeded I'm afraid I'm going to
> insist to see the extra check added.
How to check vendor? Maybe like this:
case 0x15:
case 0x17:
case 0x18:
if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
boot_cpu_data.x86 == 0x18)
return -EINVAL;
num_counters = F15H_NUM_COUNTERS;
counters = AMD_F15H_COUNTERS;
ctrls = AMD_F15H_CTRLS;
or just add Hygon support at beginning of amd_vpmu_init():
if (boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) {
num_counters = F15H_NUM_COUNTERS;
counters = AMD_F15H_COUNTERS;
ctrls = AMD_F15H_CTRLS;
k7_counters_mirrored = 1;
}
--
Regards,
Pu Wen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-19 11:38 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 9:48 [PATCH v2 00/14] Add support for Hygon Dhyana Family 18h processor Pu Wen
2019-02-21 9:48 ` [PATCH v2 01/14] x86/cpu: Create Hygon Dhyana architecture support file Pu Wen
2019-03-14 17:10 ` Jan Beulich
2019-03-15 10:17 ` Pu Wen
2019-03-15 11:17 ` Jan Beulich
2019-03-16 9:57 ` Pu Wen
2019-03-18 8:54 ` Jan Beulich
2019-03-19 12:33 ` Pu Wen
2019-03-19 13:02 ` Jan Beulich
2019-03-19 13:34 ` Pu Wen
2019-02-21 9:48 ` [PATCH v2 02/14] x86/cpu/mtrr: Add Hygon Dhyana support to get TOP_MEM2 Pu Wen
2019-03-15 12:39 ` Jan Beulich
2019-03-16 10:06 ` Pu Wen
2019-03-18 8:57 ` Jan Beulich
2019-03-18 15:51 ` Pu Wen
2019-03-18 16:51 ` Jan Beulich
2019-02-21 9:50 ` [PATCH v2 03/14] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU Pu Wen
2019-03-15 12:41 ` Jan Beulich
2019-03-16 10:11 ` Pu Wen
2019-03-18 8:59 ` Jan Beulich
2019-03-19 11:32 ` Pu Wen [this message]
2019-03-19 12:57 ` Jan Beulich
2019-03-19 13:47 ` Pu Wen
2019-03-19 13:57 ` Jan Beulich
2019-03-19 15:22 ` Pu Wen
2019-02-21 9:51 ` [PATCH v2 04/14] x86/cpu/mce: Add Hygon Dhyana support to the MCA infrastructure Pu Wen
2019-03-15 12:47 ` Jan Beulich
2019-02-21 9:51 ` [PATCH v2 05/14] x86/spec_ctrl: Add Hygon Dhyana to the respective mitigation machinery Pu Wen
2019-03-15 12:47 ` Jan Beulich
2019-02-21 9:51 ` [PATCH v2 06/14] x86/apic: Add Hygon Dhyana support Pu Wen
2019-03-15 12:48 ` Jan Beulich
2019-02-21 9:52 ` [PATCH v2 07/14] x86/acpi: " Pu Wen
2019-03-15 12:49 ` Jan Beulich
2019-02-21 9:52 ` [PATCH v2 08/14] x86/iommu: " Pu Wen
2019-03-15 13:18 ` Jan Beulich
2019-02-21 9:52 ` [PATCH v2 09/14] x86/pv: Add Hygon Dhyana support to emulate MSRs access Pu Wen
2019-03-15 13:23 ` Jan Beulich
2019-02-21 9:53 ` [PATCH v2 10/14] x86/domain: Add Hygon Dhyana support Pu Wen
2019-03-15 13:24 ` Jan Beulich
2019-02-21 9:53 ` [PATCH v2 11/14] x86/domctl: " Pu Wen
2019-03-15 13:28 ` Jan Beulich
2019-03-16 10:14 ` Pu Wen
2019-02-21 9:53 ` [PATCH v2 12/14] x86/traps: " Pu Wen
2019-02-21 9:54 ` [PATCH v2 13/14] x86/cpuid: " Pu Wen
2019-03-15 13:29 ` Jan Beulich
2019-02-21 9:54 ` [PATCH v2 14/14] tools/libxc: " Pu Wen
2019-02-21 16:37 ` [PATCH v2 00/14] Add support for Hygon Dhyana Family 18h processor Wei Liu
2019-02-22 2:30 ` Pu Wen
2019-02-22 13:21 ` Wei Liu
2019-03-15 13:41 ` Jan Beulich
2019-03-16 10:40 ` Pu Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd5c83cd-cb9d-d4c2-0fd1-6d226de6ea8a@hygon.cn \
--to=puwen@hygon.cn \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brian.woods@amd.com \
--cc=roger.pau@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.