All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark yao <mark.yao@rock-chips.com>
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: briannorris@chromium.org, seanpaul@chromium.org,
	dianders@chromium.org, heiko@sntech.de, tfiga@chromium.org,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	David Airlie <airlied@linux.ie>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 10/10] drm/rockchip: dw_hdmi: Fix error handling path
Date: Fri, 20 Oct 2017 09:51:16 +0800	[thread overview]
Message-ID: <bd662144-78c8-b448-6dd0-36d68bacca44@rock-chips.com> (raw)
In-Reply-To: <20171019034812.13768-11-jeffy.chen@rock-chips.com>

On 2017年10月19日 11:48, Jeffy Chen wrote:
> Add missing clk_disable_unprepare() in bind()'s error handling path and
> unbind().
>
> Also inline clk_prepare_enable() with bind().
>
> Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support")
> Signed-off-by: Jeffy Chen<jeffy.chen@rock-chips.com>

Looks good for me
Acked-by: Mark Yao <mark.yao@rock-chips.com>

Mark

WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: briannorris@chromium.org, dianders@chromium.org,
	dri-devel@lists.freedesktop.org, tfiga@chromium.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 10/10] drm/rockchip: dw_hdmi: Fix error handling path
Date: Fri, 20 Oct 2017 09:51:16 +0800	[thread overview]
Message-ID: <bd662144-78c8-b448-6dd0-36d68bacca44@rock-chips.com> (raw)
In-Reply-To: <20171019034812.13768-11-jeffy.chen@rock-chips.com>

On 2017年10月19日 11:48, Jeffy Chen wrote:
> Add missing clk_disable_unprepare() in bind()'s error handling path and
> unbind().
>
> Also inline clk_prepare_enable() with bind().
>
> Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support")
> Signed-off-by: Jeffy Chen<jeffy.chen@rock-chips.com>

Looks good for me
Acked-by: Mark Yao <mark.yao@rock-chips.com>

Mark


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 10/10] drm/rockchip: dw_hdmi: Fix error handling path
Date: Fri, 20 Oct 2017 09:51:16 +0800	[thread overview]
Message-ID: <bd662144-78c8-b448-6dd0-36d68bacca44@rock-chips.com> (raw)
In-Reply-To: <20171019034812.13768-11-jeffy.chen@rock-chips.com>

On 2017?10?19? 11:48, Jeffy Chen wrote:
> Add missing clk_disable_unprepare() in bind()'s error handling path and
> unbind().
>
> Also inline clk_prepare_enable() with bind().
>
> Fixes: 12b9f204e804 ("drm: bridge/dw_hdmi: add rockchip rk3288 support")
> Signed-off-by: Jeffy Chen<jeffy.chen@rock-chips.com>

Looks good for me
Acked-by: Mark Yao <mark.yao@rock-chips.com>

Mark

  reply	other threads:[~2017-10-20  1:51 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  3:48 [PATCH v6 00/10] rockchip: kevin: Enable edp display Jeffy Chen
2017-10-19  3:48 ` Jeffy Chen
2017-10-19  3:48 ` Jeffy Chen
2017-10-19  3:48 ` Jeffy Chen
2017-10-19  3:48 ` [PATCH v6 01/10] arm64: dts: rockchip: Enable edp disaplay on kevin Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-12-01 12:28   ` Enric Balletbo Serra
2017-12-01 12:28     ` Enric Balletbo Serra
2017-12-01 12:28     ` Enric Balletbo Serra
2017-12-04 17:59   ` Heiko Stuebner
2017-12-04 17:59     ` Heiko Stuebner
2017-12-04 17:59     ` Heiko Stuebner
2017-10-19  3:48 ` [PATCH v6 02/10] drm/rockchip: analogix_dp: Remove unnecessary init code Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-20  1:48   ` Mark yao
2017-10-20  1:48     ` Mark yao
2017-10-20 17:05     ` Sean Paul
2017-10-20 17:05       ` Sean Paul
2017-10-19  3:48 ` [PATCH v6 03/10] drm/bridge: analogix: Do not use device's drvdata Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-20 16:52   ` Sean Paul
2017-10-20 16:52     ` Sean Paul
2017-10-20 16:52     ` Sean Paul
2017-10-20 23:14     ` jeffy
2017-10-20 23:14       ` jeffy
2017-10-20 23:14       ` jeffy
2017-10-19  3:48 ` [PATCH v6 04/10] drm/bridge: analogix_dp: Fix connector and encoder cleanup Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48 ` [PATCH v6 05/10] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register() Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-20  1:49   ` Mark yao
2017-10-20  1:49     ` Mark yao
2017-10-20  1:49     ` Mark yao
2017-10-19  3:48 ` [PATCH v6 06/10] drm/rockchip: dw-mipi-dsi: Fix error handling path Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-20  1:50   ` Mark yao
2017-10-20  1:50     ` Mark yao
2017-10-19  3:48 ` [PATCH v6 07/10] drm/rockchip: inno_hdmi: " Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-20  1:50   ` Mark yao
2017-10-20  1:50     ` Mark yao
2017-10-19  3:48 ` [PATCH v6 08/10] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach Jeffy Chen
2017-10-19  3:48 ` [PATCH v6 09/10] drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-19  3:48 ` [PATCH v6 10/10] drm/rockchip: dw_hdmi: Fix error handling path Jeffy Chen
2017-10-19  3:48   ` Jeffy Chen
2017-10-20  1:51   ` Mark yao [this message]
2017-10-20  1:51     ` Mark yao
2017-10-20  1:51     ` Mark yao
2017-10-20 17:07 ` [PATCH v6 00/10] rockchip: kevin: Enable edp display Sean Paul
2017-10-20 17:07   ` Sean Paul
2017-10-20 17:07   ` Sean Paul
2017-10-20 17:07   ` Sean Paul
2017-10-30 23:01 ` Heiko Stuebner
2017-10-30 23:01   ` Heiko Stuebner
2017-10-30 23:01   ` Heiko Stuebner
2017-10-30 23:01   ` Heiko Stuebner
2017-10-31  4:37   ` JeffyChen
2017-10-31  4:37     ` JeffyChen
2017-10-31  4:37     ` JeffyChen
2017-10-31  4:37     ` JeffyChen
2017-11-01 19:33     ` Sean Paul
2017-11-01 19:33       ` Sean Paul
2017-11-01 19:33       ` Sean Paul
2017-11-01 19:33       ` Sean Paul
2017-11-10 12:15       ` Enric Balletbo Serra
2017-11-10 12:15         ` Enric Balletbo Serra
2017-11-10 12:15         ` Enric Balletbo Serra
2017-11-10 12:15         ` Enric Balletbo Serra
2017-11-10 12:15         ` Enric Balletbo Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd662144-78c8-b448-6dd0-36d68bacca44@rock-chips.com \
    --to=mark.yao@rock-chips.com \
    --cc=airlied@linux.ie \
    --cc=briannorris@chromium.org \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=jeffy.chen@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=seanpaul@chromium.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.