All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] media: stm32-dcmi: Use dma_request_chan() instead dma_request_slave_channel()
@ 2020-01-07 11:52 ` Peter Ujfalusi
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2020-01-07 11:52 UTC (permalink / raw)
  To: mchehab, hugues.fruchet, mcoquelin.stm32, alexandre.torgue
  Cc: vkoul, linux-media, linux-kernel, linux-stm32, linux-arm-kernel

dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

By using dma_request_chan() directly the driver can support deferred
probing against DMA.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi,

Changes since v1:
- Do not print error for EPROBE_DEFER

Regards,
Peter

 drivers/media/platform/stm32/stm32-dcmi.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index 9392e3409fba..b63ff8d636ce 100644
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -1910,10 +1910,13 @@ static int dcmi_probe(struct platform_device *pdev)
 		return PTR_ERR(mclk);
 	}
 
-	chan = dma_request_slave_channel(&pdev->dev, "tx");
-	if (!chan) {
-		dev_info(&pdev->dev, "Unable to request DMA channel, defer probing\n");
-		return -EPROBE_DEFER;
+	chan = dma_request_chan(&pdev->dev, "tx");
+	if (IS_ERR(chan)) {
+		ret = PTR_ERR(chan);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev,
+				"Failed to request DMA channel: %d\n", ret);
+		return ret;
 	}
 
 	spin_lock_init(&dcmi->irqlock);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v2] media: stm32-dcmi: Use dma_request_chan() instead dma_request_slave_channel()
@ 2020-01-07 11:52 ` Peter Ujfalusi
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2020-01-07 11:52 UTC (permalink / raw)
  To: mchehab, hugues.fruchet, mcoquelin.stm32, alexandre.torgue
  Cc: vkoul, linux-stm32, linux-kernel, linux-arm-kernel, linux-media

dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

By using dma_request_chan() directly the driver can support deferred
probing against DMA.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi,

Changes since v1:
- Do not print error for EPROBE_DEFER

Regards,
Peter

 drivers/media/platform/stm32/stm32-dcmi.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index 9392e3409fba..b63ff8d636ce 100644
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -1910,10 +1910,13 @@ static int dcmi_probe(struct platform_device *pdev)
 		return PTR_ERR(mclk);
 	}
 
-	chan = dma_request_slave_channel(&pdev->dev, "tx");
-	if (!chan) {
-		dev_info(&pdev->dev, "Unable to request DMA channel, defer probing\n");
-		return -EPROBE_DEFER;
+	chan = dma_request_chan(&pdev->dev, "tx");
+	if (IS_ERR(chan)) {
+		ret = PTR_ERR(chan);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev,
+				"Failed to request DMA channel: %d\n", ret);
+		return ret;
 	}
 
 	spin_lock_init(&dcmi->irqlock);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: stm32-dcmi: Use dma_request_chan() instead dma_request_slave_channel()
  2020-01-07 11:52 ` Peter Ujfalusi
@ 2020-01-07 13:38   ` Hugues FRUCHET
  -1 siblings, 0 replies; 4+ messages in thread
From: Hugues FRUCHET @ 2020-01-07 13:38 UTC (permalink / raw)
  To: Peter Ujfalusi, mchehab, mcoquelin.stm32, Alexandre TORGUE
  Cc: vkoul, linux-media, linux-kernel, linux-stm32, linux-arm-kernel

Acked-by: Hugues Fruchet <hugues.fruchet@st.com>

On 1/7/20 12:52 PM, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
> 
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi,
> 
> Changes since v1:
> - Do not print error for EPROBE_DEFER
> 
> Regards,
> Peter
> 
>   drivers/media/platform/stm32/stm32-dcmi.c | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index 9392e3409fba..b63ff8d636ce 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1910,10 +1910,13 @@ static int dcmi_probe(struct platform_device *pdev)
>   		return PTR_ERR(mclk);
>   	}
>   
> -	chan = dma_request_slave_channel(&pdev->dev, "tx");
> -	if (!chan) {
> -		dev_info(&pdev->dev, "Unable to request DMA channel, defer probing\n");
> -		return -EPROBE_DEFER;
> +	chan = dma_request_chan(&pdev->dev, "tx");
> +	if (IS_ERR(chan)) {
> +		ret = PTR_ERR(chan);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev,
> +				"Failed to request DMA channel: %d\n", ret);
> +		return ret;
>   	}
>   
>   	spin_lock_init(&dcmi->irqlock);
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: stm32-dcmi: Use dma_request_chan() instead dma_request_slave_channel()
@ 2020-01-07 13:38   ` Hugues FRUCHET
  0 siblings, 0 replies; 4+ messages in thread
From: Hugues FRUCHET @ 2020-01-07 13:38 UTC (permalink / raw)
  To: Peter Ujfalusi, mchehab, mcoquelin.stm32, Alexandre TORGUE
  Cc: vkoul, linux-stm32, linux-kernel, linux-arm-kernel, linux-media

Acked-by: Hugues Fruchet <hugues.fruchet@st.com>

On 1/7/20 12:52 PM, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
> 
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi,
> 
> Changes since v1:
> - Do not print error for EPROBE_DEFER
> 
> Regards,
> Peter
> 
>   drivers/media/platform/stm32/stm32-dcmi.c | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index 9392e3409fba..b63ff8d636ce 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1910,10 +1910,13 @@ static int dcmi_probe(struct platform_device *pdev)
>   		return PTR_ERR(mclk);
>   	}
>   
> -	chan = dma_request_slave_channel(&pdev->dev, "tx");
> -	if (!chan) {
> -		dev_info(&pdev->dev, "Unable to request DMA channel, defer probing\n");
> -		return -EPROBE_DEFER;
> +	chan = dma_request_chan(&pdev->dev, "tx");
> +	if (IS_ERR(chan)) {
> +		ret = PTR_ERR(chan);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev,
> +				"Failed to request DMA channel: %d\n", ret);
> +		return ret;
>   	}
>   
>   	spin_lock_init(&dcmi->irqlock);
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-07 13:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 11:52 [PATCH v2] media: stm32-dcmi: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-01-07 11:52 ` Peter Ujfalusi
2020-01-07 13:38 ` Hugues FRUCHET
2020-01-07 13:38   ` Hugues FRUCHET

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.