All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Jing Zhang <jingzhangos@google.com>, KVM <kvm@vger.kernel.org>,
	KVMARM <kvmarm@lists.cs.columbia.edu>,
	LinuxMIPS <linux-mips@vger.kernel.org>,
	KVMPPC <kvm-ppc@vger.kernel.org>,
	LinuxS390 <linux-s390@vger.kernel.org>,
	Linuxkselftest <linux-kselftest@vger.kernel.org>,
	Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Will Deacon <will@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Paul Mackerras <paulus@ozlabs.org>,
	Janosch Frank <frankja@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Sean Christopherson <seanjc@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Rientjes <rientjes@google.com>,
	Emanuele Giuseppe Esposito <eesposit@redhat.com>,
	David Matlack <dmatlack@google.com>,
	Ricardo Koller <ricarkol@google.com>,
	Krish Sadhukhan <krish.sadhukhan@oracle.com>
Subject: Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones
Date: Fri, 11 Jun 2021 12:51:25 +0200	[thread overview]
Message-ID: <bdd315f7-0615-af69-90c3-1e5646f3e259@redhat.com> (raw)
In-Reply-To: <03f3fa03-6f61-7864-4867-3dc332a9d6f3@de.ibm.com>

On 11/06/21 08:57, Christian Borntraeger wrote:
>> @@ -755,12 +750,12 @@ struct kvm_vcpu_arch {
>>   };
>>   struct kvm_vm_stat {
>> +    struct kvm_vm_stat_generic generic;
> 
> s390 does not have remote_tlb_flush. I guess this does not hurt?

It would have to be accounted in gmap_flush_tlb, but there is no struct 
kvm in there.  A slightly hackish possibility would be to include the 
gmap by value (instead of by pointer) in struct kvm, and then use 
container_of.

This reminds me that I have never asked you why the gmap code is not in 
arch/s390/kvm, and also that there is no code in QEMU that uses 
KVM_VM_S390_UCONTROL or KVM_S390_VCPU_FAULT.  It would be nice to have 
some testcases for that, and also for KVM_S390_VCPU_FAULT with regular 
virtual machines... or to remove the code if it's unused.

Thanks,

Paolo


WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Jing Zhang <jingzhangos@google.com>, KVM <kvm@vger.kernel.org>,
	KVMARM <kvmarm@lists.cs.columbia.edu>,
	LinuxMIPS <linux-mips@vger.kernel.org>,
	KVMPPC <kvm-ppc@vger.kernel.org>,
	LinuxS390 <linux-s390@vger.kernel.org>,
	Linuxkselftest <linux-kselftest@vger.kernel.org>,
	Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Will Deacon <will@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Paul Mackerras <paulus@ozlabs.org>,
	Janosch Frank <frankja@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Sean Christopherson <seanjc@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Rientjes <rientjes@google.com>,
	Emanuele Giuseppe Esposito <eesposit@redhat.com>,
	David Matlack <dmatlack@google.com>,
	Ricardo Koller <ricarkol@google.com>,
	Krish Sadhukhan <krish.sadhukhan@oracle.com>
Subject: Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones
Date: Fri, 11 Jun 2021 12:51:25 +0200	[thread overview]
Message-ID: <bdd315f7-0615-af69-90c3-1e5646f3e259@redhat.com> (raw)
In-Reply-To: <03f3fa03-6f61-7864-4867-3dc332a9d6f3@de.ibm.com>

On 11/06/21 08:57, Christian Borntraeger wrote:
>> @@ -755,12 +750,12 @@ struct kvm_vcpu_arch {
>>   };
>>   struct kvm_vm_stat {
>> +    struct kvm_vm_stat_generic generic;
> 
> s390 does not have remote_tlb_flush. I guess this does not hurt?

It would have to be accounted in gmap_flush_tlb, but there is no struct 
kvm in there.  A slightly hackish possibility would be to include the 
gmap by value (instead of by pointer) in struct kvm, and then use 
container_of.

This reminds me that I have never asked you why the gmap code is not in 
arch/s390/kvm, and also that there is no code in QEMU that uses 
KVM_VM_S390_UCONTROL or KVM_S390_VCPU_FAULT.  It would be nice to have 
some testcases for that, and also for KVM_S390_VCPU_FAULT with regular 
virtual machines... or to remove the code if it's unused.

Thanks,

Paolo

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Jing Zhang <jingzhangos@google.com>, KVM <kvm@vger.kernel.org>,
	KVMARM <kvmarm@lists.cs.columbia.edu>,
	LinuxMIPS <linux-mips@vger.kernel.org>,
	KVMPPC <kvm-ppc@vger.kernel.org>,
	LinuxS390 <linux-s390@vger.kernel.org>,
	Linuxkselftest <linux-kselftest@vger.kernel.org>,
	Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Will Deacon <will@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Paul Mackerras <paulus@ozlabs.org>,
	Janosch Frank <frankja@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Sean Christopherson <seanjc@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Rientjes <rientjes@google.com>,
	Emanuele Giuseppe Esposito <eesposit@redhat.com>,
	David Matlack <dmatlack@google.com>,
	Ricardo Koller <ricarkol@google.com>,
	Krish Sadhukhan <krish.sadhukhan@oracle.com>
Subject: Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones
Date: Fri, 11 Jun 2021 10:51:25 +0000	[thread overview]
Message-ID: <bdd315f7-0615-af69-90c3-1e5646f3e259@redhat.com> (raw)
In-Reply-To: <03f3fa03-6f61-7864-4867-3dc332a9d6f3@de.ibm.com>

On 11/06/21 08:57, Christian Borntraeger wrote:
>> @@ -755,12 +750,12 @@ struct kvm_vcpu_arch {
>>   };
>>   struct kvm_vm_stat {
>> +    struct kvm_vm_stat_generic generic;
> 
> s390 does not have remote_tlb_flush. I guess this does not hurt?

It would have to be accounted in gmap_flush_tlb, but there is no struct 
kvm in there.  A slightly hackish possibility would be to include the 
gmap by value (instead of by pointer) in struct kvm, and then use 
container_of.

This reminds me that I have never asked you why the gmap code is not in 
arch/s390/kvm, and also that there is no code in QEMU that uses 
KVM_VM_S390_UCONTROL or KVM_S390_VCPU_FAULT.  It would be nice to have 
some testcases for that, and also for KVM_S390_VCPU_FAULT with regular 
virtual machines... or to remove the code if it's unused.

Thanks,

Paolo

  reply	other threads:[~2021-06-11 10:51 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 21:14 [PATCH v7 0/4] KVM statistics data fd-based binary interface Jing Zhang
2021-06-03 21:14 ` Jing Zhang
2021-06-03 21:14 ` Jing Zhang
2021-06-03 21:14 ` [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones Jing Zhang
2021-06-03 21:14   ` Jing Zhang
2021-06-03 21:14   ` Jing Zhang
2021-06-07 19:22   ` Krish Sadhukhan
2021-06-07 19:22     ` Krish Sadhukhan
2021-06-07 19:22     ` Krish Sadhukhan
2021-06-11  6:57   ` Christian Borntraeger
2021-06-11  6:57     ` Christian Borntraeger
2021-06-11  6:57     ` Christian Borntraeger
2021-06-11 10:51     ` Paolo Bonzini [this message]
2021-06-11 10:51       ` Paolo Bonzini
2021-06-11 10:51       ` Paolo Bonzini
2021-06-11 12:00       ` Christian Borntraeger
2021-06-11 12:00         ` Christian Borntraeger
2021-06-11 12:00         ` Christian Borntraeger
2021-06-11 12:03         ` Paolo Bonzini
2021-06-11 12:03           ` Paolo Bonzini
2021-06-11 12:03           ` Paolo Bonzini
2021-06-11 12:08           ` Christian Borntraeger
2021-06-11 12:08             ` Christian Borntraeger
2021-06-11 12:08             ` Christian Borntraeger
2021-06-11 12:14             ` Paolo Bonzini
2021-06-11 12:14               ` Paolo Bonzini
2021-06-11 12:14               ` Paolo Bonzini
2021-06-03 21:14 ` [PATCH v7 2/4] KVM: stats: Add fd-based API to read binary stats data Jing Zhang
2021-06-03 21:14   ` Jing Zhang
2021-06-03 21:14   ` Jing Zhang
2021-06-07 19:22   ` Krish Sadhukhan
2021-06-07 19:22     ` Krish Sadhukhan
2021-06-07 19:22     ` Krish Sadhukhan
2021-06-07 22:10     ` Jing Zhang
2021-06-07 22:10       ` Jing Zhang
2021-06-07 22:10       ` Jing Zhang
2021-06-10 16:23   ` Paolo Bonzini
2021-06-10 16:23     ` Paolo Bonzini
2021-06-10 16:23     ` Paolo Bonzini
2021-06-10 17:26     ` Jing Zhang
2021-06-10 17:26       ` Jing Zhang
2021-06-10 17:26       ` Jing Zhang
2021-06-10 22:47     ` Jing Zhang
2021-06-10 22:47       ` Jing Zhang
2021-06-10 22:47       ` Jing Zhang
2021-06-11 10:32       ` Paolo Bonzini
2021-06-11 10:32         ` Paolo Bonzini
2021-06-11 10:32         ` Paolo Bonzini
2021-06-10 16:42   ` Paolo Bonzini
2021-06-10 16:42     ` Paolo Bonzini
2021-06-10 16:42     ` Paolo Bonzini
2021-06-10 17:27     ` Jing Zhang
2021-06-10 17:27       ` Jing Zhang
2021-06-10 17:27       ` Jing Zhang
2021-06-13 15:19   ` Fuad Tabba
2021-06-13 15:19     ` Fuad Tabba
2021-06-13 15:19     ` Fuad Tabba
2021-06-13 16:42     ` Jing Zhang
2021-06-13 16:42       ` Jing Zhang
2021-06-13 16:42       ` Jing Zhang
2021-06-03 21:14 ` [PATCH v7 3/4] KVM: stats: Add documentation for statistics data binary interface Jing Zhang
2021-06-03 21:14   ` Jing Zhang
2021-06-03 21:14   ` Jing Zhang
2021-06-07 19:22   ` Krish Sadhukhan
2021-06-07 19:22     ` Krish Sadhukhan
2021-06-07 19:22     ` Krish Sadhukhan
2021-06-07 22:09     ` Jing Zhang
2021-06-07 22:09       ` Jing Zhang
2021-06-07 22:09       ` Jing Zhang
2021-06-14  7:56   ` Fuad Tabba
2021-06-14  7:56     ` Fuad Tabba
2021-06-14  7:56     ` Fuad Tabba
2021-06-14 13:19     ` Jing Zhang
2021-06-14 13:19       ` Jing Zhang
2021-06-14 13:19       ` Jing Zhang
2021-06-03 21:14 ` [PATCH v7 4/4] KVM: selftests: Add selftest for KVM " Jing Zhang
2021-06-03 21:14   ` Jing Zhang
2021-06-03 21:14   ` Jing Zhang
2021-06-07 19:23   ` Krish Sadhukhan
2021-06-07 19:23     ` Krish Sadhukhan
2021-06-07 19:23     ` Krish Sadhukhan
2021-06-07 22:12     ` Jing Zhang
2021-06-07 22:12       ` Jing Zhang
2021-06-07 22:12       ` Jing Zhang
2021-06-10 16:46 ` [PATCH v7 0/4] KVM statistics data fd-based " Paolo Bonzini
2021-06-10 16:46   ` Paolo Bonzini
2021-06-10 16:46   ` Paolo Bonzini
2021-06-10 17:30   ` Jing Zhang
2021-06-10 17:30     ` Jing Zhang
2021-06-10 17:30     ` Jing Zhang
2021-06-11  6:57 ` Christian Borntraeger
2021-06-11  6:57   ` Christian Borntraeger
2021-06-11  6:57   ` Christian Borntraeger
2021-06-11 11:02   ` Paolo Bonzini
2021-06-11 11:02     ` Paolo Bonzini
2021-06-11 11:02     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdd315f7-0615-af69-90c3-1e5646f3e259@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=borntraeger@de.ibm.com \
    --cc=chenhuacai@kernel.org \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dmatlack@google.com \
    --cc=eesposit@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=james.morse@arm.com \
    --cc=jingzhangos@google.com \
    --cc=jmattson@google.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@google.com \
    --cc=paulus@ozlabs.org \
    --cc=pshier@google.com \
    --cc=ricarkol@google.com \
    --cc=rientjes@google.com \
    --cc=seanjc@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=vkuznets@redhat.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.