From: Elliot Berman <quic_eberman@quicinc.com> To: Bjorn Andersson <andersson@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Amol Maheshwari <amahesh@qti.qualcomm.com>, Arnd Bergmann <arnd@arndb.de>, Kalle Valo <kvalo@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, "Gokul krishna Krishnakumar" <quic_gokukris@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-remoteproc@vger.kernel.org> Subject: Re: [PATCH] firmware: qcom_scm: Use fixed width src vm bitmap Date: Tue, 14 Feb 2023 10:52:43 -0800 [thread overview] Message-ID: <bdda82f7-933d-443b-614a-6befad2899b5@quicinc.com> (raw) In-Reply-To: <20230214172325.lplxgbprhj3bzvr3@ripper> On 2/14/2023 9:23 AM, Bjorn Andersson wrote: > On Tue, Feb 14, 2023 at 09:58:44AM +0100, Greg Kroah-Hartman wrote: >> On Mon, Feb 13, 2023 at 01:44:17PM -0800, Bjorn Andersson wrote: >>> On Mon, Feb 13, 2023 at 10:18:29AM -0800, Elliot Berman wrote: >>>> The maximum VMID for assign_mem is 63. Use a u64 to represent this >>>> bitmap instead of architecture-dependent "unsigned int" which varies in >>>> size on 32-bit and 64-bit platforms. >>>> >>>> Acked-by: Kalle Valo <kvalo@kernel.org> (ath10k) >>>> Tested-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com> >>>> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> >>> >>> Reviewed-by: Bjorn Andersson <andersson@kernel.org> >>> >>> @Greg, would you mind taking this through your tree for v6.3, you >>> already have a related change in fastrpc.c in your tree... >> >> I tried, but it doesn't apply to my char-misc tree at all: >> >> checking file drivers/firmware/qcom_scm.c >> Hunk #1 succeeded at 898 (offset -7 lines). >> Hunk #2 succeeded at 915 (offset -7 lines). >> Hunk #3 succeeded at 930 (offset -7 lines). >> checking file drivers/misc/fastrpc.c >> checking file drivers/net/wireless/ath/ath10k/qmi.c >> checking file drivers/remoteproc/qcom_q6v5_mss.c >> Hunk #1 succeeded at 227 (offset -8 lines). >> Hunk #2 succeeded at 404 (offset -10 lines). >> Hunk #3 succeeded at 939 with fuzz 1 (offset -28 lines). >> checking file drivers/remoteproc/qcom_q6v5_pas.c >> Hunk #1 FAILED at 94. >> 1 out of 1 hunk FAILED >> checking file drivers/soc/qcom/rmtfs_mem.c >> Hunk #1 succeeded at 30 (offset -1 lines). >> can't find file to patch at input line 167 >> Perhaps you used the wrong -p or --strip option? >> The text leading up to this was: >> -------------------------- >> |diff --git a/include/linux/firmware/qcom/qcom_scm.h >> b/include/linux/firmware/qcom/qcom_scm.h >> |index 1e449a5d7f5c..250ea4efb7cb 100644 >> |--- a/include/linux/firmware/qcom/qcom_scm.h >> |+++ b/include/linux/firmware/qcom/qcom_scm.h >> -------------------------- >> >> What tree is this patch made against? >> > > Sorry about that, I missed the previous changes in qcom_q6v5_pas in the > remoteproc tree. Elliot said he based it on linux-next, so I expect that > it will merge fine on top of -rc1, once that arrives. > Yes, this patch applies on next-20230213. I guess there are enough changes were coming from QCOM side (via Bjorn's qcom tree) as well as the fastrpc change (via Greg's char-misc tree). Let me know if I should do anything once -rc1 arrives. Happy to post version on the -rc1 if it helps. Thanks, Elliot > Regards, > Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Elliot Berman <quic_eberman@quicinc.com> To: Bjorn Andersson <andersson@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Amol Maheshwari <amahesh@qti.qualcomm.com>, Arnd Bergmann <arnd@arndb.de>, Kalle Valo <kvalo@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, "Gokul krishna Krishnakumar" <quic_gokukris@quicinc.com>, <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-remoteproc@vger.kernel.org> Subject: Re: [PATCH] firmware: qcom_scm: Use fixed width src vm bitmap Date: Tue, 14 Feb 2023 10:52:43 -0800 [thread overview] Message-ID: <bdda82f7-933d-443b-614a-6befad2899b5@quicinc.com> (raw) In-Reply-To: <20230214172325.lplxgbprhj3bzvr3@ripper> On 2/14/2023 9:23 AM, Bjorn Andersson wrote: > On Tue, Feb 14, 2023 at 09:58:44AM +0100, Greg Kroah-Hartman wrote: >> On Mon, Feb 13, 2023 at 01:44:17PM -0800, Bjorn Andersson wrote: >>> On Mon, Feb 13, 2023 at 10:18:29AM -0800, Elliot Berman wrote: >>>> The maximum VMID for assign_mem is 63. Use a u64 to represent this >>>> bitmap instead of architecture-dependent "unsigned int" which varies in >>>> size on 32-bit and 64-bit platforms. >>>> >>>> Acked-by: Kalle Valo <kvalo@kernel.org> (ath10k) >>>> Tested-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com> >>>> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> >>> >>> Reviewed-by: Bjorn Andersson <andersson@kernel.org> >>> >>> @Greg, would you mind taking this through your tree for v6.3, you >>> already have a related change in fastrpc.c in your tree... >> >> I tried, but it doesn't apply to my char-misc tree at all: >> >> checking file drivers/firmware/qcom_scm.c >> Hunk #1 succeeded at 898 (offset -7 lines). >> Hunk #2 succeeded at 915 (offset -7 lines). >> Hunk #3 succeeded at 930 (offset -7 lines). >> checking file drivers/misc/fastrpc.c >> checking file drivers/net/wireless/ath/ath10k/qmi.c >> checking file drivers/remoteproc/qcom_q6v5_mss.c >> Hunk #1 succeeded at 227 (offset -8 lines). >> Hunk #2 succeeded at 404 (offset -10 lines). >> Hunk #3 succeeded at 939 with fuzz 1 (offset -28 lines). >> checking file drivers/remoteproc/qcom_q6v5_pas.c >> Hunk #1 FAILED at 94. >> 1 out of 1 hunk FAILED >> checking file drivers/soc/qcom/rmtfs_mem.c >> Hunk #1 succeeded at 30 (offset -1 lines). >> can't find file to patch at input line 167 >> Perhaps you used the wrong -p or --strip option? >> The text leading up to this was: >> -------------------------- >> |diff --git a/include/linux/firmware/qcom/qcom_scm.h >> b/include/linux/firmware/qcom/qcom_scm.h >> |index 1e449a5d7f5c..250ea4efb7cb 100644 >> |--- a/include/linux/firmware/qcom/qcom_scm.h >> |+++ b/include/linux/firmware/qcom/qcom_scm.h >> -------------------------- >> >> What tree is this patch made against? >> > > Sorry about that, I missed the previous changes in qcom_q6v5_pas in the > remoteproc tree. Elliot said he based it on linux-next, so I expect that > it will merge fine on top of -rc1, once that arrives. > Yes, this patch applies on next-20230213. I guess there are enough changes were coming from QCOM side (via Bjorn's qcom tree) as well as the fastrpc change (via Greg's char-misc tree). Let me know if I should do anything once -rc1 arrives. Happy to post version on the -rc1 if it helps. Thanks, Elliot > Regards, > Bjorn _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2023-02-14 18:53 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-13 18:18 [PATCH] firmware: qcom_scm: Use fixed width src vm bitmap Elliot Berman 2023-02-13 18:18 ` Elliot Berman 2023-02-13 21:44 ` Bjorn Andersson 2023-02-13 21:44 ` Bjorn Andersson 2023-02-14 8:58 ` Greg Kroah-Hartman 2023-02-14 8:58 ` Greg Kroah-Hartman 2023-02-14 17:23 ` Bjorn Andersson 2023-02-14 17:23 ` Bjorn Andersson 2023-02-14 18:52 ` Elliot Berman [this message] 2023-02-14 18:52 ` Elliot Berman 2023-03-03 21:09 ` Elliot Berman 2023-03-03 21:09 ` Elliot Berman 2023-03-15 4:11 ` Bjorn Andersson 2023-03-15 4:11 ` Bjorn Andersson 2023-03-15 4:28 ` Greg Kroah-Hartman 2023-03-15 4:28 ` Greg Kroah-Hartman 2023-03-16 3:21 ` Bjorn Andersson 2023-03-16 3:21 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bdda82f7-933d-443b-614a-6befad2899b5@quicinc.com \ --to=quic_eberman@quicinc.com \ --cc=agross@kernel.org \ --cc=amahesh@qti.qualcomm.com \ --cc=andersson@kernel.org \ --cc=arnd@arndb.de \ --cc=ath10k@lists.infradead.org \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=konrad.dybcio@linaro.org \ --cc=kuba@kernel.org \ --cc=kvalo@kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=quic_gokukris@quicinc.com \ --cc=srinivas.kandagatla@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.