All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port
@ 2022-01-22 15:37 Peter Korsgaard
  2022-01-22 15:37 ` [Buildroot] [PATCH 2/3] configs/qemu_aarch64_virt_defconfig: linux.config: enable fb/input support Peter Korsgaard
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Peter Korsgaard @ 2022-01-22 15:37 UTC (permalink / raw)
  To: buildroot; +Cc: Gerome Burlats, Romain Naour

The Linux defconfig both has VT and serial port support, so it makes more
sense to run getty on /dev/console instead of hard coding the serial port.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 configs/qemu_aarch64_virt_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/qemu_aarch64_virt_defconfig b/configs/qemu_aarch64_virt_defconfig
index e6b72d8838..0caf38112d 100644
--- a/configs/qemu_aarch64_virt_defconfig
+++ b/configs/qemu_aarch64_virt_defconfig
@@ -4,7 +4,6 @@ BR2_cortex_a53=y
 
 # System
 BR2_SYSTEM_DHCP="eth0"
-BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
 
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
-- 
2.20.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/3] configs/qemu_aarch64_virt_defconfig: linux.config: enable fb/input support
  2022-01-22 15:37 [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port Peter Korsgaard
@ 2022-01-22 15:37 ` Peter Korsgaard
  2022-01-22 15:37 ` [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16 Peter Korsgaard
  2022-01-22 19:10 ` [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port Yann E. MORIN
  2 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2022-01-22 15:37 UTC (permalink / raw)
  To: buildroot; +Cc: Gerome Burlats, Romain Naour

The Linux config already enabled drm-virtio for graphics output, but not the
corresponding virtio-input / evdev drivers for input or the compatibility fb
option.

Enable them so keyboard/mouse input works and /dev/fb0 is provided.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 board/qemu/aarch64-virt/linux.config | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/board/qemu/aarch64-virt/linux.config b/board/qemu/aarch64-virt/linux.config
index e3a4a92913..f9763b73b7 100644
--- a/board/qemu/aarch64-virt/linux.config
+++ b/board/qemu/aarch64-virt/linux.config
@@ -47,6 +47,7 @@ CONFIG_DUMMY=y
 CONFIG_MACVLAN=y
 CONFIG_VIRTIO_NET=y
 CONFIG_NLMON=y
+CONFIG_INPUT_EVDEV=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
 CONFIG_VIRTIO_CONSOLE=y
@@ -56,9 +57,11 @@ CONFIG_TCG_TPM=y
 CONFIG_TCG_TIS=y
 CONFIG_DRM=y
 CONFIG_DRM_VIRTIO_GPU=y
+CONFIG_FB=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_PL031=y
 CONFIG_VIRTIO_PCI=y
+CONFIG_VIRTIO_INPUT=y
 CONFIG_VIRTIO_MMIO=y
 CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES=y
 CONFIG_MAILBOX=y
-- 
2.20.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16
  2022-01-22 15:37 [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port Peter Korsgaard
  2022-01-22 15:37 ` [Buildroot] [PATCH 2/3] configs/qemu_aarch64_virt_defconfig: linux.config: enable fb/input support Peter Korsgaard
@ 2022-01-22 15:37 ` Peter Korsgaard
  2022-01-23 10:56   ` Romain Naour
  2022-01-22 19:10 ` [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port Yann E. MORIN
  2 siblings, 1 reply; 7+ messages in thread
From: Peter Korsgaard @ 2022-01-22 15:37 UTC (permalink / raw)
  To: buildroot; +Cc: Gerome Burlats, Romain Naour

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 configs/qemu_aarch64_virt_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/qemu_aarch64_virt_defconfig b/configs/qemu_aarch64_virt_defconfig
index 0caf38112d..9fbf293311 100644
--- a/configs/qemu_aarch64_virt_defconfig
+++ b/configs/qemu_aarch64_virt_defconfig
@@ -20,7 +20,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.16"
 BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
 BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config"
 BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
-- 
2.20.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port
  2022-01-22 15:37 [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port Peter Korsgaard
  2022-01-22 15:37 ` [Buildroot] [PATCH 2/3] configs/qemu_aarch64_virt_defconfig: linux.config: enable fb/input support Peter Korsgaard
  2022-01-22 15:37 ` [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16 Peter Korsgaard
@ 2022-01-22 19:10 ` Yann E. MORIN
  2 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2022-01-22 19:10 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: Gerome Burlats, Romain Naour, buildroot

Peter, All,

On 2022-01-22 16:37 +0100, Peter Korsgaard spake thusly:
> The Linux defconfig both has VT and serial port support, so it makes more
> sense to run getty on /dev/console instead of hard coding the serial port.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Series of 3 patches applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  configs/qemu_aarch64_virt_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configs/qemu_aarch64_virt_defconfig b/configs/qemu_aarch64_virt_defconfig
> index e6b72d8838..0caf38112d 100644
> --- a/configs/qemu_aarch64_virt_defconfig
> +++ b/configs/qemu_aarch64_virt_defconfig
> @@ -4,7 +4,6 @@ BR2_cortex_a53=y
>  
>  # System
>  BR2_SYSTEM_DHCP="eth0"
> -BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
>  
>  # Filesystem
>  BR2_TARGET_ROOTFS_EXT2=y
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16
  2022-01-22 15:37 ` [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16 Peter Korsgaard
@ 2022-01-23 10:56   ` Romain Naour
  2022-01-23 14:48     ` Peter Korsgaard
  0 siblings, 1 reply; 7+ messages in thread
From: Romain Naour @ 2022-01-23 10:56 UTC (permalink / raw)
  To: Peter Korsgaard, buildroot; +Cc: Gerome Burlats

Hello Peter, All

Le 22/01/2022 à 16:37, Peter Korsgaard a écrit :
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  configs/qemu_aarch64_virt_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/qemu_aarch64_virt_defconfig b/configs/qemu_aarch64_virt_defconfig
> index 0caf38112d..9fbf293311 100644
> --- a/configs/qemu_aarch64_virt_defconfig
> +++ b/configs/qemu_aarch64_virt_defconfig
> @@ -20,7 +20,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
>  # Kernel
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15"
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.16"

Why just only taking care of this defconfig ?
Most qemu defconfig are using the same kernel version (5.15). Usually we try to
keep all of them in sync.

Since Qemu defconfigs are runtime tested each week in GitLab-CI maybe we can
safely switch to BR2_LINUX_KERNEL_LATEST_VERSION instead ?
But we have to check qemu defconfigs using a local kernel patch, currently
ppc-mpc8544ds and arm-versatile or keeping kernel custom version for them.

Also BR2_LINUX_KERNEL_LATEST_VERSION refer to the latest stable kernel version,
not the latest lts version.

Thoughts?

Best regards,
Romain


>  BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
>  BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config"
>  BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16
  2022-01-23 10:56   ` Romain Naour
@ 2022-01-23 14:48     ` Peter Korsgaard
  2022-01-23 15:48       ` Romain Naour
  0 siblings, 1 reply; 7+ messages in thread
From: Peter Korsgaard @ 2022-01-23 14:48 UTC (permalink / raw)
  To: Romain Naour, buildroot; +Cc: Gerome Burlats

On 23/01/2022 11.56, Romain Naour wrote:

>> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15"
>> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.16"
> 
> Why just only taking care of this defconfig ?

Simply because I did some other changes to it (see the other patches in 
the series).

> Most qemu defconfig are using the same kernel version (5.15). Usually we try to
> keep all of them in sync.

Ok.

> Since Qemu defconfigs are runtime tested each week in GitLab-CI maybe we can
> safely switch to BR2_LINUX_KERNEL_LATEST_VERSION instead ?
> But we have to check qemu defconfigs using a local kernel patch, currently
> ppc-mpc8544ds and arm-versatile or keeping kernel custom version for them.
> 
> Also BR2_LINUX_KERNEL_LATEST_VERSION refer to the latest stable kernel version,
> not the latest lts version.

That would mean that they are not really reproducible, so I don't really 
like it.

--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16
  2022-01-23 14:48     ` Peter Korsgaard
@ 2022-01-23 15:48       ` Romain Naour
  0 siblings, 0 replies; 7+ messages in thread
From: Romain Naour @ 2022-01-23 15:48 UTC (permalink / raw)
  To: Peter Korsgaard, buildroot; +Cc: Gerome Burlats

Hello Peter,

Le 23/01/2022 à 15:48, Peter Korsgaard a écrit :
> On 23/01/2022 11.56, Romain Naour wrote:
> 
>>> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15"
>>> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.16"
>>
>> Why just only taking care of this defconfig ?
> 
> Simply because I did some other changes to it (see the other patches in the
> series).
> 
>> Most qemu defconfig are using the same kernel version (5.15). Usually we try to
>> keep all of them in sync.
> 
> Ok.

To test all qemu defconfig in gitlab you can push a branch named
"kernel-5.15.16-defconfigs-qemu"

Where: "kernel-5.15.16" is a prefix, "-defconfigs-" trigger a pipeline for
testing Buildroot defconfis and "qemu" is a pattern to match all defconfig named
qemu*.

See:
https://gitlab.com/buildroot.org/buildroot/-/commit/65d2f04c012af492a9b9da04dfa3b3cbd20347f1

The kernel 5.15 is not as old, do we want to follow closely the latest kernel
version for Qemu defconfigs? But it's annoying to modify each time the kernel
version in several place.

> 
>> Since Qemu defconfigs are runtime tested each week in GitLab-CI maybe we can
>> safely switch to BR2_LINUX_KERNEL_LATEST_VERSION instead ?
>> But we have to check qemu defconfigs using a local kernel patch, currently
>> ppc-mpc8544ds and arm-versatile or keeping kernel custom version for them.
>>
>> Also BR2_LINUX_KERNEL_LATEST_VERSION refer to the latest stable kernel version,
>> not the latest lts version.
> 
> That would mean that they are not really reproducible, so I don't really like it.

For a given Buildroot version BR2_LINUX_KERNEL_LATEST_VERSION is set with a
default kernel version.

Actually defconfigs are already not reproducible since the internal toolchain
components version use the default version.
But indeed, the kernel version change faster than the toolchain.

Best regards,
Romain


> 
> -- 
> Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-01-23 15:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22 15:37 [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port Peter Korsgaard
2022-01-22 15:37 ` [Buildroot] [PATCH 2/3] configs/qemu_aarch64_virt_defconfig: linux.config: enable fb/input support Peter Korsgaard
2022-01-22 15:37 ` [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16 Peter Korsgaard
2022-01-23 10:56   ` Romain Naour
2022-01-23 14:48     ` Peter Korsgaard
2022-01-23 15:48       ` Romain Naour
2022-01-22 19:10 ` [Buildroot] [PATCH 1/3] configs/qemu_aarch64_virt_defconfig: don't hard code getty port Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.