Re: [PATCH v2] kernel.fitimage.bbclass: remove ramdisk_ctype

Re: [PATCH v2] kernel.fitimage.bbclass: remove ramdisk_ctype

[Heiko Schocher]

Hello all,

Am 20.09.2019 um 06:21 schrieb Heiko Schocher:
> set in the ramdisk node the compression property
> always to "none", as U-Boot nowadays since commit:
> 
> b1307f884a91 ("fit: Support compression for non-kernel components (e.g. FDT)")
> 
> decompress non kernel components. Setting compression
> to the used comression algorithm now, will end in
> fail of your kernel boot with the ramdisk.
> 
> This issue is fixed since commit:
> 
> bddd98573465 ("fit: Do not automatically decompress ramdisk images")
> 
> which now prints a warning in U-Boot, instead of decompressing
> the ramdisk, but we should setup compression property correct.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> 
> Changes in v2:
> - resend patch to  openembedded-core@lists.openembedded.org instead
>    to Yocto Project <yocto@yoctoproject.org> as Ross suggested. No
>    changes in code.

gentle ping. Any comments?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

Re: [PATCH v2] kernel.fitimage.bbclass: remove ramdisk_ctype

[Heiko Schocher]

Hello all,

Am 07.10.2019 um 15:42 schrieb Heiko Schocher:
> Hello all,
> 
> Am 20.09.2019 um 06:21 schrieb Heiko Schocher:
>> set in the ramdisk node the compression property
>> always to "none", as U-Boot nowadays since commit:
>>
>> b1307f884a91 ("fit: Support compression for non-kernel components (e.g. FDT)")
>>
>> decompress non kernel components. Setting compression
>> to the used comression algorithm now, will end in
>> fail of your kernel boot with the ramdisk.
>>
>> This issue is fixed since commit:
>>
>> bddd98573465 ("fit: Do not automatically decompress ramdisk images")
>>
>> which now prints a warning in U-Boot, instead of decompressing
>> the ramdisk, but we should setup compression property correct.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>>
>> Changes in v2:
>> - resend patch to  openembedded-core@lists.openembedded.org instead
>>    to Yocto Project <yocto@yoctoproject.org> as Ross suggested. No
>>    changes in code.
> 
> gentle ping. Any comments?

gentle ping ...

bye,
Heiko

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

Re: [PATCH v2] kernel.fitimage.bbclass: remove ramdisk_ctype

[Richard Purdie]

On Mon, 2019-11-18 at 09:51 +0100, Heiko Schocher wrote:
> Hello all,
> 
> Am 07.10.2019 um 15:42 schrieb Heiko Schocher:
> > Hello all,
> > 
> > Am 20.09.2019 um 06:21 schrieb Heiko Schocher:
> > > set in the ramdisk node the compression property
> > > always to "none", as U-Boot nowadays since commit:
> > > 
> > > b1307f884a91 ("fit: Support compression for non-kernel components
> > > (e.g. FDT)")
> > > 
> > > decompress non kernel components. Setting compression
> > > to the used comression algorithm now, will end in
> > > fail of your kernel boot with the ramdisk.
> > > 
> > > This issue is fixed since commit:
> > > 
> > > bddd98573465 ("fit: Do not automatically decompress ramdisk
> > > images")
> > > 
> > > which now prints a warning in U-Boot, instead of decompressing
> > > the ramdisk, but we should setup compression property correct.
> > > 
> > > Signed-off-by: Heiko Schocher <hs@denx.de>
> > > ---
> > > 
> > > Changes in v2:
> > > - resend patch to  openembedded-core@lists.openembedded.org
> > > instead
> > >    to Yocto Project <yocto@yoctoproject.org> as Ross suggested.
> > > No
> > >    changes in code.
> > 
> > gentle ping. Any comments?
> 
> gentle ping ...

It merged 7 days after you sent it back in September:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=2c58079222310443f08df51e9fd6ce234e7e0019

Cheers,

Richard

[PATCH v2] kernel.fitimage.bbclass: remove ramdisk_ctype

[Heiko Schocher]

set in the ramdisk node the compression property
always to "none", as U-Boot nowadays since commit:

b1307f884a91 ("fit: Support compression for non-kernel components (e.g. FDT)")

decompress non kernel components. Setting compression
to the used comression algorithm now, will end in
fail of your kernel boot with the ramdisk.

This issue is fixed since commit:

bddd98573465 ("fit: Do not automatically decompress ramdisk images")

which now prints a warning in U-Boot, instead of decompressing
the ramdisk, but we should setup compression property correct.

Signed-off-by: Heiko Schocher <hs@denx.de>
---

Changes in v2:
- resend patch to  openembedded-core@lists.openembedded.org instead
  to Yocto Project <yocto@yoctoproject.org> as Ross suggested. No
  changes in code.

 meta/classes/kernel-fitimage.bbclass | 21 +--------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
index b51882dce4..1bcb09c598 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -207,7 +207,6 @@ EOF
 fitimage_emit_section_ramdisk() {
 
 	ramdisk_csum="${FIT_HASH_ALG}"
-	ramdisk_ctype="none"
 	ramdisk_loadline=""
 	ramdisk_entryline=""
 
@@ -218,24 +217,6 @@ fitimage_emit_section_ramdisk() {
 		ramdisk_entryline="entry = <${UBOOT_RD_ENTRYPOINT}>;"
 	fi
 
-	case $3 in
-		*.gz)
-			ramdisk_ctype="gzip"
-			;;
-		*.bz2)
-			ramdisk_ctype="bzip2"
-			;;
-		*.lzma)
-			ramdisk_ctype="lzma"
-			;;
-		*.lzo)
-			ramdisk_ctype="lzo"
-			;;
-		*.lz4)
-			ramdisk_ctype="lz4"
-			;;
-	esac
-
 	cat << EOF >> ${1}
                 ramdisk@${2} {
                         description = "${INITRAMFS_IMAGE}";
@@ -243,7 +224,7 @@ fitimage_emit_section_ramdisk() {
                         type = "ramdisk";
                         arch = "${UBOOT_ARCH}";
                         os = "linux";
-                        compression = "${ramdisk_ctype}";
+                        compression = "none";
                         ${ramdisk_loadline}
                         ${ramdisk_entryline}
                         hash@1 {
-- 
2.21.0