* Fwd: [PATCH v8 0/4] wifi: ath12k: ACPI support
@ 2024-04-19 6:30 Lingbo Kong
2024-04-19 9:39 ` Lingbo Kong
0 siblings, 1 reply; 8+ messages in thread
From: Lingbo Kong @ 2024-04-19 6:30 UTC (permalink / raw)
To: Jeff Johnson, Kalle Valo; +Cc: ath12k, linux-wireless
> -------- Forwarded Message --------
> Subject: Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
> Date: Fri, 19 Apr 2024 07:16:07 +0300
> From: Kalle Valo <kvalo@kernel.org>
> To: Jeff Johnson <quic_jjohnson@quicinc.com>
> CC: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org
>
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>
> > On 4/18/2024 9:20 AM, Kalle Valo wrote:
> >
> >> From: Kalle Valo <quic_kvalo@quicinc.com>
> >>
> >> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS
> >> SAR, configuration of CCA threshold and band edge channel power
> functionalities.
> >> This is enabled only on WCN7850.
> >>
> >> TODO:
> >>
> >> * test with ACPI support in hardware (I don't have such hardware),
> especially
> >> suspend and hibernation
>
> [...]
>
> > I can verify this doesn't crash my system, but apparently my ACPI
> > doesn't have the underlying settings, so cannot verify actual
> > functionality
>
> Thanks for testing. I hope Lingbo has a device with proper ACPI settings.
>
yes, I'll apply these patch then test it.
> > Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0:
> > acpi_evaluate_dsm() failed Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel:
> > ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2 Apr 18
> > 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi
> > failed: -2
>
> I just want to verify that these are debug messages, right? Normal users
> shouldn't see any ACPI errors if there are no ACPI settings in the
system.
>
Let me check it.
Best regards
Lingbo Kong
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
>
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat
> ches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
2024-04-19 6:30 Fwd: [PATCH v8 0/4] wifi: ath12k: ACPI support Lingbo Kong
@ 2024-04-19 9:39 ` Lingbo Kong
2024-04-22 7:16 ` Kalle Valo
0 siblings, 1 reply; 8+ messages in thread
From: Lingbo Kong @ 2024-04-19 9:39 UTC (permalink / raw)
To: ath12k, Kalle Valo, Jeff Johnson; +Cc: linux-wireless
On 2024/4/19 14:30, Lingbo Kong wrote:
> > -------- Forwarded Message --------
> > Subject: Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
> > Date: Fri, 19 Apr 2024 07:16:07 +0300
> > From: Kalle Valo <kvalo@kernel.org>
> > To: Jeff Johnson <quic_jjohnson@quicinc.com>
> > CC: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org
> >
> > Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> >
> > > On 4/18/2024 9:20 AM, Kalle Valo wrote:
> > >
> > >> From: Kalle Valo <quic_kvalo@quicinc.com>
> > >>
> > >> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS
> > >> SAR, configuration of CCA threshold and band edge channel power
> > functionalities.
> > >> This is enabled only on WCN7850.
> > >>
> > >> TODO:
> > >>
> > >> * test with ACPI support in hardware (I don't have such hardware),
> > especially
> > >> suspend and hibernation
> >
> > [...]
> >
> > > I can verify this doesn't crash my system, but apparently my ACPI
> > > doesn't have the underlying settings, so cannot verify actual
> > > functionality
> >
> > Thanks for testing. I hope Lingbo has a device with proper ACPI
> settings.
> >
>
> yes, I'll apply these patch then test it.
>
Hi, kalle, i've applied this patchset, set ACPI correctly, then ACPI's
functionality is right.
> > > Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0:
> > > acpi_evaluate_dsm() failed Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel:
> > > ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2 Apr 18
> > > 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi
> > > failed: -2
> >
> > I just want to verify that these are debug messages, right? Normal users
> > shouldn't see any ACPI errors if there are no ACPI settings in the
> system.
> >
>
> Let me check it.
>
> Best regards
> Lingbo Kong
>
These messages belong to debug messages, normal users won't see any ACPI
errors if there are no ACPI settings in the system.
> > --
> > https://patchwork.kernel.org/project/linux-wireless/list/
> >
> >
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat
> > ches
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
2024-04-19 9:39 ` Lingbo Kong
@ 2024-04-22 7:16 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2024-04-22 7:16 UTC (permalink / raw)
To: Lingbo Kong; +Cc: ath12k, Jeff Johnson, linux-wireless
Lingbo Kong <quic_lingbok@quicinc.com> writes:
> On 2024/4/19 14:30, Lingbo Kong wrote:
>> > -------- Forwarded Message --------
>> > Subject: Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
>> > Date: Fri, 19 Apr 2024 07:16:07 +0300
>> > From: Kalle Valo <kvalo@kernel.org>
>> > To: Jeff Johnson <quic_jjohnson@quicinc.com>
>> > CC: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org
>> >
>> > Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>> >
>> > > On 4/18/2024 9:20 AM, Kalle Valo wrote:
>> > >
>> > >> From: Kalle Valo <quic_kvalo@quicinc.com>
>> > >>
>> > >> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS
>> > >> SAR, configuration of CCA threshold and band edge channel power
>> > functionalities.
>> > >> This is enabled only on WCN7850.
>> > >>
>> > >> TODO:
>> > >>
>> > >> * test with ACPI support in hardware (I don't have such hardware),
>> > especially
>> > >> suspend and hibernation
>> >
>> > [...]
>> >
>> > > I can verify this doesn't crash my system, but apparently my ACPI
>> > > doesn't have the underlying settings, so cannot verify actual
>> > > functionality
>> >
>> > Thanks for testing. I hope Lingbo has a device with proper ACPI
>> settings.
>> >
>> yes, I'll apply these patch then test it.
>>
>
> Hi, kalle, i've applied this patchset, set ACPI correctly, then ACPI's
> functionality is right.
Nice, thanks for testing.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
2024-04-19 14:51 ` Jeff Johnson
@ 2024-04-19 14:57 ` Lingbo Kong
0 siblings, 0 replies; 8+ messages in thread
From: Lingbo Kong @ 2024-04-19 14:57 UTC (permalink / raw)
To: Jeff Johnson, Kalle Valo; +Cc: ath12k, linux-wireless
On 2024/4/19 22:51, Jeff Johnson wrote:
> On 4/18/2024 9:16 PM, Kalle Valo wrote:
>> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>>> I can verify this doesn't crash my system, but apparently my ACPI doesn't have
>>> the underlying settings, so cannot verify actual functionality
>>
>> Thanks for testing. I hope Lingbo has a device with proper ACPI settings.
>>
>>> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi_evaluate_dsm() failed
>>> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2
>>> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi failed: -2
>>
>> I just want to verify that these are debug messages, right? Normal users
>> shouldn't see any ACPI errors if there are no ACPI settings in the system.
>
> Yes, those were debug messages (I've added ath12k.debug_mask=0xffffeffa to my
> boot command)
>
> Also note my Qualcomm Innovation Center copyright checker reports that the two
> new files are missing 2024 copyright, so please update
>
> /jeff
>
thx jeff, i'll update the copyright.
best regards
Lingbo Kong
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
2024-04-19 4:16 ` Kalle Valo
@ 2024-04-19 14:51 ` Jeff Johnson
2024-04-19 14:57 ` Lingbo Kong
0 siblings, 1 reply; 8+ messages in thread
From: Jeff Johnson @ 2024-04-19 14:51 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath12k, linux-wireless
On 4/18/2024 9:16 PM, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>> I can verify this doesn't crash my system, but apparently my ACPI doesn't have
>> the underlying settings, so cannot verify actual functionality
>
> Thanks for testing. I hope Lingbo has a device with proper ACPI settings.
>
>> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi_evaluate_dsm() failed
>> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2
>> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi failed: -2
>
> I just want to verify that these are debug messages, right? Normal users
> shouldn't see any ACPI errors if there are no ACPI settings in the system.
Yes, those were debug messages (I've added ath12k.debug_mask=0xffffeffa to my
boot command)
Also note my Qualcomm Innovation Center copyright checker reports that the two
new files are missing 2024 copyright, so please update
/jeff
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
2024-04-18 22:23 ` Jeff Johnson
@ 2024-04-19 4:16 ` Kalle Valo
2024-04-19 14:51 ` Jeff Johnson
0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2024-04-19 4:16 UTC (permalink / raw)
To: Jeff Johnson; +Cc: ath12k, linux-wireless
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 4/18/2024 9:20 AM, Kalle Valo wrote:
>
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS SAR,
>> configuration of CCA threshold and band edge channel power functionalities.
>> This is enabled only on WCN7850.
>>
>> TODO:
>>
>> * test with ACPI support in hardware (I don't have such hardware), especially
>> suspend and hibernation
[...]
> I can verify this doesn't crash my system, but apparently my ACPI doesn't have
> the underlying settings, so cannot verify actual functionality
Thanks for testing. I hope Lingbo has a device with proper ACPI settings.
> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi_evaluate_dsm() failed
> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2
> Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi failed: -2
I just want to verify that these are debug messages, right? Normal users
shouldn't see any ACPI errors if there are no ACPI settings in the system.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
2024-04-18 16:20 Kalle Valo
@ 2024-04-18 22:23 ` Jeff Johnson
2024-04-19 4:16 ` Kalle Valo
0 siblings, 1 reply; 8+ messages in thread
From: Jeff Johnson @ 2024-04-18 22:23 UTC (permalink / raw)
To: Kalle Valo, ath12k; +Cc: linux-wireless
On 4/18/2024 9:20 AM, Kalle Valo wrote:
> From: Kalle Valo <quic_kvalo@quicinc.com>
>
> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS SAR,
> configuration of CCA threshold and band edge channel power functionalities.
> This is enabled only on WCN7850.
>
> TODO:
>
> * test with ACPI support in hardware (I don't have such hardware), especially
> suspend and hibernation
>
> v8:
>
> * rebase to ath-202404181528
> * rewrite commit messages
> * cleanup and improvements all over to match the ath12k style, including
> error handling, naming and so on
> * locate new place to call ath12k_acpi_[start|stop]()
> * move wmi functions up in wmi.c file
> * consolidate WMI functions using WMI_PDEV_SET_BIOS_INTERFACE_CMDID into ath12k_wmi_set_bios_cmd()
> * ath12k_acpi_stop(): don't call acpi_remove_notify_handler() if we never installed the handler
>
> v7: https://patchwork.kernel.org/project/linux-wireless/cover/20231013114434.81648-1-quic_lingbok@quicinc.com/
>
> * adjust the length of line
> * add cpu_to_le32()
>
> v6:
>
> * remove code that is not called
>
> v5:
>
> * rebase to the latest tag
>
> v4:
>
> * revise commit log using imperative voice
> * delete guid_is_null()
>
> v3:
>
> * remove unnecessary cpu_to_le32()
> * adjust the order of the macros
> * apply jeff's advice
>
> v2:
>
> * put <linux/acpi.h> in the include guard
>
> Lingbo Kong (4):
> wifi: ath12k: ACPI TAS support
> wifi: ath12k: ACPI SAR support
> wifi: ath12k: ACPI CCA threshold support
> wifi: ath12k: ACPI band edge channel power support
>
> drivers/net/wireless/ath/ath12k/Makefile | 1 +
> drivers/net/wireless/ath/ath12k/acpi.c | 394 +++++++++++++++++++++++
> drivers/net/wireless/ath/ath12k/acpi.h | 76 +++++
> drivers/net/wireless/ath/ath12k/core.c | 7 +
> drivers/net/wireless/ath/ath12k/core.h | 18 ++
> drivers/net/wireless/ath/ath12k/hw.c | 10 +
> drivers/net/wireless/ath/ath12k/hw.h | 3 +
> drivers/net/wireless/ath/ath12k/wmi.c | 143 ++++++++
> drivers/net/wireless/ath/ath12k/wmi.h | 41 +++
> 9 files changed, 693 insertions(+)
> create mode 100644 drivers/net/wireless/ath/ath12k/acpi.c
> create mode 100644 drivers/net/wireless/ath/ath12k/acpi.h
>
>
> base-commit: c416602943dd36fbd13af7496430723935c867a3
I can verify this doesn't crash my system, but apparently my ACPI doesn't have
the underlying settings, so cannot verify actual functionality
Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi_evaluate_dsm() failed
Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2
Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi failed: -2
/jeff
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v8 0/4] wifi: ath12k: ACPI support
@ 2024-04-18 16:20 Kalle Valo
2024-04-18 22:23 ` Jeff Johnson
0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2024-04-18 16:20 UTC (permalink / raw)
To: ath12k; +Cc: linux-wireless
From: Kalle Valo <quic_kvalo@quicinc.com>
Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS SAR,
configuration of CCA threshold and band edge channel power functionalities.
This is enabled only on WCN7850.
TODO:
* test with ACPI support in hardware (I don't have such hardware), especially
suspend and hibernation
v8:
* rebase to ath-202404181528
* rewrite commit messages
* cleanup and improvements all over to match the ath12k style, including
error handling, naming and so on
* locate new place to call ath12k_acpi_[start|stop]()
* move wmi functions up in wmi.c file
* consolidate WMI functions using WMI_PDEV_SET_BIOS_INTERFACE_CMDID into ath12k_wmi_set_bios_cmd()
* ath12k_acpi_stop(): don't call acpi_remove_notify_handler() if we never installed the handler
v7: https://patchwork.kernel.org/project/linux-wireless/cover/20231013114434.81648-1-quic_lingbok@quicinc.com/
* adjust the length of line
* add cpu_to_le32()
v6:
* remove code that is not called
v5:
* rebase to the latest tag
v4:
* revise commit log using imperative voice
* delete guid_is_null()
v3:
* remove unnecessary cpu_to_le32()
* adjust the order of the macros
* apply jeff's advice
v2:
* put <linux/acpi.h> in the include guard
Lingbo Kong (4):
wifi: ath12k: ACPI TAS support
wifi: ath12k: ACPI SAR support
wifi: ath12k: ACPI CCA threshold support
wifi: ath12k: ACPI band edge channel power support
drivers/net/wireless/ath/ath12k/Makefile | 1 +
drivers/net/wireless/ath/ath12k/acpi.c | 394 +++++++++++++++++++++++
drivers/net/wireless/ath/ath12k/acpi.h | 76 +++++
drivers/net/wireless/ath/ath12k/core.c | 7 +
drivers/net/wireless/ath/ath12k/core.h | 18 ++
drivers/net/wireless/ath/ath12k/hw.c | 10 +
drivers/net/wireless/ath/ath12k/hw.h | 3 +
drivers/net/wireless/ath/ath12k/wmi.c | 143 ++++++++
drivers/net/wireless/ath/ath12k/wmi.h | 41 +++
9 files changed, 693 insertions(+)
create mode 100644 drivers/net/wireless/ath/ath12k/acpi.c
create mode 100644 drivers/net/wireless/ath/ath12k/acpi.h
base-commit: c416602943dd36fbd13af7496430723935c867a3
--
2.39.2
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-04-22 7:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-19 6:30 Fwd: [PATCH v8 0/4] wifi: ath12k: ACPI support Lingbo Kong
2024-04-19 9:39 ` Lingbo Kong
2024-04-22 7:16 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2024-04-18 16:20 Kalle Valo
2024-04-18 22:23 ` Jeff Johnson
2024-04-19 4:16 ` Kalle Valo
2024-04-19 14:51 ` Jeff Johnson
2024-04-19 14:57 ` Lingbo Kong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.