From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: Alexander Duyck <alexander.duyck@gmail.com>, Stephen Hemminger <stephen@networkplumber.org>, David Miller <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, "Brandeburg, Jesse" <jesse.brandeburg@intel.com>, "Duyck, Alexander H" <alexander.h.duyck@intel.com>, Jakub Kicinski <kubakici@wp.pl>, achiad shochat <achiad.mellanox@gmail.com>, Achiad Shochat <achiad@mellanox.com> Subject: Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Date: Mon, 22 Jan 2018 17:34:37 -0800 [thread overview] Message-ID: <be3864b4-f108-6a7d-8628-204d4d4ae278@intel.com> (raw) In-Reply-To: <20180123020332-mutt-send-email-mst@kernel.org> On 1/22/2018 4:05 PM, Michael S. Tsirkin wrote: > On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote: >>>> You could probably >>>> even handle the Tx queue selection via a simple eBPF program and map >>>> since the input for whatever is used to select Tx should be pretty >>>> simple, destination MAC, source NUMA node, etc, and the data-set >>>> shouldn't be too large. >>> That sounds interesting. A separate device might make this kind of setup >>> a bit easier. Sridhar, did you look into creating a separate device for >>> the virtual bond device at all? It does not have to be in a separate >>> module, that kind of refactoring can come later, but once we commit to >>> using the same single device as virtio, we can't change that. >> No. I haven't looked into creating a separate device. If we are going to >> create a new >> device, i guess it has to be of a new device type with its own driver. > Well not necessarily - just a separate netdev ops. > Kind of like e.g. vlans share a driver with the main driver. Not sure what you meant by vlans sharing a driver with the main driver. IIUC, vlans are supported via 802.1q driver and creates a netdev of type 'vlan' with vlan_netdev_ops > >> As we are using virtio_net to control and manage the VF data path, it is not >> clear to me >> what is the advantage of creating a new device rather than extending >> virtio_net to manage >> the VF datapath via transparent bond mechanism. >> >> Thanks >> Sridhar > So that XDP redirect actions can differentiate between virtio, PT > device and the bond. Without it there's no way to redirect > to virtio specifically. I guess this usecase is for a guest admin to add bpf programs to VF netdev and redirect frames to virtio. How does bond enable this feature? Thanks Sridhar
WARNING: multiple messages have this Message-ID (diff)
From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: Alexander Duyck <alexander.duyck@gmail.com>, Stephen Hemminger <stephen@networkplumber.org>, David Miller <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, "Brandeburg, Jesse" <jesse.brandeburg@intel.com>, "Duyck, Alexander H" <alexander.h.duyck@intel.com>, Jakub Kicinski <kubakici@wp.pl>, achiad shochat <achiad.mellanox@gmail.com>, Achiad Shochat <achiad@mellanox.com> Subject: Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Date: Mon, 22 Jan 2018 17:34:37 -0800 [thread overview] Message-ID: <be3864b4-f108-6a7d-8628-204d4d4ae278@intel.com> (raw) In-Reply-To: <20180123020332-mutt-send-email-mst@kernel.org> On 1/22/2018 4:05 PM, Michael S. Tsirkin wrote: > On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote: >>>> You could probably >>>> even handle the Tx queue selection via a simple eBPF program and map >>>> since the input for whatever is used to select Tx should be pretty >>>> simple, destination MAC, source NUMA node, etc, and the data-set >>>> shouldn't be too large. >>> That sounds interesting. A separate device might make this kind of setup >>> a bit easier. Sridhar, did you look into creating a separate device for >>> the virtual bond device at all? It does not have to be in a separate >>> module, that kind of refactoring can come later, but once we commit to >>> using the same single device as virtio, we can't change that. >> No. I haven't looked into creating a separate device. If we are going to >> create a new >> device, i guess it has to be of a new device type with its own driver. > Well not necessarily - just a separate netdev ops. > Kind of like e.g. vlans share a driver with the main driver. Not sure what you meant by vlans sharing a driver with the main driver. IIUC, vlans are supported via 802.1q driver and creates a netdev of type 'vlan' with vlan_netdev_ops > >> As we are using virtio_net to control and manage the VF data path, it is not >> clear to me >> what is the advantage of creating a new device rather than extending >> virtio_net to manage >> the VF datapath via transparent bond mechanism. >> >> Thanks >> Sridhar > So that XDP redirect actions can differentiate between virtio, PT > device and the bond. Without it there's no way to redirect > to virtio specifically. I guess this usecase is for a guest admin to add bpf programs to VF netdev and redirect frames to virtio. How does bond enable this feature? Thanks Sridhar --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-01-23 1:34 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-12 5:58 [RFC PATCH net-next v2 0/2] Enable virtio to act as a backup for a passthru device Sridhar Samudrala 2018-01-12 5:58 ` [virtio-dev] " Sridhar Samudrala 2018-01-12 5:58 ` [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Sridhar Samudrala 2018-01-12 5:58 ` [virtio-dev] " Sridhar Samudrala 2018-01-17 18:15 ` Alexander Duyck 2018-01-17 18:15 ` [virtio-dev] " Alexander Duyck 2018-01-17 19:02 ` Michael S. Tsirkin 2018-01-17 19:02 ` Michael S. Tsirkin 2018-01-17 19:02 ` Michael S. Tsirkin 2018-01-17 19:25 ` Samudrala, Sridhar 2018-01-17 19:25 ` Samudrala, Sridhar 2018-01-17 19:25 ` [virtio-dev] " Samudrala, Sridhar 2018-01-17 19:57 ` Michael S. Tsirkin 2018-01-17 19:57 ` Michael S. Tsirkin 2018-01-17 19:57 ` Michael S. Tsirkin 2018-01-17 21:49 ` Alexander Duyck 2018-01-17 21:49 ` [virtio-dev] " Alexander Duyck 2018-01-22 21:31 ` Michael S. Tsirkin 2018-01-22 21:31 ` Michael S. Tsirkin 2018-01-22 23:27 ` Samudrala, Sridhar 2018-01-22 23:27 ` Samudrala, Sridhar 2018-01-23 0:02 ` Stephen Hemminger 2018-01-23 0:02 ` Stephen Hemminger 2018-01-23 1:37 ` Samudrala, Sridhar 2018-01-23 1:37 ` Samudrala, Sridhar 2018-01-23 1:37 ` Samudrala, Sridhar 2018-01-23 0:05 ` Michael S. Tsirkin 2018-01-23 0:05 ` Michael S. Tsirkin 2018-01-23 0:16 ` Jakub Kicinski 2018-01-23 0:47 ` Michael S. Tsirkin 2018-01-23 0:47 ` Michael S. Tsirkin 2018-01-23 0:47 ` Michael S. Tsirkin 2018-01-23 1:13 ` Jakub Kicinski 2018-01-23 1:23 ` Michael S. Tsirkin 2018-01-23 1:23 ` Michael S. Tsirkin 2018-01-23 1:23 ` Michael S. Tsirkin 2018-01-23 19:21 ` Jakub Kicinski 2018-01-23 19:21 ` Jakub Kicinski 2018-01-23 1:13 ` Jakub Kicinski 2018-01-23 1:34 ` Samudrala, Sridhar 2018-01-23 1:34 ` Samudrala, Sridhar [this message] 2018-01-23 1:34 ` Samudrala, Sridhar 2018-01-23 2:04 ` Michael S. Tsirkin 2018-01-23 2:04 ` Michael S. Tsirkin 2018-01-23 2:04 ` [virtio-dev] " Michael S. Tsirkin 2018-01-23 3:36 ` Alexander Duyck 2018-01-23 3:36 ` Alexander Duyck 2018-01-23 5:54 ` Samudrala, Sridhar 2018-01-23 5:54 ` Samudrala, Sridhar 2018-01-23 23:01 ` Michael S. Tsirkin 2018-01-23 23:01 ` Michael S. Tsirkin 2018-01-23 23:01 ` Michael S. Tsirkin 2018-01-22 23:27 ` Samudrala, Sridhar 2018-01-22 21:31 ` Michael S. Tsirkin 2018-01-17 21:49 ` Alexander Duyck 2018-01-17 18:15 ` Alexander Duyck 2018-01-12 5:58 ` Sridhar Samudrala 2018-01-12 5:58 ` [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala 2018-01-12 5:58 ` Sridhar Samudrala 2018-01-12 5:58 ` [virtio-dev] " Sridhar Samudrala 2018-01-22 20:27 ` Siwei Liu 2018-01-22 20:27 ` [virtio-dev] " Siwei Liu 2018-01-22 21:05 ` Samudrala, Sridhar 2018-01-22 21:05 ` Samudrala, Sridhar 2018-01-22 21:05 ` [virtio-dev] " Samudrala, Sridhar 2018-01-23 19:53 ` Laine Stump 2018-01-22 21:41 ` Michael S. Tsirkin 2018-01-22 21:41 ` [virtio-dev] " Michael S. Tsirkin 2018-01-23 20:24 ` Siwei Liu 2018-01-23 20:24 ` [virtio-dev] " Siwei Liu 2018-01-23 22:58 ` Michael S. Tsirkin 2018-01-23 22:58 ` Michael S. Tsirkin 2018-01-23 22:58 ` [virtio-dev] " Michael S. Tsirkin 2018-01-26 8:14 ` Siwei Liu 2018-01-26 8:14 ` Siwei Liu 2018-01-26 8:14 ` [virtio-dev] " Siwei Liu 2018-01-26 16:51 ` Samudrala, Sridhar 2018-01-26 16:51 ` Samudrala, Sridhar 2018-01-26 16:51 ` [virtio-dev] " Samudrala, Sridhar 2018-01-26 21:46 ` Siwei Liu 2018-01-26 21:46 ` Siwei Liu 2018-01-26 21:46 ` [virtio-dev] " Siwei Liu 2018-01-26 22:14 ` Michael S. Tsirkin 2018-01-26 22:14 ` Michael S. Tsirkin 2018-01-26 22:14 ` Michael S. Tsirkin 2018-01-26 22:47 ` Jakub Kicinski 2018-01-26 22:47 ` Jakub Kicinski 2018-01-26 23:30 ` Samudrala, Sridhar 2018-01-26 23:30 ` Samudrala, Sridhar 2018-01-27 2:30 ` Jakub Kicinski 2018-01-27 5:33 ` Samudrala, Sridhar 2018-01-27 5:33 ` Samudrala, Sridhar 2018-01-27 5:58 ` Jakub Kicinski 2018-01-28 17:35 ` Alexander Duyck 2018-01-28 17:35 ` Alexander Duyck 2018-01-28 17:35 ` [virtio-dev] " Alexander Duyck 2018-01-28 19:18 ` Samudrala, Sridhar 2018-01-28 19:18 ` Samudrala, Sridhar 2018-01-28 19:18 ` Samudrala, Sridhar 2018-01-28 20:18 ` Alexander Duyck 2018-01-28 20:18 ` Alexander Duyck 2018-01-28 20:18 ` [virtio-dev] " Alexander Duyck 2018-01-28 21:01 ` Samudrala, Sridhar 2018-01-28 21:01 ` Samudrala, Sridhar 2018-01-28 21:01 ` Samudrala, Sridhar 2018-01-29 0:58 ` Alexander Duyck 2018-01-29 0:58 ` Alexander Duyck 2018-01-28 23:02 ` Stephen Hemminger 2018-01-28 23:02 ` Stephen Hemminger 2018-01-29 4:26 ` Alexander Duyck 2018-01-29 4:26 ` [virtio-dev] " Alexander Duyck 2018-01-29 18:24 ` Michael S. Tsirkin 2018-01-29 18:24 ` [virtio-dev] " Michael S. Tsirkin 2018-01-29 20:09 ` Alexander Duyck 2018-01-29 20:09 ` Alexander Duyck 2018-01-29 20:09 ` [virtio-dev] " Alexander Duyck 2018-01-29 18:24 ` Michael S. Tsirkin 2018-01-29 4:26 ` Alexander Duyck 2018-01-23 20:24 ` Siwei Liu 2018-01-22 21:41 ` Michael S. Tsirkin 2018-01-22 20:27 ` Siwei Liu 2018-01-23 10:33 ` Jason Wang 2018-01-23 10:33 ` [virtio-dev] " Jason Wang 2018-01-23 16:03 ` Samudrala, Sridhar 2018-01-23 16:03 ` Samudrala, Sridhar 2018-01-23 16:03 ` [virtio-dev] " Samudrala, Sridhar 2018-01-29 3:32 ` Jason Wang 2018-01-29 3:32 ` Jason Wang 2018-01-29 3:32 ` [virtio-dev] " Jason Wang 2018-01-26 16:58 ` Michael S. Tsirkin 2018-01-26 16:58 ` [virtio-dev] " Michael S. Tsirkin 2018-01-26 18:15 ` Samudrala, Sridhar 2018-01-26 18:15 ` [virtio-dev] " Samudrala, Sridhar 2018-01-12 5:58 ` [RFC PATCH 1/1] qemu: Introduce VIRTIO_NET_F_BACKUP feature bit to virtio_net Sridhar Samudrala 2018-01-12 5:58 ` [virtio-dev] " Sridhar Samudrala 2018-01-12 5:58 ` Sridhar Samudrala
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=be3864b4-f108-6a7d-8628-204d4d4ae278@intel.com \ --to=sridhar.samudrala@intel.com \ --cc=achiad.mellanox@gmail.com \ --cc=achiad@mellanox.com \ --cc=alexander.duyck@gmail.com \ --cc=alexander.h.duyck@intel.com \ --cc=davem@davemloft.net \ --cc=jesse.brandeburg@intel.com \ --cc=kubakici@wp.pl \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=stephen@networkplumber.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.