* [PATCH] mmc: dw_mmc: Drop redundant call to ->card_event callback
@ 2021-02-12 13:24 ` Ulf Hansson
2021-02-18 0:23 ` Jaehoon Chung
0 siblings, 1 reply; 2+ messages in thread
From: Ulf Hansson @ 2021-02-12 13:24 UTC (permalink / raw)
To: linux-mmc, Ulf Hansson; +Cc: Jaehoon Chung
The ->card_event callback isn't being used by any of the dw_mmc variants.
It's likely a leftover from an earlier change, hence let's just drop the
redundant call to it.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/mmc/host/dw_mmc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index a5244435556b..df327c89cec5 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -2606,8 +2606,6 @@ static void dw_mci_handle_cd(struct dw_mci *host)
{
struct dw_mci_slot *slot = host->slot;
- if (slot->mmc->ops->card_event)
- slot->mmc->ops->card_event(slot->mmc);
mmc_detect_change(slot->mmc,
msecs_to_jiffies(host->pdata->detect_delay_ms));
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: dw_mmc: Drop redundant call to ->card_event callback
2021-02-12 13:24 ` [PATCH] mmc: dw_mmc: Drop redundant call to ->card_event callback Ulf Hansson
@ 2021-02-18 0:23 ` Jaehoon Chung
0 siblings, 0 replies; 2+ messages in thread
From: Jaehoon Chung @ 2021-02-18 0:23 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
On 2/12/21 10:24 PM, Ulf Hansson wrote:
> The ->card_event callback isn't being used by any of the dw_mmc variants.
> It's likely a leftover from an earlier change, hence let's just drop the
> redundant call to it.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards
Jaehoon Chung
> ---
> drivers/mmc/host/dw_mmc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a5244435556b..df327c89cec5 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2606,8 +2606,6 @@ static void dw_mci_handle_cd(struct dw_mci *host)
> {
> struct dw_mci_slot *slot = host->slot;
>
> - if (slot->mmc->ops->card_event)
> - slot->mmc->ops->card_event(slot->mmc);
> mmc_detect_change(slot->mmc,
> msecs_to_jiffies(host->pdata->detect_delay_ms));
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-18 0:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210212132415epcas1p4811e5feb2da2d3c942ec0940d9d7688b@epcas1p4.samsung.com>
2021-02-12 13:24 ` [PATCH] mmc: dw_mmc: Drop redundant call to ->card_event callback Ulf Hansson
2021-02-18 0:23 ` Jaehoon Chung
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.