All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
To: Manikanta Maddireddy
	<mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org,
	vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	kthota-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 01/10] genirq: Export irq_set_msi_desc()
Date: Tue, 28 Nov 2017 10:00:32 +0000	[thread overview]
Message-ID: <be79bf6f-b24a-6292-5eb1-3bcf97890421@arm.com> (raw)
In-Reply-To: <600a7b65-670e-b164-913c-99e18ae593d2-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 25/11/17 19:41, Manikanta Maddireddy wrote:
> 
> 
> On 25-Nov-17 5:25 AM, Thomas Gleixner wrote:
>> On Fri, 24 Nov 2017, Manikanta Maddireddy wrote:
>>
>> Please CC the proper mailing list for irq related changes.
>>
>>> PCI bus support MSI interrupts, allow PCI host driver to set MSI descriptor
>>> data for an irq.
>>
>> This is not really an explanation why this export is needed.
>>
>> Thanks,
>>
>> 	tglx
>>
> Updated the commit log with why Tegra PCIe driver is using this function in V2.
> Please review.

Well, to review it, I would like to be on Cc.

My current position on this is that if you need to export this function,
then you're using a deprecated API, and you should instead consider
moving to the generic MSI model, which doesn't need any of this.

I've done that a distant past, but never actually published the patch
(not tested it):

https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/kill-msi-controller&id=83b3602fcee7972b9d549ed729b56ec28de16081

But without seeing the patches, I may be barking up the wrong tree...

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
	robh+dt@kernel.org, frowand.list@gmail.com, bhelgaas@google.com,
	rjw@rjwysocki.net, vidyas@nvidia.com, kthota@nvidia.com,
	linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 01/10] genirq: Export irq_set_msi_desc()
Date: Tue, 28 Nov 2017 10:00:32 +0000	[thread overview]
Message-ID: <be79bf6f-b24a-6292-5eb1-3bcf97890421@arm.com> (raw)
In-Reply-To: <600a7b65-670e-b164-913c-99e18ae593d2@nvidia.com>

On 25/11/17 19:41, Manikanta Maddireddy wrote:
> 
> 
> On 25-Nov-17 5:25 AM, Thomas Gleixner wrote:
>> On Fri, 24 Nov 2017, Manikanta Maddireddy wrote:
>>
>> Please CC the proper mailing list for irq related changes.
>>
>>> PCI bus support MSI interrupts, allow PCI host driver to set MSI descriptor
>>> data for an irq.
>>
>> This is not really an explanation why this export is needed.
>>
>> Thanks,
>>
>> 	tglx
>>
> Updated the commit log with why Tegra PCIe driver is using this function in V2.
> Please review.

Well, to review it, I would like to be on Cc.

My current position on this is that if you need to export this function,
then you're using a deprecated API, and you should instead consider
moving to the generic MSI model, which doesn't need any of this.

I've done that a distant past, but never actually published the patch
(not tested it):

https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/kill-msi-controller&id=83b3602fcee7972b9d549ed729b56ec28de16081

But without seeing the patches, I may be barking up the wrong tree...

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2017-11-28 10:00 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-24 15:53 [PATCH 00/10] Add loadable kernel module and power management support Manikanta Maddireddy
2017-11-24 15:53 ` Manikanta Maddireddy
     [not found] ` <1511538800-8275-1-git-send-email-mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-11-24 15:53   ` [PATCH 01/10] genirq: Export irq_set_msi_desc() Manikanta Maddireddy
2017-11-24 15:53     ` Manikanta Maddireddy
2017-11-24 23:55     ` Thomas Gleixner
2017-11-25 19:41       ` Manikanta Maddireddy
2017-11-25 19:41         ` Manikanta Maddireddy
     [not found]         ` <600a7b65-670e-b164-913c-99e18ae593d2-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-11-28 10:00           ` Marc Zyngier [this message]
2017-11-28 10:00             ` Marc Zyngier
2017-11-28 17:19             ` Manikanta Maddireddy
2017-11-28 17:19               ` Manikanta Maddireddy
2017-11-24 15:53   ` [PATCH 02/10] of: Export of_pci_range_to_resource() Manikanta Maddireddy
2017-11-24 15:53     ` Manikanta Maddireddy
2017-11-24 15:53   ` [PATCH 03/10] PM / QoS: Fix device resume latency for non PM QoS devices Manikanta Maddireddy
2017-11-24 15:53     ` Manikanta Maddireddy
2017-11-24 16:50     ` Rafael J. Wysocki
     [not found]       ` <CAJZ5v0ghcwSHdrbZd_=XA=tHz7=aTUVd66dHkMYRNyXpnqP84w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-24 20:39         ` Thierry Reding
2017-11-24 20:39           ` Thierry Reding
2017-11-25  0:02           ` Rafael J. Wysocki
2017-11-25  0:02             ` Rafael J. Wysocki
     [not found]             ` <CAJZ5v0h1EdMV5u-5noMv_1_OpS13nH2NW_6Aua9+LMoWH0tL2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-25 19:46               ` Manikanta Maddireddy
2017-11-25 19:46                 ` Manikanta Maddireddy
2017-11-24 15:53   ` [PATCH 06/10] PCI: Export pci_flags Manikanta Maddireddy
2017-11-24 15:53     ` Manikanta Maddireddy
2017-11-24 15:53   ` [PATCH 08/10] PCI: tegra: Add loadable kernel module support Manikanta Maddireddy
2017-11-24 15:53     ` Manikanta Maddireddy
2017-11-24 15:53   ` [PATCH 10/10] PCI: tegra: Add power management support Manikanta Maddireddy
2017-11-24 15:53     ` Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 04/10] ARM: tegra: EXPORT tegra_cpuidle_pcie_irqs_in_use() Manikanta Maddireddy
2017-11-24 15:53   ` Manikanta Maddireddy
2017-11-30 12:41   ` Lorenzo Pieralisi
2017-11-30 18:46     ` Manikanta Maddireddy
2017-11-30 18:46       ` Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 05/10] PCI: Export pci_find_host_bridge() Manikanta Maddireddy
2017-11-24 15:53   ` Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 07/10] PCI: tegra: free resources on probe failure Manikanta Maddireddy
2017-11-24 15:53   ` Manikanta Maddireddy
2017-11-24 15:53 ` [PATCH 09/10] PCI: tegra: Broadcast PME_turn_Off message before link goes to L2 Manikanta Maddireddy
2017-11-24 15:53   ` Manikanta Maddireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be79bf6f-b24a-6292-5eb1-3bcf97890421@arm.com \
    --to=marc.zyngier-5wv7dgnigg8@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=kthota-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.