From: "Phani A, Rama Krishna" <rphani-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> To: Stanimir Varbanov <stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, smohanad-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, sivaa-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, Julia.Lawall-L2FTfq7BK8M@public.gmane.org Subject: Re: [PATCH V3 2/2] iio: adc: spmi-vadc: Changes to support different scaling Date: Thu, 27 Oct 2016 23:07:04 +0530 [thread overview] Message-ID: <be7d758f-1698-1b6d-e6a1-a2910a914737@codeaurora.org> (raw) In-Reply-To: <8418e7f1-55d9-2dfa-1dc7-5960f9da0305-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Hi Stan, On 27-Oct-16 4:48 PM, Stanimir Varbanov wrote: > Hi Rama, > > On 10/26/2016 05:41 PM, Rama Krishna Phani A wrote: >> Polling can also be used for End of conversion completion. Implement logic >> to choose either polling or interrupt for End of conversion completion. >> Scaling can be done on the voltage to report adc code in physical units. >> Add changes to support different scale functions to convert adc code to >> physical units. >> >> Signed-off-by: Rama Krishna Phani A <rphani-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >> --- >> .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 14 ++ >> drivers/iio/adc/qcom-spmi-vadc.c | 263 +++++++++++++++++---- >> 2 files changed, 236 insertions(+), 41 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt >> index 0fb4613..39e31c0e 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt >> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt >> @@ -37,6 +37,12 @@ VADC node: >> Value type: <prop-encoded-array> >> Definition: End of conversion interrupt. >> >> +- qcom,vadc-poll-eoc: >> + Usage: optional >> + Value type: <bool> >> + Definition: Use polling instead of interrupts for End of Conversion >> + completion. > > Why you need to add such a flag in DT? > > The DT should describe hardware details not how the driver will choose > pooling vs interrupt. > > On which use-case you would prefer pooling? > Few PMIC's support interrupt functionality for ADC where as few PMIC's dont support. Based on the functionality that is supported in hardware we choose whether to go for polling or for interrupt. >> + >> Channel node properties: >> >> - reg: >> @@ -92,6 +98,14 @@ Channel node properties: >> Valid values are: 1, 2, 4, 8, 16, 32, 64, 128, 256, 512 >> If property is not found, 1 sample will be used. >> >> +- qcom,scale-function: >> + Usage: optional >> + Value type: <u32> >> + Definition: Scaling function used to convert raw ADC code to >> + units specific to a given channel. Scaled units can be >> + microvolts, millidegC.Valid values are: 0, 1, 2, 3, 4. >> + If property is not found, 0 scaling will be used. > > This shouldn't be in DT binding. Just select the scale function for each > channel in the driver based on compatible property. > > Ok ., Will remove this binding from DT, implement logic in driver and will post next patch. Thanks, Ramakrishna
WARNING: multiple messages have this Message-ID (diff)
From: "Phani A, Rama Krishna" <rphani@codeaurora.org> To: Stanimir Varbanov <stanimir.varbanov@linaro.org>, linux-iio@vger.kernel.org, jic23@kernel.org, devicetree@vger.kernel.org Cc: robh@kernel.org, linux-arm-msm@vger.kernel.org, smohanad@codeaurora.org, mgautam@codeaurora.org, sivaa@codeaurora.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, Julia.Lawall@lip6.fr Subject: Re: [PATCH V3 2/2] iio: adc: spmi-vadc: Changes to support different scaling Date: Thu, 27 Oct 2016 23:07:04 +0530 [thread overview] Message-ID: <be7d758f-1698-1b6d-e6a1-a2910a914737@codeaurora.org> (raw) In-Reply-To: <8418e7f1-55d9-2dfa-1dc7-5960f9da0305@linaro.org> Hi Stan, On 27-Oct-16 4:48 PM, Stanimir Varbanov wrote: > Hi Rama, > > On 10/26/2016 05:41 PM, Rama Krishna Phani A wrote: >> Polling can also be used for End of conversion completion. Implement logic >> to choose either polling or interrupt for End of conversion completion. >> Scaling can be done on the voltage to report adc code in physical units. >> Add changes to support different scale functions to convert adc code to >> physical units. >> >> Signed-off-by: Rama Krishna Phani A <rphani@codeaurora.org> >> --- >> .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 14 ++ >> drivers/iio/adc/qcom-spmi-vadc.c | 263 +++++++++++++++++---- >> 2 files changed, 236 insertions(+), 41 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt >> index 0fb4613..39e31c0e 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt >> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt >> @@ -37,6 +37,12 @@ VADC node: >> Value type: <prop-encoded-array> >> Definition: End of conversion interrupt. >> >> +- qcom,vadc-poll-eoc: >> + Usage: optional >> + Value type: <bool> >> + Definition: Use polling instead of interrupts for End of Conversion >> + completion. > > Why you need to add such a flag in DT? > > The DT should describe hardware details not how the driver will choose > pooling vs interrupt. > > On which use-case you would prefer pooling? > Few PMIC's support interrupt functionality for ADC where as few PMIC's dont support. Based on the functionality that is supported in hardware we choose whether to go for polling or for interrupt. >> + >> Channel node properties: >> >> - reg: >> @@ -92,6 +98,14 @@ Channel node properties: >> Valid values are: 1, 2, 4, 8, 16, 32, 64, 128, 256, 512 >> If property is not found, 1 sample will be used. >> >> +- qcom,scale-function: >> + Usage: optional >> + Value type: <u32> >> + Definition: Scaling function used to convert raw ADC code to >> + units specific to a given channel. Scaled units can be >> + microvolts, millidegC.Valid values are: 0, 1, 2, 3, 4. >> + If property is not found, 0 scaling will be used. > > This shouldn't be in DT binding. Just select the scale function for each > channel in the driver based on compatible property. > > Ok ., Will remove this binding from DT, implement logic in driver and will post next patch. Thanks, Ramakrishna
next prev parent reply other threads:[~2016-10-27 17:37 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-26 14:41 [PATCH V3 0/2] iio: adc: spmi-vadc: Changes to support different scaling Rama Krishna Phani A 2016-10-26 14:41 ` Rama Krishna Phani A [not found] ` <1477492887-1663-1-git-send-email-rphani-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-10-26 14:41 ` [PATCH V3 1/2] iio: adc: spmi-vadc: Update changes to support reporting of Raw adc code Rama Krishna Phani A 2016-10-26 14:41 ` Rama Krishna Phani A 2016-10-30 17:35 ` Jonathan Cameron [not found] ` <ee44e76a-b7e1-63b2-2251-6247d9e6bb9d-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2016-10-31 8:48 ` Rama Krishna Phani A 2016-10-31 8:48 ` Rama Krishna Phani A [not found] ` <0beb28aa-1726-3046-1652-96f0029fa5dc-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-11-01 18:30 ` Jonathan Cameron 2016-11-01 18:30 ` Jonathan Cameron [not found] ` <de2a0283-201d-fdab-98d0-be45ca71f5ea-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2016-11-02 13:12 ` Phani A, Rama Krishna 2016-11-02 13:12 ` Phani A, Rama Krishna [not found] ` <a36d7f9c-7716-19bb-2710-7af90f8e0787-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-11-05 15:59 ` Jonathan Cameron 2016-11-05 15:59 ` Jonathan Cameron 2016-11-07 15:07 ` Phani A, Rama Krishna 2016-10-26 14:41 ` [PATCH V3 2/2] iio: adc: spmi-vadc: Changes to support different scaling Rama Krishna Phani A 2016-10-26 14:41 ` Rama Krishna Phani A [not found] ` <1477492887-1663-3-git-send-email-rphani-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-10-27 11:18 ` Stanimir Varbanov 2016-10-27 11:18 ` Stanimir Varbanov [not found] ` <8418e7f1-55d9-2dfa-1dc7-5960f9da0305-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-10-27 17:37 ` Phani A, Rama Krishna [this message] 2016-10-27 17:37 ` Phani A, Rama Krishna 2016-10-30 17:13 ` Jonathan Cameron [not found] ` <a96141dc-6ee5-2d7c-868c-7cb282002b89-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2016-10-31 7:12 ` Rama Krishna Phani A 2016-10-31 7:12 ` Rama Krishna Phani A 2016-10-31 9:26 ` Stanimir Varbanov 2016-11-01 5:32 ` Phani A, Rama Krishna 2016-10-30 17:39 ` Jonathan Cameron 2016-10-31 7:45 ` Rama Krishna Phani A
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=be7d758f-1698-1b6d-e6a1-a2910a914737@codeaurora.org \ --to=rphani-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \ --cc=Julia.Lawall-L2FTfq7BK8M@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \ --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \ --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=sivaa-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=smohanad-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.