* [Buildroot] [PATCH] btrfs-progs: fix static build with gettext
@ 2015-02-17 12:20 Baruch Siach
2015-02-19 21:58 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2015-02-17 12:20 UTC (permalink / raw)
To: buildroot
gettext needs -pthread. Incidentally this change was also made in the package
Makefile itself for a different reason.
Also, drop -lm to match upstream change.
Fixes:
http://autobuild.buildroot.net/results/a53/a53f31355e955c734010922b47084605e13708ef/
http://autobuild.buildroot.net/results/43d/43deeeda31d9750b37e1f1058c3313a387843bee/
and more.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/btrfs-progs/btrfs-progs.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/btrfs-progs/btrfs-progs.mk b/package/btrfs-progs/btrfs-progs.mk
index c6c36cf1556c..768660d27c8f 100644
--- a/package/btrfs-progs/btrfs-progs.mk
+++ b/package/btrfs-progs/btrfs-progs.mk
@@ -18,7 +18,7 @@ BTRFS_PROGS_MAKE_TARGET = static
BTRFS_PROGS_MAKE_INSTALL_TARGET = install-static
ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
# Add -lintl for libuuid
-BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lm -lz -llzo2 -L. -lintl"
+BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lz -llzo2 -L. -lintl -pthread"
endif
else
BTRFS_PROGS_MAKE_TARGET = all
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] btrfs-progs: fix static build with gettext
2015-02-17 12:20 [Buildroot] [PATCH] btrfs-progs: fix static build with gettext Baruch Siach
@ 2015-02-19 21:58 ` Thomas Petazzoni
2015-02-19 22:04 ` Baruch Siach
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2015-02-19 21:58 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Tue, 17 Feb 2015 14:20:44 +0200, Baruch Siach wrote:
> gettext needs -pthread. Incidentally this change was also made in the package
> Makefile itself for a different reason.
>
> Also, drop -lm to match upstream change.
>
> Fixes:
> http://autobuild.buildroot.net/results/a53/a53f31355e955c734010922b47084605e13708ef/
> http://autobuild.buildroot.net/results/43d/43deeeda31d9750b37e1f1058c3313a387843bee/
>
> and more.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/btrfs-progs/btrfs-progs.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
> -BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lm -lz -llzo2 -L. -lintl"
> +BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lz -llzo2 -L. -lintl -pthread"
This is really ugly, because we have to duplicate the lib_LIBS value
from the package Makefile, and whenever it gets changed in the package
Makefile, we need to remember to also change it here. Not great :-/
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] btrfs-progs: fix static build with gettext
2015-02-19 21:58 ` Thomas Petazzoni
@ 2015-02-19 22:04 ` Baruch Siach
2015-02-19 22:05 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2015-02-19 22:04 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Thu, Feb 19, 2015 at 10:58:18PM +0100, Thomas Petazzoni wrote:
> On Tue, 17 Feb 2015 14:20:44 +0200, Baruch Siach wrote:
> > gettext needs -pthread. Incidentally this change was also made in the package
> > Makefile itself for a different reason.
> >
> > Also, drop -lm to match upstream change.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/a53/a53f31355e955c734010922b47084605e13708ef/
> > http://autobuild.buildroot.net/results/43d/43deeeda31d9750b37e1f1058c3313a387843bee/
> >
> > and more.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > package/btrfs-progs/btrfs-progs.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks!
>
> > -BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lm -lz -llzo2 -L. -lintl"
> > +BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lz -llzo2 -L. -lintl -pthread"
>
> This is really ugly, because we have to duplicate the lib_LIBS value
> from the package Makefile, and whenever it gets changed in the package
> Makefile, we need to remember to also change it here. Not great :-/
This is temporary. Upstream switched to autotools for the next version (now at
v3.19-rc2). Once we upgrade the usual LIBS= trick would be enough, I believe.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] btrfs-progs: fix static build with gettext
2015-02-19 22:04 ` Baruch Siach
@ 2015-02-19 22:05 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2015-02-19 22:05 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Fri, 20 Feb 2015 00:04:00 +0200, Baruch Siach wrote:
> > This is really ugly, because we have to duplicate the lib_LIBS value
> > from the package Makefile, and whenever it gets changed in the package
> > Makefile, we need to remember to also change it here. Not great :-/
>
> This is temporary. Upstream switched to autotools for the next version (now at
> v3.19-rc2). Once we upgrade the usual LIBS= trick would be enough, I believe.
Ah, ok, good to know! Thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-19 22:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 12:20 [Buildroot] [PATCH] btrfs-progs: fix static build with gettext Baruch Siach
2015-02-19 21:58 ` Thomas Petazzoni
2015-02-19 22:04 ` Baruch Siach
2015-02-19 22:05 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.