[MPTCP] Re: [PATCH v3 0/4] mptcp: msk diag support

[MPTCP] Re: [PATCH v3 0/4] mptcp: msk diag support

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On Fri, 2020-07-03 at 21:11 +0200, Matthieu Baerts wrote:
> Hi Paolo, Mat,
> 
> On 03/07/2020 00:06, Mat Martineau wrote:
> > On Thu, 2 Jul 2020, Paolo Abeni wrote:
> > 
> > > This introduces basic mptcp sockets diag support.
> > > As IPPROTO_MPTCP excedes 8 bits, we need some changes at the inet_diag 
> > > level:
> > > a new attribute is introduced to allow user-space providing u32 protocol
> > > values.
> > > 
> > > Patch 2 introduces new token APIs to allow traversing the existing 
> > > msks, while
> > > patch 3 bring in the actual diag implementation.
> > > 
> > > Patch 4 includes some basic functional tests
> > > 
> > > v2 -> v3:
> > > - changed token iterator APIs: use RCU && get_sock
> > > - tests cleanup
> > 
> > Thanks for the v3 fixes Paolo, my concerns in v2 are addressed. There is 
> > the proto range checking issue Christoph noted in patch 1 to fix before 
> > merging.
> 
> Thank you for the patches and the reviews!
> 
> These patches have been added at the end.
> 
> Tests are re-running with INET_DIAG enabled. Export is going to be done 
> soon after.

Note that diag self-tests requiere a version of iproute2 including the
pending 2 patches, otherwise tests will be skipped - so no failure but
also no tests.

Thanks,

Paolo

[MPTCP] Re: [PATCH v3 0/4] mptcp: msk diag support

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

Hi Paolo,

On 06/07/2020 11:38, Paolo Abeni wrote:
> On Fri, 2020-07-03 at 21:11 +0200, Matthieu Baerts wrote:
>> Hi Paolo, Mat,
>>
>> On 03/07/2020 00:06, Mat Martineau wrote:
>>> On Thu, 2 Jul 2020, Paolo Abeni wrote:
>>>
>>>> This introduces basic mptcp sockets diag support.
>>>> As IPPROTO_MPTCP excedes 8 bits, we need some changes at the inet_diag
>>>> level:
>>>> a new attribute is introduced to allow user-space providing u32 protocol
>>>> values.
>>>>
>>>> Patch 2 introduces new token APIs to allow traversing the existing
>>>> msks, while
>>>> patch 3 bring in the actual diag implementation.
>>>>
>>>> Patch 4 includes some basic functional tests
>>>>
>>>> v2 -> v3:
>>>> - changed token iterator APIs: use RCU && get_sock
>>>> - tests cleanup
>>>
>>> Thanks for the v3 fixes Paolo, my concerns in v2 are addressed. There is
>>> the proto range checking issue Christoph noted in patch 1 to fix before
>>> merging.
>>
>> Thank you for the patches and the reviews!
>>
>> These patches have been added at the end.
>>
>> Tests are re-running with INET_DIAG enabled. Export is going to be done
>> soon after.
> 
> Note that diag self-tests requiere a version of iproute2 including the
> pending 2 patches, otherwise tests will be skipped - so no failure but
> also no tests.

Yes, my CI complained about the skipped test :)

I am currently ignoring the skipped test: 
https://github.com/multipath-tcp/mptcp_net-next/commit/f7ccd2f70239265cd13d6017554a025a44e68d8a

Once the two others patches are merged in iproute2 repo, I will make 
sure this new selftest is correctly tested.

Cheers
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [PATCH v3 0/4] mptcp: msk diag support

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

Hi Paolo, Mat,

On 03/07/2020 00:06, Mat Martineau wrote:
> 
> On Thu, 2 Jul 2020, Paolo Abeni wrote:
> 
>> This introduces basic mptcp sockets diag support.
>> As IPPROTO_MPTCP excedes 8 bits, we need some changes at the inet_diag 
>> level:
>> a new attribute is introduced to allow user-space providing u32 protocol
>> values.
>>
>> Patch 2 introduces new token APIs to allow traversing the existing 
>> msks, while
>> patch 3 bring in the actual diag implementation.
>>
>> Patch 4 includes some basic functional tests
>>
>> v2 -> v3:
>> - changed token iterator APIs: use RCU && get_sock
>> - tests cleanup
> 
> Thanks for the v3 fixes Paolo, my concerns in v2 are addressed. There is 
> the proto range checking issue Christoph noted in patch 1 to fix before 
> merging.

Thank you for the patches and the reviews!

These patches have been added at the end.

Tests are re-running with INET_DIAG enabled. Export is going to be done 
soon after.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [PATCH v3 0/4] mptcp: msk diag support

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]


On Thu, 2 Jul 2020, Paolo Abeni wrote:

> This introduces basic mptcp sockets diag support.
> As IPPROTO_MPTCP excedes 8 bits, we need some changes at the inet_diag level:
> a new attribute is introduced to allow user-space providing u32 protocol
> values.
>
> Patch 2 introduces new token APIs to allow traversing the existing msks, while
> patch 3 bring in the actual diag implementation.
>
> Patch 4 includes some basic functional tests
>
> v2 -> v3:
> - changed token iterator APIs: use RCU && get_sock
> - tests cleanup

Thanks for the v3 fixes Paolo, my concerns in v2 are addressed. There is 
the proto range checking issue Christoph noted in patch 1 to fix before 
merging.


Mat


>
> v1 -> v2
> - fixed dump issue on large dump
> - use flags for fallback, etc
> - patch 4
>
> Paolo Abeni (4):
>  inet_diag: support for wider protocol numbers
>  mptcp: add msk interations helper
>  mptcp: add MPTCP socket diag interface
>  selftests/mptcp: add diag interface tests
>
> include/uapi/linux/inet_diag.h                |   1 +
> include/uapi/linux/mptcp.h                    |  17 ++
> net/core/sock.c                               |   1 +
> net/ipv4/inet_diag.c                          |  63 +++++--
> net/mptcp/Kconfig                             |   4 +
> net/mptcp/Makefile                            |   2 +
> net/mptcp/mptcp_diag.c                        | 169 ++++++++++++++++++
> net/mptcp/protocol.h                          |   2 +
> net/mptcp/token.c                             |  59 ++++++
> tools/testing/selftests/net/mptcp/Makefile    |   2 +-
> tools/testing/selftests/net/mptcp/diag.sh     | 122 +++++++++++++
> .../selftests/net/mptcp/mptcp_connect.c       |  22 ++-
> 12 files changed, 442 insertions(+), 22 deletions(-)
> create mode 100644 net/mptcp/mptcp_diag.c
> create mode 100755 tools/testing/selftests/net/mptcp/diag.sh
>
> -- 
> 2.26.2
> _______________________________________________
> mptcp mailing list -- mptcp(a)lists.01.org
> To unsubscribe send an email to mptcp-leave(a)lists.01.org
>

--
Mat Martineau
Intel