All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: Bogdan Togorean <bogdan.togorean@analog.com>,
	dri-devel@lists.freedesktop.org
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	linux-kernel@vger.kernel.org,
	Richard Fontana <rfontana@redhat.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>
Subject: Re: [v2 1/2] drm: bridge: adv7511: Enable SPDIF DAI
Date: Tue, 14 Apr 2020 10:23:26 +0200	[thread overview]
Message-ID: <be860a7a-6e9a-d801-f5cc-e3dbe640513d@samsung.com> (raw)
In-Reply-To: <20200413113513.86091-1-bogdan.togorean@analog.com>

On 13.04.2020 13:35, Bogdan Togorean wrote:
> ADV7511 support I2S or SPDIF as audio input interfaces. This commit
> enable support for SPDIF.
>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

Queued both patches to next.


Regards

Andrzej

> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> index a428185be2c1..1e9b128d229b 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> @@ -119,6 +119,9 @@ int adv7511_hdmi_hw_params(struct device *dev, void *data,
>  		audio_source = ADV7511_AUDIO_SOURCE_I2S;
>  		i2s_format = ADV7511_I2S_FORMAT_LEFT_J;
>  		break;
> +	case HDMI_SPDIF:
> +		audio_source = ADV7511_AUDIO_SOURCE_SPDIF;
> +		break;
>  	default:
>  		return -EINVAL;
>  	}
> @@ -175,11 +178,21 @@ static int audio_startup(struct device *dev, void *data)
>  	/* use Audio infoframe updated info */
>  	regmap_update_bits(adv7511->regmap, ADV7511_REG_GC(1),
>  				BIT(5), 0);
> +	/* enable SPDIF receiver */
> +	if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
> +		regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
> +				   BIT(7), BIT(7));
> +
>  	return 0;
>  }
>  
>  static void audio_shutdown(struct device *dev, void *data)
>  {
> +	struct adv7511 *adv7511 = dev_get_drvdata(dev);
> +
> +	if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
> +		regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
> +				   BIT(7), 0);
>  }
>  
>  static int adv7511_hdmi_i2s_get_dai_id(struct snd_soc_component *component,
> @@ -213,6 +226,7 @@ static const struct hdmi_codec_pdata codec_data = {
>  	.ops = &adv7511_codec_ops,
>  	.max_i2s_channels = 2,
>  	.i2s = 1,
> +	.spdif = 1,
>  };
>  
>  int adv7511_audio_init(struct device *dev, struct adv7511 *adv7511)



WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: Bogdan Togorean <bogdan.togorean@analog.com>,
	dri-devel@lists.freedesktop.org
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonas Karlman <jonas@kwiboo.se>,
	linux-kernel@vger.kernel.org,
	Richard Fontana <rfontana@redhat.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>
Subject: Re: [v2 1/2] drm: bridge: adv7511: Enable SPDIF DAI
Date: Tue, 14 Apr 2020 10:23:26 +0200	[thread overview]
Message-ID: <be860a7a-6e9a-d801-f5cc-e3dbe640513d@samsung.com> (raw)
In-Reply-To: <20200413113513.86091-1-bogdan.togorean@analog.com>

On 13.04.2020 13:35, Bogdan Togorean wrote:
> ADV7511 support I2S or SPDIF as audio input interfaces. This commit
> enable support for SPDIF.
>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

Queued both patches to next.


Regards

Andrzej

> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> index a428185be2c1..1e9b128d229b 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> @@ -119,6 +119,9 @@ int adv7511_hdmi_hw_params(struct device *dev, void *data,
>  		audio_source = ADV7511_AUDIO_SOURCE_I2S;
>  		i2s_format = ADV7511_I2S_FORMAT_LEFT_J;
>  		break;
> +	case HDMI_SPDIF:
> +		audio_source = ADV7511_AUDIO_SOURCE_SPDIF;
> +		break;
>  	default:
>  		return -EINVAL;
>  	}
> @@ -175,11 +178,21 @@ static int audio_startup(struct device *dev, void *data)
>  	/* use Audio infoframe updated info */
>  	regmap_update_bits(adv7511->regmap, ADV7511_REG_GC(1),
>  				BIT(5), 0);
> +	/* enable SPDIF receiver */
> +	if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
> +		regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
> +				   BIT(7), BIT(7));
> +
>  	return 0;
>  }
>  
>  static void audio_shutdown(struct device *dev, void *data)
>  {
> +	struct adv7511 *adv7511 = dev_get_drvdata(dev);
> +
> +	if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
> +		regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
> +				   BIT(7), 0);
>  }
>  
>  static int adv7511_hdmi_i2s_get_dai_id(struct snd_soc_component *component,
> @@ -213,6 +226,7 @@ static const struct hdmi_codec_pdata codec_data = {
>  	.ops = &adv7511_codec_ops,
>  	.max_i2s_channels = 2,
>  	.i2s = 1,
> +	.spdif = 1,
>  };
>  
>  int adv7511_audio_init(struct device *dev, struct adv7511 *adv7511)


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-04-14  8:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200414070644eucas1p150b35a8ea7531ab5172046b1d913d6f7@eucas1p1.samsung.com>
2020-04-13 11:35 ` [v2 1/2] drm: bridge: adv7511: Enable SPDIF DAI Bogdan Togorean
2020-04-13 11:35   ` Bogdan Togorean
2020-04-13 11:35   ` [v2 2/2] drm: bridge: adv7511: Extend list of audio sample rates Bogdan Togorean
2020-04-13 11:35     ` Bogdan Togorean
2020-04-14  8:23   ` Andrzej Hajda [this message]
2020-04-14  8:23     ` [v2 1/2] drm: bridge: adv7511: Enable SPDIF DAI Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be860a7a-6e9a-d801-f5cc-e3dbe640513d@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=allison@lohutok.net \
    --cc=bogdan.togorean@analog.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=rfontana@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.