All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	"open list:PReP" <qemu-ppc@nongnu.org>,
	Fam Zheng <fam@euphon.net>
Subject: Re: [Qemu-devel] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810
Date: Mon, 15 Apr 2019 11:21:33 +0200	[thread overview]
Message-ID: <be91f478-3874-1bfb-2e31-01b0af8740a3@redhat.com> (raw)
In-Reply-To: <CACXAS8BFciYO3MsAgfX+OLy0wGf=hZYdbph4U_LQ6PiMOwtRAQ@mail.gmail.com>

On 14/04/19 20:36, Artyom Tarasenko wrote:
>> You can probably remove this change, and replace it by
>> uint16_t type = PCI_DEVICE_GET_CLASS(dev)->device_id;
> Brilliant! Will do in V2, thainks.

Either that, or you could keep the current structure and make mmio_size
the last parameter of lsi_scsi_realize.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>
Cc: Fam Zheng <fam@euphon.net>,
	"open list:PReP" <qemu-ppc@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810
Date: Mon, 15 Apr 2019 11:21:33 +0200	[thread overview]
Message-ID: <be91f478-3874-1bfb-2e31-01b0af8740a3@redhat.com> (raw)
Message-ID: <20190415092133.8_EzdOfkt2v0TBNaNIvZv2HSWo2yDlRyUZIhLydOO_w@z> (raw)
In-Reply-To: <CACXAS8BFciYO3MsAgfX+OLy0wGf=hZYdbph4U_LQ6PiMOwtRAQ@mail.gmail.com>

On 14/04/19 20:36, Artyom Tarasenko wrote:
>> You can probably remove this change, and replace it by
>> uint16_t type = PCI_DEVICE_GET_CLASS(dev)->device_id;
> Brilliant! Will do in V2, thainks.

Either that, or you could keep the current structure and make mmio_size
the last parameter of lsi_scsi_realize.

Paolo


  reply	other threads:[~2019-04-15  9:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 21:06 [Qemu-devel] [PATCH 0/4] Improve 40p, make AIX 5.1 boot Artyom Tarasenko
2019-04-12 21:06 ` [Qemu-devel] [PATCH 1/4] lsi53c895a: hide 53c895a registers in 53c810 Artyom Tarasenko
2019-04-12 21:06   ` Artyom Tarasenko
2019-04-14 15:43   ` Hervé Poussineau
2019-04-14 15:43     ` Hervé Poussineau
2019-04-14 18:36     ` Artyom Tarasenko
2019-04-14 18:36       ` Artyom Tarasenko
2019-04-15  9:21       ` Paolo Bonzini [this message]
2019-04-15  9:21         ` Paolo Bonzini
2019-04-12 21:06 ` [Qemu-devel] [PATCH 2/4] 40p and prep: implement PCI bus mastering Artyom Tarasenko
2019-04-14 15:43   ` Hervé Poussineau
2019-04-12 21:06 ` [Qemu-devel] [PATCH 3/4] target/ppc: improve performance of large BAT invalidations Artyom Tarasenko
2019-04-14 15:43   ` Hervé Poussineau
2019-04-15  0:20   ` David Gibson
2019-04-15  0:20     ` David Gibson
2019-04-12 21:06 ` [Qemu-devel] [PATCH 4/4] hw/isa/i82378.c: use 1900 as a base year Artyom Tarasenko
2019-04-14 17:01   ` Hervé Poussineau
2019-04-14 18:53     ` Artyom Tarasenko
2019-04-14 18:53       ` Artyom Tarasenko
2019-04-14 21:24       ` Hervé Poussineau
2019-04-14 21:24         ` Hervé Poussineau
2019-04-15 10:36         ` Philippe Mathieu-Daudé
2019-04-15 10:45           ` Artyom Tarasenko
2019-04-15 10:45             ` Artyom Tarasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be91f478-3874-1bfb-2e31-01b0af8740a3@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=atar4qemu@gmail.com \
    --cc=fam@euphon.net \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.