All of lore.kernel.org
 help / color / mirror / Atom feed
From: hejianet <hejianet@gmail.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field
Date: Wed, 7 Sep 2016 10:30:59 +0800	[thread overview]
Message-ID: <beb30504-7c22-482d-330a-469ad3232e8e@gmail.com> (raw)
In-Reply-To: <20160906124413.GC27658@localhost.localdomain>

Hi Marcelo

Thanks for the suggestion

Will consider that

B.R.

Jia


On 9/6/16 8:44 PM, Marcelo Ricardo Leitner wrote:
> On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote:
> ...
>> v2:
>> - 1/6 fix bug in udplite statistics.
>> - 1/6 snmp_seq_show is split into 2 parts
>>
>> Jia He (6):
>>    proc: Reduce cache miss in {snmp,netstat}_seq_show
>>    proc: Reduce cache miss in snmp6_seq_show
>>    proc: Reduce cache miss in sctp_snmp_seq_show
>>    proc: Reduce cache miss in xfrm_statistics_seq_show
>>    ipv6: Remove useless parameter in __snmp6_fill_statsdev
>>    net: Suppress the "Comparison to NULL could be written" warning
> Hi Jia,
>
> Did you try to come up with a generic interface for this, like
> snmp_fold_fields64() (note the fieldS) or snmp_fold_field64_batch() ?
>
> Sounds like we have the same code in several places and seems they all
> operate very similarly. They have a percpu table, an identified max, a
> destination buffer..
>
> If this is possible, this would reduce the possibility of hiccups in a
> particular code.
>
>    Marcelo
>
>

WARNING: multiple messages have this Message-ID (diff)
From: hejianet <hejianet@gmail.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field
Date: Wed, 07 Sep 2016 02:30:59 +0000	[thread overview]
Message-ID: <beb30504-7c22-482d-330a-469ad3232e8e@gmail.com> (raw)
In-Reply-To: <20160906124413.GC27658@localhost.localdomain>

Hi Marcelo

Thanks for the suggestion

Will consider that

B.R.

Jia


On 9/6/16 8:44 PM, Marcelo Ricardo Leitner wrote:
> On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote:
> ...
>> v2:
>> - 1/6 fix bug in udplite statistics.
>> - 1/6 snmp_seq_show is split into 2 parts
>>
>> Jia He (6):
>>    proc: Reduce cache miss in {snmp,netstat}_seq_show
>>    proc: Reduce cache miss in snmp6_seq_show
>>    proc: Reduce cache miss in sctp_snmp_seq_show
>>    proc: Reduce cache miss in xfrm_statistics_seq_show
>>    ipv6: Remove useless parameter in __snmp6_fill_statsdev
>>    net: Suppress the "Comparison to NULL could be written" warning
> Hi Jia,
>
> Did you try to come up with a generic interface for this, like
> snmp_fold_fields64() (note the fieldS) or snmp_fold_field64_batch() ?
>
> Sounds like we have the same code in several places and seems they all
> operate very similarly. They have a percpu table, an identified max, a
> destination buffer..
>
> If this is possible, this would reduce the possibility of hiccups in a
> particular code.
>
>    Marcelo
>
>


  reply	other threads:[~2016-09-07  2:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06  2:30 [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field Jia He
2016-09-06  2:30 ` Jia He
2016-09-06  2:30 ` [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show Jia He
2016-09-06  2:30   ` Jia He
2016-09-06 22:57   ` David Miller
2016-09-06 22:57     ` David Miller
2016-09-07  2:29     ` hejianet
2016-09-07  2:29       ` hejianet
2016-09-06  2:30 ` [RFC PATCH v2 2/6] proc: Reduce cache miss in snmp6_seq_show Jia He
2016-09-06  2:30   ` Jia He
2016-09-06  2:30 ` [RFC PATCH v2 3/6] proc: Reduce cache miss in sctp_snmp_seq_show Jia He
2016-09-06  2:30   ` Jia He
2016-09-06  2:30 ` [RFC PATCH v2 4/6] proc: Reduce cache miss in xfrm_statistics_seq_show Jia He
2016-09-06  2:30   ` Jia He
2016-09-06  2:30 ` [RFC PATCH v2 5/6] ipv6: Remove useless parameter in __snmp6_fill_statsdev Jia He
2016-09-06  2:30   ` Jia He
2016-09-06  2:30 ` [RFC PATCH v2 6/6] net: Suppress the "Comparison to NULL could be written" warning Jia He
2016-09-06  2:30   ` Jia He
2016-09-06 12:44 ` [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field Marcelo Ricardo Leitner
2016-09-06 12:44   ` Marcelo Ricardo Leitner
2016-09-07  2:30   ` hejianet [this message]
2016-09-07  2:30     ` hejianet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=beb30504-7c22-482d-330a-469ad3232e8e@gmail.com \
    --to=hejianet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=steffen.klassert@secunet.com \
    --cc=vyasevich@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.