* [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
@ 2022-12-30 8:08 ` Thorsten Leemhuis
0 siblings, 0 replies; 19+ messages in thread
From: Thorsten Leemhuis @ 2022-12-30 8:08 UTC (permalink / raw)
To: Richard Fitzgerald
Cc: Sergey, Alsa-devel, LKML, regressions, Takashi Iwai,
Jaroslav Kysela, Mark Brown
Hi, this is your Linux kernel regression tracker speaking.
I noticed a regression report in bugzilla.kernel.org. As many (most?)
kernel developer don't keep an eye on it, I decided to forward it by
mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> Sergey 2022-12-29 10:07:51 UTC
>
> Created attachment 303497 [details]
> pulseaudio.log
>
> Sudden sound disappearance was reported for some laptops, e.g.
>
> Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
>
> # lspci
> 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> Subsystem: Acer Incorporated [ALI] Device 148c
> Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> Capabilities: [50] Power Management version 3
> Capabilities: [80] Vendor Specific Information: Len=14 <?>
> Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> Kernel driver in use: sof-audio-pci
>
> I am attaching the pulseaudio and dmesg logs
>
> This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
>
> Bisection revealed the commit being reverted:
>
> c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> Date: Fri Nov 4 13:22:13 2022 +0000
>
> ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
>
> [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
>
> The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> and used by later code that depends on the TDM settings. So
> __soc_pcm_open() should not be obliterating those mask values.
>
> [...]
> Original bug report: https://bugzilla.altlinux.org/44690
See the ticket for more details.
BTW, let me use this mail to also add the report to the list of tracked
regressions to ensure it's doesn't fall through the cracks:
#regzbot introduced: c34db0d6b88b1d
https://bugzilla.kernel.org/show_bug.cgi?id=216861
#regzbot title: sound: asoc: sudden sound disappearance
#regzbot ignore-activity
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
@ 2022-12-30 8:08 ` Thorsten Leemhuis
0 siblings, 0 replies; 19+ messages in thread
From: Thorsten Leemhuis @ 2022-12-30 8:08 UTC (permalink / raw)
To: Richard Fitzgerald
Cc: Alsa-devel, regressions, Takashi Iwai, LKML, Mark Brown, Sergey
Hi, this is your Linux kernel regression tracker speaking.
I noticed a regression report in bugzilla.kernel.org. As many (most?)
kernel developer don't keep an eye on it, I decided to forward it by
mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> Sergey 2022-12-29 10:07:51 UTC
>
> Created attachment 303497 [details]
> pulseaudio.log
>
> Sudden sound disappearance was reported for some laptops, e.g.
>
> Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
>
> # lspci
> 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> Subsystem: Acer Incorporated [ALI] Device 148c
> Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> Capabilities: [50] Power Management version 3
> Capabilities: [80] Vendor Specific Information: Len=14 <?>
> Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> Kernel driver in use: sof-audio-pci
>
> I am attaching the pulseaudio and dmesg logs
>
> This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
>
> Bisection revealed the commit being reverted:
>
> c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> Date: Fri Nov 4 13:22:13 2022 +0000
>
> ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
>
> [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
>
> The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> and used by later code that depends on the TDM settings. So
> __soc_pcm_open() should not be obliterating those mask values.
>
> [...]
> Original bug report: https://bugzilla.altlinux.org/44690
See the ticket for more details.
BTW, let me use this mail to also add the report to the list of tracked
regressions to ensure it's doesn't fall through the cracks:
#regzbot introduced: c34db0d6b88b1d
https://bugzilla.kernel.org/show_bug.cgi?id=216861
#regzbot title: sound: asoc: sudden sound disappearance
#regzbot ignore-activity
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
2022-12-30 8:08 ` Thorsten Leemhuis
@ 2023-01-02 10:43 ` Salvatore Bonaccorso
-1 siblings, 0 replies; 19+ messages in thread
From: Salvatore Bonaccorso @ 2023-01-02 10:43 UTC (permalink / raw)
To: Thorsten Leemhuis
Cc: Richard Fitzgerald, Sergey, Alsa-devel, LKML, regressions,
Takashi Iwai, Jaroslav Kysela, Mark Brown,
PÁLFFY Dániel
Hi,
[Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker speaking.
>
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
>
> > Sergey 2022-12-29 10:07:51 UTC
> >
> > Created attachment 303497 [details]
> > pulseaudio.log
> >
> > Sudden sound disappearance was reported for some laptops, e.g.
> >
> > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> >
> > # lspci
> > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > Subsystem: Acer Incorporated [ALI] Device 148c
> > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > Capabilities: [50] Power Management version 3
> > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > Kernel driver in use: sof-audio-pci
> >
> > I am attaching the pulseaudio and dmesg logs
> >
> > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> >
> > Bisection revealed the commit being reverted:
> >
> > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > Date: Fri Nov 4 13:22:13 2022 +0000
> >
> > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> >
> > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> >
> > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > and used by later code that depends on the TDM settings. So
> > __soc_pcm_open() should not be obliterating those mask values.
> >
> > [...]
> > Original bug report: https://bugzilla.altlinux.org/44690
>
> See the ticket for more details.
>
> BTW, let me use this mail to also add the report to the list of tracked
> regressions to ensure it's doesn't fall through the cracks:
>
> #regzbot introduced: c34db0d6b88b1d
> https://bugzilla.kernel.org/show_bug.cgi?id=216861
> #regzbot title: sound: asoc: sudden sound disappearance
> #regzbot ignore-activity
FWIW, we had as well reports in Debian after having updated the kernel
from 5.10.149 based one to 5.10.158 based one in the last point
releases, they are at least:
https://bugs.debian.org/1027483
https://bugs.debian.org/1027430
Regards,
Salvatore
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
@ 2023-01-02 10:43 ` Salvatore Bonaccorso
0 siblings, 0 replies; 19+ messages in thread
From: Salvatore Bonaccorso @ 2023-01-02 10:43 UTC (permalink / raw)
To: Thorsten Leemhuis
Cc: Alsa-devel, regressions, LKML, Takashi Iwai, Richard Fitzgerald,
Mark Brown, PÁLFFY Dániel, Sergey
Hi,
[Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker speaking.
>
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
>
> > Sergey 2022-12-29 10:07:51 UTC
> >
> > Created attachment 303497 [details]
> > pulseaudio.log
> >
> > Sudden sound disappearance was reported for some laptops, e.g.
> >
> > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> >
> > # lspci
> > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > Subsystem: Acer Incorporated [ALI] Device 148c
> > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > Capabilities: [50] Power Management version 3
> > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > Kernel driver in use: sof-audio-pci
> >
> > I am attaching the pulseaudio and dmesg logs
> >
> > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> >
> > Bisection revealed the commit being reverted:
> >
> > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > Date: Fri Nov 4 13:22:13 2022 +0000
> >
> > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> >
> > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> >
> > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > and used by later code that depends on the TDM settings. So
> > __soc_pcm_open() should not be obliterating those mask values.
> >
> > [...]
> > Original bug report: https://bugzilla.altlinux.org/44690
>
> See the ticket for more details.
>
> BTW, let me use this mail to also add the report to the list of tracked
> regressions to ensure it's doesn't fall through the cracks:
>
> #regzbot introduced: c34db0d6b88b1d
> https://bugzilla.kernel.org/show_bug.cgi?id=216861
> #regzbot title: sound: asoc: sudden sound disappearance
> #regzbot ignore-activity
FWIW, we had as well reports in Debian after having updated the kernel
from 5.10.149 based one to 5.10.158 based one in the last point
releases, they are at least:
https://bugs.debian.org/1027483
https://bugs.debian.org/1027430
Regards,
Salvatore
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
2023-01-02 10:43 ` Salvatore Bonaccorso
@ 2023-01-02 12:42 ` Takashi Iwai
-1 siblings, 0 replies; 19+ messages in thread
From: Takashi Iwai @ 2023-01-02 12:42 UTC (permalink / raw)
To: Salvatore Bonaccorso
Cc: Thorsten Leemhuis, Alsa-devel, regressions, LKML, Takashi Iwai,
Richard Fitzgerald, Mark Brown, PÁLFFY Dániel, Sergey
On Mon, 02 Jan 2023 11:43:36 +0100,
Salvatore Bonaccorso wrote:
>
> Hi,
>
> [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
>
> On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> > Hi, this is your Linux kernel regression tracker speaking.
> >
> > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > kernel developer don't keep an eye on it, I decided to forward it by
> > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> >
> > > Sergey 2022-12-29 10:07:51 UTC
> > >
> > > Created attachment 303497 [details]
> > > pulseaudio.log
> > >
> > > Sudden sound disappearance was reported for some laptops, e.g.
> > >
> > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> > >
> > > # lspci
> > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > > Subsystem: Acer Incorporated [ALI] Device 148c
> > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > > Capabilities: [50] Power Management version 3
> > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > > Kernel driver in use: sof-audio-pci
> > >
> > > I am attaching the pulseaudio and dmesg logs
> > >
> > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> > >
> > > Bisection revealed the commit being reverted:
> > >
> > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > > Date: Fri Nov 4 13:22:13 2022 +0000
> > >
> > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> > >
> > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> > >
> > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > > and used by later code that depends on the TDM settings. So
> > > __soc_pcm_open() should not be obliterating those mask values.
> > >
> > > [...]
> > > Original bug report: https://bugzilla.altlinux.org/44690
> >
> > See the ticket for more details.
> >
> > BTW, let me use this mail to also add the report to the list of tracked
> > regressions to ensure it's doesn't fall through the cracks:
> >
> > #regzbot introduced: c34db0d6b88b1d
> > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> > #regzbot title: sound: asoc: sudden sound disappearance
> > #regzbot ignore-activity
>
> FWIW, we had as well reports in Debian after having updated the kernel
> from 5.10.149 based one to 5.10.158 based one in the last point
> releases, they are at least:
>
> https://bugs.debian.org/1027483
> https://bugs.debian.org/1027430
I got another report while the commit was backported to 5.14-based
openSUSE Leap kernel, and I ended up with dropping it.
So, IMO, it's safer to drop this patch from the older stable trees.
As far as I see, 5.15.y and 5.10.y got this.
Unless anyone gives a better fix, I'm going to submit a revert patch
for those trees.
thanks,
Takashi
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
@ 2023-01-02 12:42 ` Takashi Iwai
0 siblings, 0 replies; 19+ messages in thread
From: Takashi Iwai @ 2023-01-02 12:42 UTC (permalink / raw)
To: Salvatore Bonaccorso
Cc: Alsa-devel, regressions, Mark Brown, Takashi Iwai, LKML,
Richard Fitzgerald, Thorsten Leemhuis, PÁLFFY Dániel,
Sergey
On Mon, 02 Jan 2023 11:43:36 +0100,
Salvatore Bonaccorso wrote:
>
> Hi,
>
> [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
>
> On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> > Hi, this is your Linux kernel regression tracker speaking.
> >
> > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > kernel developer don't keep an eye on it, I decided to forward it by
> > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> >
> > > Sergey 2022-12-29 10:07:51 UTC
> > >
> > > Created attachment 303497 [details]
> > > pulseaudio.log
> > >
> > > Sudden sound disappearance was reported for some laptops, e.g.
> > >
> > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> > >
> > > # lspci
> > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > > Subsystem: Acer Incorporated [ALI] Device 148c
> > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > > Capabilities: [50] Power Management version 3
> > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > > Kernel driver in use: sof-audio-pci
> > >
> > > I am attaching the pulseaudio and dmesg logs
> > >
> > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> > >
> > > Bisection revealed the commit being reverted:
> > >
> > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > > Date: Fri Nov 4 13:22:13 2022 +0000
> > >
> > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> > >
> > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> > >
> > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > > and used by later code that depends on the TDM settings. So
> > > __soc_pcm_open() should not be obliterating those mask values.
> > >
> > > [...]
> > > Original bug report: https://bugzilla.altlinux.org/44690
> >
> > See the ticket for more details.
> >
> > BTW, let me use this mail to also add the report to the list of tracked
> > regressions to ensure it's doesn't fall through the cracks:
> >
> > #regzbot introduced: c34db0d6b88b1d
> > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> > #regzbot title: sound: asoc: sudden sound disappearance
> > #regzbot ignore-activity
>
> FWIW, we had as well reports in Debian after having updated the kernel
> from 5.10.149 based one to 5.10.158 based one in the last point
> releases, they are at least:
>
> https://bugs.debian.org/1027483
> https://bugs.debian.org/1027430
I got another report while the commit was backported to 5.14-based
openSUSE Leap kernel, and I ended up with dropping it.
So, IMO, it's safer to drop this patch from the older stable trees.
As far as I see, 5.15.y and 5.10.y got this.
Unless anyone gives a better fix, I'm going to submit a revert patch
for those trees.
thanks,
Takashi
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
2023-01-02 12:42 ` Takashi Iwai
(?)
@ 2023-01-03 12:05 ` PÁLFFY Dániel
2023-01-03 13:04 ` PÁLFFY Dániel
-1 siblings, 1 reply; 19+ messages in thread
From: PÁLFFY Dániel @ 2023-01-03 12:05 UTC (permalink / raw)
To: Takashi Iwai
Cc: Alsa-devel, regressions, Mark Brown, LKML, Takashi Iwai,
Richard Fitzgerald, Thorsten Leemhuis, Sergey,
Salvatore Bonaccorso
Another report: https://bugs.archlinux.org/task/76795
Apparently, folks at alsa-devel traced down the dependencies of that patch,
see the mail thread at
https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> On Mon, 02 Jan 2023 11:43:36 +0100,
> Salvatore Bonaccorso wrote:
> >
> > Hi,
> >
> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
> >
> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> > > Hi, this is your Linux kernel regression tracker speaking.
> > >
> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > > kernel developer don't keep an eye on it, I decided to forward it by
> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861
> :
> > >
> > > > Sergey 2022-12-29 10:07:51 UTC
> > > >
> > > > Created attachment 303497 [details]
> > > > pulseaudio.log
> > > >
> > > > Sudden sound disappearance was reported for some laptops, e.g.
> > > >
> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @
> 2.80GHz
> > > >
> > > > # lspci
> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger
> Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > > > Subsystem: Acer Incorporated [ALI] Device 148c
> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU
> group 12
> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > > > Capabilities: [50] Power Management version 3
> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > > > Kernel driver in use: sof-audio-pci
> > > >
> > > > I am attaching the pulseaudio and dmesg logs
> > > >
> > > > This bug started reproducing after updating the kernel from 5.10.156
> to 5.10.157
> > > >
> > > > Bisection revealed the commit being reverted:
> > > >
> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > > > Date: Fri Nov 4 13:22:13 2022 +0000
> > > >
> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> > > >
> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> > > >
> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > > > and used by later code that depends on the TDM settings. So
> > > > __soc_pcm_open() should not be obliterating those mask values.
> > > >
> > > > [...]
> > > > Original bug report: https://bugzilla.altlinux.org/44690
> > >
> > > See the ticket for more details.
> > >
> > > BTW, let me use this mail to also add the report to the list of tracked
> > > regressions to ensure it's doesn't fall through the cracks:
> > >
> > > #regzbot introduced: c34db0d6b88b1d
> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> > > #regzbot title: sound: asoc: sudden sound disappearance
> > > #regzbot ignore-activity
> >
> > FWIW, we had as well reports in Debian after having updated the kernel
> > from 5.10.149 based one to 5.10.158 based one in the last point
> > releases, they are at least:
> >
> > https://bugs.debian.org/1027483
> > https://bugs.debian.org/1027430
>
> I got another report while the commit was backported to 5.14-based
> openSUSE Leap kernel, and I ended up with dropping it.
>
> So, IMO, it's safer to drop this patch from the older stable trees.
> As far as I see, 5.15.y and 5.10.y got this.
>
> Unless anyone gives a better fix, I'm going to submit a revert patch
> for those trees.
>
>
> thanks,
>
> Takashi
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
2023-01-03 12:05 ` PÁLFFY Dániel
@ 2023-01-03 13:04 ` PÁLFFY Dániel
0 siblings, 0 replies; 19+ messages in thread
From: PÁLFFY Dániel @ 2023-01-03 13:04 UTC (permalink / raw)
To: Takashi Iwai
Cc: Salvatore Bonaccorso, Thorsten Leemhuis, Alsa-devel, regressions,
LKML, Takashi Iwai, Richard Fitzgerald, Mark Brown, Sergey
And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
me.
On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
>
> Another report: https://bugs.archlinux.org/task/76795
> Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
>
> On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
>>
>> On Mon, 02 Jan 2023 11:43:36 +0100,
>> Salvatore Bonaccorso wrote:
>> >
>> > Hi,
>> >
>> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
>> >
>> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
>> > > Hi, this is your Linux kernel regression tracker speaking.
>> > >
>> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
>> > > kernel developer don't keep an eye on it, I decided to forward it by
>> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
>> > >
>> > > > Sergey 2022-12-29 10:07:51 UTC
>> > > >
>> > > > Created attachment 303497 [details]
>> > > > pulseaudio.log
>> > > >
>> > > > Sudden sound disappearance was reported for some laptops, e.g.
>> > > >
>> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
>> > > >
>> > > > # lspci
>> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
>> > > > Subsystem: Acer Incorporated [ALI] Device 148c
>> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
>> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
>> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
>> > > > Capabilities: [50] Power Management version 3
>> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
>> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
>> > > > Kernel driver in use: sof-audio-pci
>> > > >
>> > > > I am attaching the pulseaudio and dmesg logs
>> > > >
>> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
>> > > >
>> > > > Bisection revealed the commit being reverted:
>> > > >
>> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
>> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
>> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
>> > > > Date: Fri Nov 4 13:22:13 2022 +0000
>> > > >
>> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
>> > > >
>> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
>> > > >
>> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
>> > > > and used by later code that depends on the TDM settings. So
>> > > > __soc_pcm_open() should not be obliterating those mask values.
>> > > >
>> > > > [...]
>> > > > Original bug report: https://bugzilla.altlinux.org/44690
>> > >
>> > > See the ticket for more details.
>> > >
>> > > BTW, let me use this mail to also add the report to the list of tracked
>> > > regressions to ensure it's doesn't fall through the cracks:
>> > >
>> > > #regzbot introduced: c34db0d6b88b1d
>> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
>> > > #regzbot title: sound: asoc: sudden sound disappearance
>> > > #regzbot ignore-activity
>> >
>> > FWIW, we had as well reports in Debian after having updated the kernel
>> > from 5.10.149 based one to 5.10.158 based one in the last point
>> > releases, they are at least:
>> >
>> > https://bugs.debian.org/1027483
>> > https://bugs.debian.org/1027430
>>
>> I got another report while the commit was backported to 5.14-based
>> openSUSE Leap kernel, and I ended up with dropping it.
>>
>> So, IMO, it's safer to drop this patch from the older stable trees.
>> As far as I see, 5.15.y and 5.10.y got this.
>>
>> Unless anyone gives a better fix, I'm going to submit a revert patch
>> for those trees.
>>
>>
>> thanks,
>>
>> Takashi
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
@ 2023-01-03 13:04 ` PÁLFFY Dániel
0 siblings, 0 replies; 19+ messages in thread
From: PÁLFFY Dániel @ 2023-01-03 13:04 UTC (permalink / raw)
To: Takashi Iwai
Cc: Alsa-devel, regressions, Mark Brown, LKML, Takashi Iwai,
Richard Fitzgerald, Thorsten Leemhuis, Sergey,
Salvatore Bonaccorso
And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
me.
On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
>
> Another report: https://bugs.archlinux.org/task/76795
> Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
>
> On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
>>
>> On Mon, 02 Jan 2023 11:43:36 +0100,
>> Salvatore Bonaccorso wrote:
>> >
>> > Hi,
>> >
>> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
>> >
>> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
>> > > Hi, this is your Linux kernel regression tracker speaking.
>> > >
>> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
>> > > kernel developer don't keep an eye on it, I decided to forward it by
>> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
>> > >
>> > > > Sergey 2022-12-29 10:07:51 UTC
>> > > >
>> > > > Created attachment 303497 [details]
>> > > > pulseaudio.log
>> > > >
>> > > > Sudden sound disappearance was reported for some laptops, e.g.
>> > > >
>> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
>> > > >
>> > > > # lspci
>> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
>> > > > Subsystem: Acer Incorporated [ALI] Device 148c
>> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
>> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
>> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
>> > > > Capabilities: [50] Power Management version 3
>> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
>> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
>> > > > Kernel driver in use: sof-audio-pci
>> > > >
>> > > > I am attaching the pulseaudio and dmesg logs
>> > > >
>> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
>> > > >
>> > > > Bisection revealed the commit being reverted:
>> > > >
>> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
>> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
>> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
>> > > > Date: Fri Nov 4 13:22:13 2022 +0000
>> > > >
>> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
>> > > >
>> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
>> > > >
>> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
>> > > > and used by later code that depends on the TDM settings. So
>> > > > __soc_pcm_open() should not be obliterating those mask values.
>> > > >
>> > > > [...]
>> > > > Original bug report: https://bugzilla.altlinux.org/44690
>> > >
>> > > See the ticket for more details.
>> > >
>> > > BTW, let me use this mail to also add the report to the list of tracked
>> > > regressions to ensure it's doesn't fall through the cracks:
>> > >
>> > > #regzbot introduced: c34db0d6b88b1d
>> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
>> > > #regzbot title: sound: asoc: sudden sound disappearance
>> > > #regzbot ignore-activity
>> >
>> > FWIW, we had as well reports in Debian after having updated the kernel
>> > from 5.10.149 based one to 5.10.158 based one in the last point
>> > releases, they are at least:
>> >
>> > https://bugs.debian.org/1027483
>> > https://bugs.debian.org/1027430
>>
>> I got another report while the commit was backported to 5.14-based
>> openSUSE Leap kernel, and I ended up with dropping it.
>>
>> So, IMO, it's safer to drop this patch from the older stable trees.
>> As far as I see, 5.15.y and 5.10.y got this.
>>
>> Unless anyone gives a better fix, I'm going to submit a revert patch
>> for those trees.
>>
>>
>> thanks,
>>
>> Takashi
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
2023-01-03 13:04 ` PÁLFFY Dániel
@ 2023-01-03 14:48 ` Takashi Iwai
-1 siblings, 0 replies; 19+ messages in thread
From: Takashi Iwai @ 2023-01-03 14:48 UTC (permalink / raw)
To: PÁLFFY Dániel
Cc: Alsa-devel, regressions, Mark Brown, LKML, Takashi Iwai,
Richard Fitzgerald, Thorsten Leemhuis, Sergey,
Salvatore Bonaccorso
On Tue, 03 Jan 2023 14:04:50 +0100,
PÁLFFY Dániel wrote:
>
> And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
> and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
> me.
That's a good news. Then we can ask stable people to pick up those
commits for 5.10.y and 5.15.y.
Takashi
>
> On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
> >
> > Another report: https://bugs.archlinux.org/task/76795
> > Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
> >
> > On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> >>
> >> On Mon, 02 Jan 2023 11:43:36 +0100,
> >> Salvatore Bonaccorso wrote:
> >> >
> >> > Hi,
> >> >
> >> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
> >> >
> >> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> >> > > Hi, this is your Linux kernel regression tracker speaking.
> >> > >
> >> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> >> > > kernel developer don't keep an eye on it, I decided to forward it by
> >> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> >> > >
> >> > > > Sergey 2022-12-29 10:07:51 UTC
> >> > > >
> >> > > > Created attachment 303497 [details]
> >> > > > pulseaudio.log
> >> > > >
> >> > > > Sudden sound disappearance was reported for some laptops, e.g.
> >> > > >
> >> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> >> > > >
> >> > > > # lspci
> >> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> >> > > > Subsystem: Acer Incorporated [ALI] Device 148c
> >> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> >> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> >> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> >> > > > Capabilities: [50] Power Management version 3
> >> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> >> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> >> > > > Kernel driver in use: sof-audio-pci
> >> > > >
> >> > > > I am attaching the pulseaudio and dmesg logs
> >> > > >
> >> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> >> > > >
> >> > > > Bisection revealed the commit being reverted:
> >> > > >
> >> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> >> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> >> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> >> > > > Date: Fri Nov 4 13:22:13 2022 +0000
> >> > > >
> >> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> >> > > >
> >> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> >> > > >
> >> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> >> > > > and used by later code that depends on the TDM settings. So
> >> > > > __soc_pcm_open() should not be obliterating those mask values.
> >> > > >
> >> > > > [...]
> >> > > > Original bug report: https://bugzilla.altlinux.org/44690
> >> > >
> >> > > See the ticket for more details.
> >> > >
> >> > > BTW, let me use this mail to also add the report to the list of tracked
> >> > > regressions to ensure it's doesn't fall through the cracks:
> >> > >
> >> > > #regzbot introduced: c34db0d6b88b1d
> >> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> >> > > #regzbot title: sound: asoc: sudden sound disappearance
> >> > > #regzbot ignore-activity
> >> >
> >> > FWIW, we had as well reports in Debian after having updated the kernel
> >> > from 5.10.149 based one to 5.10.158 based one in the last point
> >> > releases, they are at least:
> >> >
> >> > https://bugs.debian.org/1027483
> >> > https://bugs.debian.org/1027430
> >>
> >> I got another report while the commit was backported to 5.14-based
> >> openSUSE Leap kernel, and I ended up with dropping it.
> >>
> >> So, IMO, it's safer to drop this patch from the older stable trees.
> >> As far as I see, 5.15.y and 5.10.y got this.
> >>
> >> Unless anyone gives a better fix, I'm going to submit a revert patch
> >> for those trees.
> >>
> >>
> >> thanks,
> >>
> >> Takashi
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
@ 2023-01-03 14:48 ` Takashi Iwai
0 siblings, 0 replies; 19+ messages in thread
From: Takashi Iwai @ 2023-01-03 14:48 UTC (permalink / raw)
To: PÁLFFY Dániel
Cc: Alsa-devel, regressions, Thorsten Leemhuis, Takashi Iwai, LKML,
Richard Fitzgerald, Mark Brown, Salvatore Bonaccorso, Sergey
On Tue, 03 Jan 2023 14:04:50 +0100,
PÁLFFY Dániel wrote:
>
> And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
> and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
> me.
That's a good news. Then we can ask stable people to pick up those
commits for 5.10.y and 5.15.y.
Takashi
>
> On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
> >
> > Another report: https://bugs.archlinux.org/task/76795
> > Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
> >
> > On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> >>
> >> On Mon, 02 Jan 2023 11:43:36 +0100,
> >> Salvatore Bonaccorso wrote:
> >> >
> >> > Hi,
> >> >
> >> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
> >> >
> >> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> >> > > Hi, this is your Linux kernel regression tracker speaking.
> >> > >
> >> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> >> > > kernel developer don't keep an eye on it, I decided to forward it by
> >> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> >> > >
> >> > > > Sergey 2022-12-29 10:07:51 UTC
> >> > > >
> >> > > > Created attachment 303497 [details]
> >> > > > pulseaudio.log
> >> > > >
> >> > > > Sudden sound disappearance was reported for some laptops, e.g.
> >> > > >
> >> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> >> > > >
> >> > > > # lspci
> >> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> >> > > > Subsystem: Acer Incorporated [ALI] Device 148c
> >> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> >> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> >> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> >> > > > Capabilities: [50] Power Management version 3
> >> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> >> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> >> > > > Kernel driver in use: sof-audio-pci
> >> > > >
> >> > > > I am attaching the pulseaudio and dmesg logs
> >> > > >
> >> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> >> > > >
> >> > > > Bisection revealed the commit being reverted:
> >> > > >
> >> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> >> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> >> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> >> > > > Date: Fri Nov 4 13:22:13 2022 +0000
> >> > > >
> >> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> >> > > >
> >> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> >> > > >
> >> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> >> > > > and used by later code that depends on the TDM settings. So
> >> > > > __soc_pcm_open() should not be obliterating those mask values.
> >> > > >
> >> > > > [...]
> >> > > > Original bug report: https://bugzilla.altlinux.org/44690
> >> > >
> >> > > See the ticket for more details.
> >> > >
> >> > > BTW, let me use this mail to also add the report to the list of tracked
> >> > > regressions to ensure it's doesn't fall through the cracks:
> >> > >
> >> > > #regzbot introduced: c34db0d6b88b1d
> >> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> >> > > #regzbot title: sound: asoc: sudden sound disappearance
> >> > > #regzbot ignore-activity
> >> >
> >> > FWIW, we had as well reports in Debian after having updated the kernel
> >> > from 5.10.149 based one to 5.10.158 based one in the last point
> >> > releases, they are at least:
> >> >
> >> > https://bugs.debian.org/1027483
> >> > https://bugs.debian.org/1027430
> >>
> >> I got another report while the commit was backported to 5.14-based
> >> openSUSE Leap kernel, and I ended up with dropping it.
> >>
> >> So, IMO, it's safer to drop this patch from the older stable trees.
> >> As far as I see, 5.15.y and 5.10.y got this.
> >>
> >> Unless anyone gives a better fix, I'm going to submit a revert patch
> >> for those trees.
> >>
> >>
> >> thanks,
> >>
> >> Takashi
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
2023-01-03 14:48 ` Takashi Iwai
@ 2023-01-03 16:26 ` Takashi Iwai
-1 siblings, 0 replies; 19+ messages in thread
From: Takashi Iwai @ 2023-01-03 16:26 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, PÁLFFY Dániel, Alsa-devel, regressions,
Mark Brown, LKML, Takashi Iwai, Richard Fitzgerald,
Thorsten Leemhuis, Sergey, Salvatore Bonaccorso
On Tue, 03 Jan 2023 15:48:41 +0100,
Takashi Iwai wrote:
>
> On Tue, 03 Jan 2023 14:04:50 +0100,
> PÁLFFY Dániel wrote:
> >
> > And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
> > and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
> > me.
>
> That's a good news. Then we can ask stable people to pick up those
> commits for 5.10.y and 5.15.y.
I confirmed that the latest 5.15.y requires those fixes, too.
Greg, could you cherry-pick the following two commits to both 5.10.y
and 5.15.y stable trees? This fixes the recent regression caused by
the backport of 39bd801d6908.
e8444560b4d9302a511f0996f4cfdf85b628f4ca
ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
636110411ca726f19ef8e87b0be51bb9a4cdef06
ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
Thanks!
Takashi
>
>
> Takashi
>
> >
> > On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
> > >
> > > Another report: https://bugs.archlinux.org/task/76795
> > > Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
> > >
> > > On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> > >>
> > >> On Mon, 02 Jan 2023 11:43:36 +0100,
> > >> Salvatore Bonaccorso wrote:
> > >> >
> > >> > Hi,
> > >> >
> > >> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
> > >> >
> > >> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> > >> > > Hi, this is your Linux kernel regression tracker speaking.
> > >> > >
> > >> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > >> > > kernel developer don't keep an eye on it, I decided to forward it by
> > >> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> > >> > >
> > >> > > > Sergey 2022-12-29 10:07:51 UTC
> > >> > > >
> > >> > > > Created attachment 303497 [details]
> > >> > > > pulseaudio.log
> > >> > > >
> > >> > > > Sudden sound disappearance was reported for some laptops, e.g.
> > >> > > >
> > >> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> > >> > > >
> > >> > > > # lspci
> > >> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > >> > > > Subsystem: Acer Incorporated [ALI] Device 148c
> > >> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> > >> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > >> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > >> > > > Capabilities: [50] Power Management version 3
> > >> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > >> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > >> > > > Kernel driver in use: sof-audio-pci
> > >> > > >
> > >> > > > I am attaching the pulseaudio and dmesg logs
> > >> > > >
> > >> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> > >> > > >
> > >> > > > Bisection revealed the commit being reverted:
> > >> > > >
> > >> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > >> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > >> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > >> > > > Date: Fri Nov 4 13:22:13 2022 +0000
> > >> > > >
> > >> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> > >> > > >
> > >> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> > >> > > >
> > >> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > >> > > > and used by later code that depends on the TDM settings. So
> > >> > > > __soc_pcm_open() should not be obliterating those mask values.
> > >> > > >
> > >> > > > [...]
> > >> > > > Original bug report: https://bugzilla.altlinux.org/44690
> > >> > >
> > >> > > See the ticket for more details.
> > >> > >
> > >> > > BTW, let me use this mail to also add the report to the list of tracked
> > >> > > regressions to ensure it's doesn't fall through the cracks:
> > >> > >
> > >> > > #regzbot introduced: c34db0d6b88b1d
> > >> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> > >> > > #regzbot title: sound: asoc: sudden sound disappearance
> > >> > > #regzbot ignore-activity
> > >> >
> > >> > FWIW, we had as well reports in Debian after having updated the kernel
> > >> > from 5.10.149 based one to 5.10.158 based one in the last point
> > >> > releases, they are at least:
> > >> >
> > >> > https://bugs.debian.org/1027483
> > >> > https://bugs.debian.org/1027430
> > >>
> > >> I got another report while the commit was backported to 5.14-based
> > >> openSUSE Leap kernel, and I ended up with dropping it.
> > >>
> > >> So, IMO, it's safer to drop this patch from the older stable trees.
> > >> As far as I see, 5.15.y and 5.10.y got this.
> > >>
> > >> Unless anyone gives a better fix, I'm going to submit a revert patch
> > >> for those trees.
> > >>
> > >>
> > >> thanks,
> > >>
> > >> Takashi
> >
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157
@ 2023-01-03 16:26 ` Takashi Iwai
0 siblings, 0 replies; 19+ messages in thread
From: Takashi Iwai @ 2023-01-03 16:26 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alsa-devel, regressions, Thorsten Leemhuis, LKML, stable,
Takashi Iwai, Richard Fitzgerald, Mark Brown,
PÁLFFY Dániel, Salvatore Bonaccorso, Sergey
On Tue, 03 Jan 2023 15:48:41 +0100,
Takashi Iwai wrote:
>
> On Tue, 03 Jan 2023 14:04:50 +0100,
> PÁLFFY Dániel wrote:
> >
> > And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
> > and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
> > me.
>
> That's a good news. Then we can ask stable people to pick up those
> commits for 5.10.y and 5.15.y.
I confirmed that the latest 5.15.y requires those fixes, too.
Greg, could you cherry-pick the following two commits to both 5.10.y
and 5.15.y stable trees? This fixes the recent regression caused by
the backport of 39bd801d6908.
e8444560b4d9302a511f0996f4cfdf85b628f4ca
ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
636110411ca726f19ef8e87b0be51bb9a4cdef06
ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
Thanks!
Takashi
>
>
> Takashi
>
> >
> > On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
> > >
> > > Another report: https://bugs.archlinux.org/task/76795
> > > Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
> > >
> > > On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> > >>
> > >> On Mon, 02 Jan 2023 11:43:36 +0100,
> > >> Salvatore Bonaccorso wrote:
> > >> >
> > >> > Hi,
> > >> >
> > >> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
> > >> >
> > >> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> > >> > > Hi, this is your Linux kernel regression tracker speaking.
> > >> > >
> > >> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > >> > > kernel developer don't keep an eye on it, I decided to forward it by
> > >> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> > >> > >
> > >> > > > Sergey 2022-12-29 10:07:51 UTC
> > >> > > >
> > >> > > > Created attachment 303497 [details]
> > >> > > > pulseaudio.log
> > >> > > >
> > >> > > > Sudden sound disappearance was reported for some laptops, e.g.
> > >> > > >
> > >> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> > >> > > >
> > >> > > > # lspci
> > >> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > >> > > > Subsystem: Acer Incorporated [ALI] Device 148c
> > >> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> > >> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > >> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > >> > > > Capabilities: [50] Power Management version 3
> > >> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > >> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > >> > > > Kernel driver in use: sof-audio-pci
> > >> > > >
> > >> > > > I am attaching the pulseaudio and dmesg logs
> > >> > > >
> > >> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> > >> > > >
> > >> > > > Bisection revealed the commit being reverted:
> > >> > > >
> > >> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > >> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > >> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > >> > > > Date: Fri Nov 4 13:22:13 2022 +0000
> > >> > > >
> > >> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> > >> > > >
> > >> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> > >> > > >
> > >> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > >> > > > and used by later code that depends on the TDM settings. So
> > >> > > > __soc_pcm_open() should not be obliterating those mask values.
> > >> > > >
> > >> > > > [...]
> > >> > > > Original bug report: https://bugzilla.altlinux.org/44690
> > >> > >
> > >> > > See the ticket for more details.
> > >> > >
> > >> > > BTW, let me use this mail to also add the report to the list of tracked
> > >> > > regressions to ensure it's doesn't fall through the cracks:
> > >> > >
> > >> > > #regzbot introduced: c34db0d6b88b1d
> > >> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> > >> > > #regzbot title: sound: asoc: sudden sound disappearance
> > >> > > #regzbot ignore-activity
> > >> >
> > >> > FWIW, we had as well reports in Debian after having updated the kernel
> > >> > from 5.10.149 based one to 5.10.158 based one in the last point
> > >> > releases, they are at least:
> > >> >
> > >> > https://bugs.debian.org/1027483
> > >> > https://bugs.debian.org/1027430
> > >>
> > >> I got another report while the commit was backported to 5.14-based
> > >> openSUSE Leap kernel, and I ended up with dropping it.
> > >>
> > >> So, IMO, it's safer to drop this patch from the older stable trees.
> > >> As far as I see, 5.15.y and 5.10.y got this.
> > >>
> > >> Unless anyone gives a better fix, I'm going to submit a revert patch
> > >> for those trees.
> > >>
> > >>
> > >> thanks,
> > >>
> > >> Takashi
> >
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Request for cherry-picks for sound (Re: [regression, 5.10.y] Bug 216861)
2023-01-03 16:26 ` Takashi Iwai
@ 2023-01-04 10:11 ` Takashi Iwai
-1 siblings, 0 replies; 19+ messages in thread
From: Takashi Iwai @ 2023-01-04 10:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, PÁLFFY Dániel, Alsa-devel, regressions,
Mark Brown, LKML, Takashi Iwai, Richard Fitzgerald,
Thorsten Leemhuis, Sergey, Salvatore Bonaccorso
Greg, just in case you missed my previous post.
Could you cherry-pick the following two commits to 5.10.y and 5.15.y
stable trees?
e8444560b4d9302a511f0996f4cfdf85b628f4ca
ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
636110411ca726f19ef8e87b0be51bb9a4cdef06
ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
Thanks!
Takashi
On Tue, 03 Jan 2023 17:26:49 +0100,
Takashi Iwai wrote:
>
> On Tue, 03 Jan 2023 15:48:41 +0100,
> Takashi Iwai wrote:
> >
> > On Tue, 03 Jan 2023 14:04:50 +0100,
> > PÁLFFY Dániel wrote:
> > >
> > > And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
> > > and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
> > > me.
> >
> > That's a good news. Then we can ask stable people to pick up those
> > commits for 5.10.y and 5.15.y.
>
> I confirmed that the latest 5.15.y requires those fixes, too.
>
> Greg, could you cherry-pick the following two commits to both 5.10.y
> and 5.15.y stable trees? This fixes the recent regression caused by
> the backport of 39bd801d6908.
>
> e8444560b4d9302a511f0996f4cfdf85b628f4ca
> ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
>
> 636110411ca726f19ef8e87b0be51bb9a4cdef06
> ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
>
>
> Thanks!
>
> Takashi
>
> >
> >
> > Takashi
> >
> > >
> > > On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
> > > >
> > > > Another report: https://bugs.archlinux.org/task/76795
> > > > Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
> > > >
> > > > On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> > > >>
> > > >> On Mon, 02 Jan 2023 11:43:36 +0100,
> > > >> Salvatore Bonaccorso wrote:
> > > >> >
> > > >> > Hi,
> > > >> >
> > > >> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
> > > >> >
> > > >> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> > > >> > > Hi, this is your Linux kernel regression tracker speaking.
> > > >> > >
> > > >> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > > >> > > kernel developer don't keep an eye on it, I decided to forward it by
> > > >> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> > > >> > >
> > > >> > > > Sergey 2022-12-29 10:07:51 UTC
> > > >> > > >
> > > >> > > > Created attachment 303497 [details]
> > > >> > > > pulseaudio.log
> > > >> > > >
> > > >> > > > Sudden sound disappearance was reported for some laptops, e.g.
> > > >> > > >
> > > >> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> > > >> > > >
> > > >> > > > # lspci
> > > >> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > > >> > > > Subsystem: Acer Incorporated [ALI] Device 148c
> > > >> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> > > >> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > > >> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > > >> > > > Capabilities: [50] Power Management version 3
> > > >> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > > >> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > > >> > > > Kernel driver in use: sof-audio-pci
> > > >> > > >
> > > >> > > > I am attaching the pulseaudio and dmesg logs
> > > >> > > >
> > > >> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> > > >> > > >
> > > >> > > > Bisection revealed the commit being reverted:
> > > >> > > >
> > > >> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > > >> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > > >> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > > >> > > > Date: Fri Nov 4 13:22:13 2022 +0000
> > > >> > > >
> > > >> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> > > >> > > >
> > > >> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> > > >> > > >
> > > >> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > > >> > > > and used by later code that depends on the TDM settings. So
> > > >> > > > __soc_pcm_open() should not be obliterating those mask values.
> > > >> > > >
> > > >> > > > [...]
> > > >> > > > Original bug report: https://bugzilla.altlinux.org/44690
> > > >> > >
> > > >> > > See the ticket for more details.
> > > >> > >
> > > >> > > BTW, let me use this mail to also add the report to the list of tracked
> > > >> > > regressions to ensure it's doesn't fall through the cracks:
> > > >> > >
> > > >> > > #regzbot introduced: c34db0d6b88b1d
> > > >> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> > > >> > > #regzbot title: sound: asoc: sudden sound disappearance
> > > >> > > #regzbot ignore-activity
> > > >> >
> > > >> > FWIW, we had as well reports in Debian after having updated the kernel
> > > >> > from 5.10.149 based one to 5.10.158 based one in the last point
> > > >> > releases, they are at least:
> > > >> >
> > > >> > https://bugs.debian.org/1027483
> > > >> > https://bugs.debian.org/1027430
> > > >>
> > > >> I got another report while the commit was backported to 5.14-based
> > > >> openSUSE Leap kernel, and I ended up with dropping it.
> > > >>
> > > >> So, IMO, it's safer to drop this patch from the older stable trees.
> > > >> As far as I see, 5.15.y and 5.10.y got this.
> > > >>
> > > >> Unless anyone gives a better fix, I'm going to submit a revert patch
> > > >> for those trees.
> > > >>
> > > >>
> > > >> thanks,
> > > >>
> > > >> Takashi
> > >
> >
^ permalink raw reply [flat|nested] 19+ messages in thread
* Request for cherry-picks for sound (Re: [regression, 5.10.y] Bug 216861)
@ 2023-01-04 10:11 ` Takashi Iwai
0 siblings, 0 replies; 19+ messages in thread
From: Takashi Iwai @ 2023-01-04 10:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Alsa-devel, regressions, Thorsten Leemhuis, LKML, stable,
Takashi Iwai, Richard Fitzgerald, Mark Brown,
PÁLFFY Dániel, Salvatore Bonaccorso, Sergey
Greg, just in case you missed my previous post.
Could you cherry-pick the following two commits to 5.10.y and 5.15.y
stable trees?
e8444560b4d9302a511f0996f4cfdf85b628f4ca
ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
636110411ca726f19ef8e87b0be51bb9a4cdef06
ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
Thanks!
Takashi
On Tue, 03 Jan 2023 17:26:49 +0100,
Takashi Iwai wrote:
>
> On Tue, 03 Jan 2023 15:48:41 +0100,
> Takashi Iwai wrote:
> >
> > On Tue, 03 Jan 2023 14:04:50 +0100,
> > PÁLFFY Dániel wrote:
> > >
> > > And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
> > > and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
> > > me.
> >
> > That's a good news. Then we can ask stable people to pick up those
> > commits for 5.10.y and 5.15.y.
>
> I confirmed that the latest 5.15.y requires those fixes, too.
>
> Greg, could you cherry-pick the following two commits to both 5.10.y
> and 5.15.y stable trees? This fixes the recent regression caused by
> the backport of 39bd801d6908.
>
> e8444560b4d9302a511f0996f4cfdf85b628f4ca
> ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
>
> 636110411ca726f19ef8e87b0be51bb9a4cdef06
> ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
>
>
> Thanks!
>
> Takashi
>
> >
> >
> > Takashi
> >
> > >
> > > On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
> > > >
> > > > Another report: https://bugs.archlinux.org/task/76795
> > > > Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
> > > >
> > > > On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> > > >>
> > > >> On Mon, 02 Jan 2023 11:43:36 +0100,
> > > >> Salvatore Bonaccorso wrote:
> > > >> >
> > > >> > Hi,
> > > >> >
> > > >> > [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
> > > >> >
> > > >> > On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
> > > >> > > Hi, this is your Linux kernel regression tracker speaking.
> > > >> > >
> > > >> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > > >> > > kernel developer don't keep an eye on it, I decided to forward it by
> > > >> > > mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
> > > >> > >
> > > >> > > > Sergey 2022-12-29 10:07:51 UTC
> > > >> > > >
> > > >> > > > Created attachment 303497 [details]
> > > >> > > > pulseaudio.log
> > > >> > > >
> > > >> > > > Sudden sound disappearance was reported for some laptops, e.g.
> > > >> > > >
> > > >> > > > Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
> > > >> > > >
> > > >> > > > # lspci
> > > >> > > > 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
> > > >> > > > Subsystem: Acer Incorporated [ALI] Device 148c
> > > >> > > > Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
> > > >> > > > Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
> > > >> > > > Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
> > > >> > > > Capabilities: [50] Power Management version 3
> > > >> > > > Capabilities: [80] Vendor Specific Information: Len=14 <?>
> > > >> > > > Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > > >> > > > Kernel driver in use: sof-audio-pci
> > > >> > > >
> > > >> > > > I am attaching the pulseaudio and dmesg logs
> > > >> > > >
> > > >> > > > This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
> > > >> > > >
> > > >> > > > Bisection revealed the commit being reverted:
> > > >> > > >
> > > >> > > > c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
> > > >> > > > commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
> > > >> > > > Author: Richard Fitzgerald <rf@opensource.cirrus.com>
> > > >> > > > Date: Fri Nov 4 13:22:13 2022 +0000
> > > >> > > >
> > > >> > > > ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
> > > >> > > >
> > > >> > > > [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
> > > >> > > >
> > > >> > > > The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
> > > >> > > > and used by later code that depends on the TDM settings. So
> > > >> > > > __soc_pcm_open() should not be obliterating those mask values.
> > > >> > > >
> > > >> > > > [...]
> > > >> > > > Original bug report: https://bugzilla.altlinux.org/44690
> > > >> > >
> > > >> > > See the ticket for more details.
> > > >> > >
> > > >> > > BTW, let me use this mail to also add the report to the list of tracked
> > > >> > > regressions to ensure it's doesn't fall through the cracks:
> > > >> > >
> > > >> > > #regzbot introduced: c34db0d6b88b1d
> > > >> > > https://bugzilla.kernel.org/show_bug.cgi?id=216861
> > > >> > > #regzbot title: sound: asoc: sudden sound disappearance
> > > >> > > #regzbot ignore-activity
> > > >> >
> > > >> > FWIW, we had as well reports in Debian after having updated the kernel
> > > >> > from 5.10.149 based one to 5.10.158 based one in the last point
> > > >> > releases, they are at least:
> > > >> >
> > > >> > https://bugs.debian.org/1027483
> > > >> > https://bugs.debian.org/1027430
> > > >>
> > > >> I got another report while the commit was backported to 5.14-based
> > > >> openSUSE Leap kernel, and I ended up with dropping it.
> > > >>
> > > >> So, IMO, it's safer to drop this patch from the older stable trees.
> > > >> As far as I see, 5.15.y and 5.10.y got this.
> > > >>
> > > >> Unless anyone gives a better fix, I'm going to submit a revert patch
> > > >> for those trees.
> > > >>
> > > >>
> > > >> thanks,
> > > >>
> > > >> Takashi
> > >
> >
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Request for cherry-picks for sound (Re: [regression, 5.10.y] Bug 216861)
2023-01-04 10:11 ` Takashi Iwai
@ 2023-01-04 10:35 ` Linux kernel regression tracking (#info)
-1 siblings, 0 replies; 19+ messages in thread
From: Linux kernel regression tracking (#info) @ 2023-01-04 10:35 UTC (permalink / raw)
To: Takashi Iwai, Greg Kroah-Hartman
Cc: stable, PÁLFFY Dániel, Alsa-devel, regressions,
Mark Brown, LKML, Takashi Iwai, Richard Fitzgerald, Sergey,
Salvatore Bonaccorso
[TLDR: This mail in primarily relevant for Linux kernel regression
tracking. See link in footer if these mails annoy you.]
On 04.01.23 11:11, Takashi Iwai wrote:
> Greg, just in case you missed my previous post.
Side note: thx for handling this, Takashi!
> Could you cherry-pick the following two commits to 5.10.y and 5.15.y
> stable trees?
>
> e8444560b4d9302a511f0996f4cfdf85b628f4ca
> ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
>
> 636110411ca726f19ef8e87b0be51bb9a4cdef06
> ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
#regzbot fix: ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
/me just picked one of them as the fix for the tracked regression, even
if both are needed, as that's likely close enough, unless something
really unexpected happens
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> On Tue, 03 Jan 2023 17:26:49 +0100,
> Takashi Iwai wrote:
>>
>> On Tue, 03 Jan 2023 15:48:41 +0100,
>> Takashi Iwai wrote:
>>>
>>> On Tue, 03 Jan 2023 14:04:50 +0100,
>>> PÁLFFY Dániel wrote:
>>>>
>>>> And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
>>>> and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
>>>> me.
>>>
>>> That's a good news. Then we can ask stable people to pick up those
>>> commits for 5.10.y and 5.15.y.
>>
>> I confirmed that the latest 5.15.y requires those fixes, too.
>>
>> Greg, could you cherry-pick the following two commits to both 5.10.y
>> and 5.15.y stable trees? This fixes the recent regression caused by
>> the backport of 39bd801d6908.
>>
>> e8444560b4d9302a511f0996f4cfdf85b628f4ca
>> ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
>>
>> 636110411ca726f19ef8e87b0be51bb9a4cdef06
>> ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
>>
>>
>> Thanks!
>>
>> Takashi
>>
>>>
>>>
>>> Takashi
>>>
>>>>
>>>> On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
>>>>>
>>>>> Another report: https://bugs.archlinux.org/task/76795
>>>>> Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
>>>>>
>>>>> On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
>>>>>>
>>>>>> On Mon, 02 Jan 2023 11:43:36 +0100,
>>>>>> Salvatore Bonaccorso wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
>>>>>>>
>>>>>>> On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
>>>>>>>> Hi, this is your Linux kernel regression tracker speaking.
>>>>>>>>
>>>>>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>>>>>>>> kernel developer don't keep an eye on it, I decided to forward it by
>>>>>>>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
>>>>>>>>
>>>>>>>>> Sergey 2022-12-29 10:07:51 UTC
>>>>>>>>>
>>>>>>>>> Created attachment 303497 [details]
>>>>>>>>> pulseaudio.log
>>>>>>>>>
>>>>>>>>> Sudden sound disappearance was reported for some laptops, e.g.
>>>>>>>>>
>>>>>>>>> Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
>>>>>>>>>
>>>>>>>>> # lspci
>>>>>>>>> 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
>>>>>>>>> Subsystem: Acer Incorporated [ALI] Device 148c
>>>>>>>>> Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
>>>>>>>>> Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
>>>>>>>>> Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
>>>>>>>>> Capabilities: [50] Power Management version 3
>>>>>>>>> Capabilities: [80] Vendor Specific Information: Len=14 <?>
>>>>>>>>> Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
>>>>>>>>> Kernel driver in use: sof-audio-pci
>>>>>>>>>
>>>>>>>>> I am attaching the pulseaudio and dmesg logs
>>>>>>>>>
>>>>>>>>> This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
>>>>>>>>>
>>>>>>>>> Bisection revealed the commit being reverted:
>>>>>>>>>
>>>>>>>>> c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
>>>>>>>>> commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
>>>>>>>>> Author: Richard Fitzgerald <rf@opensource.cirrus.com>
>>>>>>>>> Date: Fri Nov 4 13:22:13 2022 +0000
>>>>>>>>>
>>>>>>>>> ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
>>>>>>>>>
>>>>>>>>> [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
>>>>>>>>>
>>>>>>>>> The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
>>>>>>>>> and used by later code that depends on the TDM settings. So
>>>>>>>>> __soc_pcm_open() should not be obliterating those mask values.
>>>>>>>>>
>>>>>>>>> [...]
>>>>>>>>> Original bug report: https://bugzilla.altlinux.org/44690
>>>>>>>>
>>>>>>>> See the ticket for more details.
>>>>>>>>
>>>>>>>> BTW, let me use this mail to also add the report to the list of tracked
>>>>>>>> regressions to ensure it's doesn't fall through the cracks:
>>>>>>>>
>>>>>>>> #regzbot introduced: c34db0d6b88b1d
>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=216861
>>>>>>>> #regzbot title: sound: asoc: sudden sound disappearance
>>>>>>>> #regzbot ignore-activity
>>>>>>>
>>>>>>> FWIW, we had as well reports in Debian after having updated the kernel
>>>>>>> from 5.10.149 based one to 5.10.158 based one in the last point
>>>>>>> releases, they are at least:
>>>>>>>
>>>>>>> https://bugs.debian.org/1027483
>>>>>>> https://bugs.debian.org/1027430
>>>>>>
>>>>>> I got another report while the commit was backported to 5.14-based
>>>>>> openSUSE Leap kernel, and I ended up with dropping it.
>>>>>>
>>>>>> So, IMO, it's safer to drop this patch from the older stable trees.
>>>>>> As far as I see, 5.15.y and 5.10.y got this.
>>>>>>
>>>>>> Unless anyone gives a better fix, I'm going to submit a revert patch
>>>>>> for those trees.
>>>>>>
>>>>>>
>>>>>> thanks,
>>>>>>
>>>>>> Takashi
>>>>
>>>
>
>
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Request for cherry-picks for sound (Re: [regression, 5.10.y] Bug 216861)
@ 2023-01-04 10:35 ` Linux kernel regression tracking (#info)
0 siblings, 0 replies; 19+ messages in thread
From: Linux kernel regression tracking (#info) @ 2023-01-04 10:35 UTC (permalink / raw)
To: Takashi Iwai, Greg Kroah-Hartman
Cc: Alsa-devel, regressions, LKML, stable, Takashi Iwai,
Richard Fitzgerald, Mark Brown, PÁLFFY Dániel,
Salvatore Bonaccorso, Sergey
[TLDR: This mail in primarily relevant for Linux kernel regression
tracking. See link in footer if these mails annoy you.]
On 04.01.23 11:11, Takashi Iwai wrote:
> Greg, just in case you missed my previous post.
Side note: thx for handling this, Takashi!
> Could you cherry-pick the following two commits to 5.10.y and 5.15.y
> stable trees?
>
> e8444560b4d9302a511f0996f4cfdf85b628f4ca
> ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
>
> 636110411ca726f19ef8e87b0be51bb9a4cdef06
> ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
#regzbot fix: ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
/me just picked one of them as the fix for the tracked regression, even
if both are needed, as that's likely close enough, unless something
really unexpected happens
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> On Tue, 03 Jan 2023 17:26:49 +0100,
> Takashi Iwai wrote:
>>
>> On Tue, 03 Jan 2023 15:48:41 +0100,
>> Takashi Iwai wrote:
>>>
>>> On Tue, 03 Jan 2023 14:04:50 +0100,
>>> PÁLFFY Dániel wrote:
>>>>
>>>> And confirming, 5.10.161 with e8444560b4d9302a511f0996f4cfdf85b628f4ca
>>>> and 636110411ca726f19ef8e87b0be51bb9a4cdef06 cherry-picked works for
>>>> me.
>>>
>>> That's a good news. Then we can ask stable people to pick up those
>>> commits for 5.10.y and 5.15.y.
>>
>> I confirmed that the latest 5.15.y requires those fixes, too.
>>
>> Greg, could you cherry-pick the following two commits to both 5.10.y
>> and 5.15.y stable trees? This fixes the recent regression caused by
>> the backport of 39bd801d6908.
>>
>> e8444560b4d9302a511f0996f4cfdf85b628f4ca
>> ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
>>
>> 636110411ca726f19ef8e87b0be51bb9a4cdef06
>> ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
>>
>>
>> Thanks!
>>
>> Takashi
>>
>>>
>>>
>>> Takashi
>>>
>>>>
>>>> On Tue, Jan 3, 2023 at 1:05 PM PÁLFFY Dániel <dpalffy@gmail.com> wrote:
>>>>>
>>>>> Another report: https://bugs.archlinux.org/task/76795
>>>>> Apparently, folks at alsa-devel traced down the dependencies of that patch, see the mail thread at https://lore.kernel.org/all/dc65501c-c2fd-5608-c3d9-7cea184c3989%40opensource.cirrus.com/
>>>>>
>>>>> On Mon, Jan 2, 2023 at 1:42 PM Takashi Iwai <tiwai@suse.de> wrote:
>>>>>>
>>>>>> On Mon, 02 Jan 2023 11:43:36 +0100,
>>>>>> Salvatore Bonaccorso wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> [Adding as well Richard Fitzgerald and PÁLFFY Dániel to recipients]
>>>>>>>
>>>>>>> On Fri, Dec 30, 2022 at 09:08:57AM +0100, Thorsten Leemhuis wrote:
>>>>>>>> Hi, this is your Linux kernel regression tracker speaking.
>>>>>>>>
>>>>>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>>>>>>>> kernel developer don't keep an eye on it, I decided to forward it by
>>>>>>>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216861 :
>>>>>>>>
>>>>>>>>> Sergey 2022-12-29 10:07:51 UTC
>>>>>>>>>
>>>>>>>>> Created attachment 303497 [details]
>>>>>>>>> pulseaudio.log
>>>>>>>>>
>>>>>>>>> Sudden sound disappearance was reported for some laptops, e.g.
>>>>>>>>>
>>>>>>>>> Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
>>>>>>>>>
>>>>>>>>> # lspci
>>>>>>>>> 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20)
>>>>>>>>> Subsystem: Acer Incorporated [ALI] Device 148c
>>>>>>>>> Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12
>>>>>>>>> Memory at 601f270000 (64-bit, non-prefetchable) [size=16K]
>>>>>>>>> Memory at 601f000000 (64-bit, non-prefetchable) [size=1M]
>>>>>>>>> Capabilities: [50] Power Management version 3
>>>>>>>>> Capabilities: [80] Vendor Specific Information: Len=14 <?>
>>>>>>>>> Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+
>>>>>>>>> Kernel driver in use: sof-audio-pci
>>>>>>>>>
>>>>>>>>> I am attaching the pulseaudio and dmesg logs
>>>>>>>>>
>>>>>>>>> This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157
>>>>>>>>>
>>>>>>>>> Bisection revealed the commit being reverted:
>>>>>>>>>
>>>>>>>>> c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit
>>>>>>>>> commit c34db0d6b88b1da95e7ab3353e674f4f574cccee
>>>>>>>>> Author: Richard Fitzgerald <rf@opensource.cirrus.com>
>>>>>>>>> Date: Fri Nov 4 13:22:13 2022 +0000
>>>>>>>>>
>>>>>>>>> ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open()
>>>>>>>>>
>>>>>>>>> [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ]
>>>>>>>>>
>>>>>>>>> The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot()
>>>>>>>>> and used by later code that depends on the TDM settings. So
>>>>>>>>> __soc_pcm_open() should not be obliterating those mask values.
>>>>>>>>>
>>>>>>>>> [...]
>>>>>>>>> Original bug report: https://bugzilla.altlinux.org/44690
>>>>>>>>
>>>>>>>> See the ticket for more details.
>>>>>>>>
>>>>>>>> BTW, let me use this mail to also add the report to the list of tracked
>>>>>>>> regressions to ensure it's doesn't fall through the cracks:
>>>>>>>>
>>>>>>>> #regzbot introduced: c34db0d6b88b1d
>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=216861
>>>>>>>> #regzbot title: sound: asoc: sudden sound disappearance
>>>>>>>> #regzbot ignore-activity
>>>>>>>
>>>>>>> FWIW, we had as well reports in Debian after having updated the kernel
>>>>>>> from 5.10.149 based one to 5.10.158 based one in the last point
>>>>>>> releases, they are at least:
>>>>>>>
>>>>>>> https://bugs.debian.org/1027483
>>>>>>> https://bugs.debian.org/1027430
>>>>>>
>>>>>> I got another report while the commit was backported to 5.14-based
>>>>>> openSUSE Leap kernel, and I ended up with dropping it.
>>>>>>
>>>>>> So, IMO, it's safer to drop this patch from the older stable trees.
>>>>>> As far as I see, 5.15.y and 5.10.y got this.
>>>>>>
>>>>>> Unless anyone gives a better fix, I'm going to submit a revert patch
>>>>>> for those trees.
>>>>>>
>>>>>>
>>>>>> thanks,
>>>>>>
>>>>>> Takashi
>>>>
>>>
>
>
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Request for cherry-picks for sound (Re: [regression, 5.10.y] Bug 216861)
2023-01-04 10:11 ` Takashi Iwai
@ 2023-01-04 11:31 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 19+ messages in thread
From: Greg Kroah-Hartman @ 2023-01-04 11:31 UTC (permalink / raw)
To: Takashi Iwai
Cc: stable, PÁLFFY Dániel, Alsa-devel, regressions,
Mark Brown, LKML, Takashi Iwai, Richard Fitzgerald,
Thorsten Leemhuis, Sergey, Salvatore Bonaccorso
On Wed, Jan 04, 2023 at 11:11:33AM +0100, Takashi Iwai wrote:
> Greg, just in case you missed my previous post.
>
> Could you cherry-pick the following two commits to 5.10.y and 5.15.y
> stable trees?
>
> e8444560b4d9302a511f0996f4cfdf85b628f4ca
> ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
>
> 636110411ca726f19ef8e87b0be51bb9a4cdef06
> ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
Took a bit of work, but both now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: Request for cherry-picks for sound (Re: [regression, 5.10.y] Bug 216861)
@ 2023-01-04 11:31 ` Greg Kroah-Hartman
0 siblings, 0 replies; 19+ messages in thread
From: Greg Kroah-Hartman @ 2023-01-04 11:31 UTC (permalink / raw)
To: Takashi Iwai
Cc: Alsa-devel, regressions, Thorsten Leemhuis, LKML, stable,
Takashi Iwai, Richard Fitzgerald, Mark Brown,
PÁLFFY Dániel, Salvatore Bonaccorso, Sergey
On Wed, Jan 04, 2023 at 11:11:33AM +0100, Takashi Iwai wrote:
> Greg, just in case you missed my previous post.
>
> Could you cherry-pick the following two commits to 5.10.y and 5.15.y
> stable trees?
>
> e8444560b4d9302a511f0996f4cfdf85b628f4ca
> ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire
>
> 636110411ca726f19ef8e87b0be51bb9a4cdef06
> ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio
Took a bit of work, but both now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2023-01-04 11:32 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-30 8:08 [regression, 5.10.y] Bug 216861 - sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157 Thorsten Leemhuis
2022-12-30 8:08 ` Thorsten Leemhuis
2023-01-02 10:43 ` Salvatore Bonaccorso
2023-01-02 10:43 ` Salvatore Bonaccorso
2023-01-02 12:42 ` Takashi Iwai
2023-01-02 12:42 ` Takashi Iwai
2023-01-03 12:05 ` PÁLFFY Dániel
2023-01-03 13:04 ` PÁLFFY Dániel
2023-01-03 13:04 ` PÁLFFY Dániel
2023-01-03 14:48 ` Takashi Iwai
2023-01-03 14:48 ` Takashi Iwai
2023-01-03 16:26 ` Takashi Iwai
2023-01-03 16:26 ` Takashi Iwai
2023-01-04 10:11 ` Request for cherry-picks for sound (Re: [regression, 5.10.y] Bug 216861) Takashi Iwai
2023-01-04 10:11 ` Takashi Iwai
2023-01-04 10:35 ` Linux kernel regression tracking (#info)
2023-01-04 10:35 ` Linux kernel regression tracking (#info)
2023-01-04 11:31 ` Greg Kroah-Hartman
2023-01-04 11:31 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.