Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup

["Daniel P. Smith" <dpsmith@apertussolutions.com>]

On 5/9/22 14:33, Julien Grall wrote:
> 
> 
> On 03/05/2022 14:17, Luca Fancellu wrote:
>>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
>>> index 0bf63ffa84..b93101191e 100644
>>> --- a/xen/xsm/flask/hooks.c
>>> +++ b/xen/xsm/flask/hooks.c
>>> @@ -186,6 +186,28 @@ static int cf_check
>>> flask_domain_alloc_security(struct domain *d)
>>>      return 0;
>>> }
>>>
>>> +static int cf_check flask_set_system_active(void)
>>> +{
>>> +    struct domain *d = current->domain;
>>> +
>>> +    ASSERT(d->is_privileged);
>>> +
>>> +    if ( d->domain_id != DOMID_IDLE )
>>> +    {
>>> +        printk("xsm_set_system_active should only be called by idle
>>> domain\n");
>>
>> Sorry I spotted that now, here in the printk probably you mean
>> “flask_set_system_active”
>> instead of “xsm_set_system_active”, you can keep my R-by after this
>> change.
> 
> I tend to use "%s: ...", __func__ so the name always name the function.

Ack.

v/r,
dps