Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup

From: Julien Grall <julien@xen.org>
To: Luca Fancellu <Luca.Fancellu@arm.com>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	"Wei Liu" <wl@xen.org>, "Scott Davis" <scott.davis@starlab.io>,
	"jandryuk@gmail.com" <jandryuk@gmail.com>,
	"christopher.clark@starlab.io" <christopher.clark@starlab.io>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Bertrand Marquis" <Bertrand.Marquis@arm.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"George Dunlap" <george.dunlap@citrix.com>,
	"Dario Faggioli" <dfaggioli@suse.com>,
	"Daniel De Graaf" <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup
Date: Mon, 9 May 2022 19:33:54 +0100	[thread overview]
Message-ID: <d97053e6-678f-e356-840f-e70c85b007bd@xen.org> (raw)
In-Reply-To: <08C4B263-D905-42A2-BBFF-75D7F78E20A1@arm.com>

On 03/05/2022 14:17, Luca Fancellu wrote:
>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
>> index 0bf63ffa84..b93101191e 100644
>> --- a/xen/xsm/flask/hooks.c
>> +++ b/xen/xsm/flask/hooks.c
>> @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct domain *d)
>>      return 0;
>> }
>>
>> +static int cf_check flask_set_system_active(void)
>> +{
>> +    struct domain *d = current->domain;
>> +
>> +    ASSERT(d->is_privileged);
>> +
>> +    if ( d->domain_id != DOMID_IDLE )
>> +    {
>> +        printk("xsm_set_system_active should only be called by idle domain\n");
> 
> Sorry I spotted that now, here in the printk probably you mean “flask_set_system_active”
> instead of “xsm_set_system_active”, you can keep my R-by after this change.

I tend to use "%s: ...", __func__ so the name always name the function.

Cheers,

-- 
Julien Grall