* [MPTCP] Re: [PATCH v2 0/2] Interim Path Manager
@ 2019-10-15 4:40 Peter Krystad
0 siblings, 0 replies; 3+ messages in thread
From: Peter Krystad @ 2019-10-15 4:40 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]
On Mon, 2019-10-14 at 18:36 +0200, Matthieu Baerts wrote:
> Hi Peter, Paolo,
>
> On 14/10/2019 13:29, Paolo Abeni wrote:
> > Hi,
> >
> > On Tue, 2019-09-17 at 11:37 -0700, Peter Krystad wrote:
> > > Patchset includes the interim path manager plus sysctl setting of
> > > the announce address and binding local address when creating subflows.
> > > I also split the path manager into a seperate file.
> > >
> > > v2:
> > > rename to 'basic' path manager
> > > remove pm_init definition
> > >
> > > Peter Krystad (2):
> > > mptcp: Minor changes to path manager interface
> > > mptcp: Implement basic path manager
> > >
> > > net/mptcp/Makefile | 2 +-
> > > net/mptcp/basic.c | 247 +++++++++++++++++++++++++++++++++++++++++++
> > > net/mptcp/pm.c | 38 +++++--
> > > net/mptcp/protocol.c | 2 +-
> > > net/mptcp/protocol.h | 14 ++-
> > > 5 files changed, 290 insertions(+), 13 deletions(-)
> > > create mode 100644 net/mptcp/basic.c
> >
> > I'm sorry for lagging behind so much.
> >
> > I'm ok with the patches in the current status - even if I fear some
> > rebasing will be now need, perhaps good Matt can take that bourden, too
> > - since he called me 'lawyer' I feel less guilty asking that ;)
>
> Yes my Lord!
>
> Thank you for the patch and the plea (review?)!
>
> - e3c637f02e45: "squashed" (including a rebase) the first part of the
> first patch in "mptcp: Add path manager interface"
> - 232953cffb3b: "squashed" (including a rebase) the second part of the
> first patch in "mptcp: Implement path manager interface commands". Note
> I had a conflict: addr->s_addr is stored in network bytes order.
> - 250376a152f7: added (including a rebase) the second patch at the end
> (should I move it somewhere else?)
> - 5cfa9c11a52f: fix compilation errors (due to changes made since the
> patch has been sent here)
>
> Tests are still OK!
Thanks Matthieu for this rebase and merge. I had some changes locally to adapt
these patches for IPv6, I will rebase and post them tomorrow to prepare for
sharing IPv6 RFC this week.
Peter.
> Cheers,
> Matt
^ permalink raw reply [flat|nested] 3+ messages in thread
* [MPTCP] Re: [PATCH v2 0/2] Interim Path Manager
@ 2019-10-14 16:36 Matthieu Baerts
0 siblings, 0 replies; 3+ messages in thread
From: Matthieu Baerts @ 2019-10-14 16:36 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1973 bytes --]
Hi Peter, Paolo,
On 14/10/2019 13:29, Paolo Abeni wrote:
> Hi,
>
> On Tue, 2019-09-17 at 11:37 -0700, Peter Krystad wrote:
>> Patchset includes the interim path manager plus sysctl setting of
>> the announce address and binding local address when creating subflows.
>> I also split the path manager into a seperate file.
>>
>> v2:
>> rename to 'basic' path manager
>> remove pm_init definition
>>
>> Peter Krystad (2):
>> mptcp: Minor changes to path manager interface
>> mptcp: Implement basic path manager
>>
>> net/mptcp/Makefile | 2 +-
>> net/mptcp/basic.c | 247 +++++++++++++++++++++++++++++++++++++++++++
>> net/mptcp/pm.c | 38 +++++--
>> net/mptcp/protocol.c | 2 +-
>> net/mptcp/protocol.h | 14 ++-
>> 5 files changed, 290 insertions(+), 13 deletions(-)
>> create mode 100644 net/mptcp/basic.c
>
> I'm sorry for lagging behind so much.
>
> I'm ok with the patches in the current status - even if I fear some
> rebasing will be now need, perhaps good Matt can take that bourden, too
> - since he called me 'lawyer' I feel less guilty asking that ;)
Yes my Lord!
Thank you for the patch and the plea (review?)!
- e3c637f02e45: "squashed" (including a rebase) the first part of the
first patch in "mptcp: Add path manager interface"
- 232953cffb3b: "squashed" (including a rebase) the second part of the
first patch in "mptcp: Implement path manager interface commands". Note
I had a conflict: addr->s_addr is stored in network bytes order.
- 250376a152f7: added (including a rebase) the second patch at the end
(should I move it somewhere else?)
- 5cfa9c11a52f: fix compilation errors (due to changes made since the
patch has been sent here)
Tests are still OK!
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 3+ messages in thread
* [MPTCP] Re: [PATCH v2 0/2] Interim Path Manager
@ 2019-10-14 11:29 Paolo Abeni
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2019-10-14 11:29 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
Hi,
On Tue, 2019-09-17 at 11:37 -0700, Peter Krystad wrote:
> Patchset includes the interim path manager plus sysctl setting of
> the announce address and binding local address when creating subflows.
> I also split the path manager into a seperate file.
>
> v2:
> rename to 'basic' path manager
> remove pm_init definition
>
> Peter Krystad (2):
> mptcp: Minor changes to path manager interface
> mptcp: Implement basic path manager
>
> net/mptcp/Makefile | 2 +-
> net/mptcp/basic.c | 247 +++++++++++++++++++++++++++++++++++++++++++
> net/mptcp/pm.c | 38 +++++--
> net/mptcp/protocol.c | 2 +-
> net/mptcp/protocol.h | 14 ++-
> 5 files changed, 290 insertions(+), 13 deletions(-)
> create mode 100644 net/mptcp/basic.c
I'm sorry for lagging behind so much.
I'm ok with the patches in the current status - even if I fear some
rebasing will be now need, perhaps good Matt can take that bourden, too
- since he called me 'lawyer' I feel less guilty asking that ;)
I think we pm looking schema may need some follow-up/cleanup, but that
could eventually follow later.
Cheers,
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-15 4:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 4:40 [MPTCP] Re: [PATCH v2 0/2] Interim Path Manager Peter Krystad
-- strict thread matches above, loose matches on Subject: below --
2019-10-14 16:36 Matthieu Baerts
2019-10-14 11:29 Paolo Abeni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.