* [Buildroot] [PATCH 1/1] package/cog: add BR2_PACKAGE_COG_USE_SYSTEM_DBUS @ 2021-02-02 11:57 Adrian Sweet 2021-02-04 20:33 ` Adrian Perez de Castro 0 siblings, 1 reply; 5+ messages in thread From: Adrian Sweet @ 2021-02-02 11:57 UTC (permalink / raw) To: buildroot Added config option to expose browser remote control on the D-Bus system bus Signed-off-by: Adrian Sweet <asweet@thegoodpenguin.co.uk> --- package/cog/Config.in | 6 ++++++ package/cog/cog.mk | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/package/cog/Config.in b/package/cog/Config.in index a9ca7473a9..c19f1c200e 100644 --- a/package/cog/Config.in +++ b/package/cog/Config.in @@ -47,6 +47,12 @@ config BR2_PACKAGE_COG_PLATFORM_DRM with video drivers that support kernel mode-setting (KMS) via the DRM user-space API. +config BR2_PACKAGE_COG_USE_SYSTEM_DBUS + bool "Use D-Bus system bus" + default n + help + Expose remote control interface on system bus + comment "DRM platform needs mesa3d w/ EGL driver and GBM" depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL diff --git a/package/cog/cog.mk b/package/cog/cog.mk index 47a5573dda..c5a1cc0df2 100644 --- a/package/cog/cog.mk +++ b/package/cog/cog.mk @@ -31,4 +31,10 @@ else COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF endif +ifeq ($(BR2_PACKAGE_COG_USE_SYSTEM_DBUS),y) +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=ON +else +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=OFF +endif + $(eval $(cmake-package)) -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/cog: add BR2_PACKAGE_COG_USE_SYSTEM_DBUS 2021-02-02 11:57 [Buildroot] [PATCH 1/1] package/cog: add BR2_PACKAGE_COG_USE_SYSTEM_DBUS Adrian Sweet @ 2021-02-04 20:33 ` Adrian Perez de Castro 2021-03-01 16:55 ` Adrian Sweet 0 siblings, 1 reply; 5+ messages in thread From: Adrian Perez de Castro @ 2021-02-04 20:33 UTC (permalink / raw) To: buildroot Hi Adrian, Thanks for the patch, I think adding the option is fine given that there are people around who would use it?which seems to be the case. Unless somebody else has an opinion against, I think we could merge this change =] On Tue, 02 Feb 2021 11:57:21 +0000 Adrian Sweet <asweet@thegoodpenguin.co.uk> wrote: > Added config option to expose browser remote control on the D-Bus system bus > > Signed-off-by: Adrian Sweet <asweet@thegoodpenguin.co.uk> Reviewed-by: Adrian Perez de Castro <aperez@igalia.com> > --- > package/cog/Config.in | 6 ++++++ > package/cog/cog.mk | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/package/cog/Config.in b/package/cog/Config.in > index a9ca7473a9..c19f1c200e 100644 > --- a/package/cog/Config.in > +++ b/package/cog/Config.in > @@ -47,6 +47,12 @@ config BR2_PACKAGE_COG_PLATFORM_DRM > with video drivers that support kernel mode-setting (KMS) > via the DRM user-space API. > > +config BR2_PACKAGE_COG_USE_SYSTEM_DBUS > + bool "Use D-Bus system bus" > + default n > + help > + Expose remote control interface on system bus > + > comment "DRM platform needs mesa3d w/ EGL driver and GBM" > depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL > > diff --git a/package/cog/cog.mk b/package/cog/cog.mk > index 47a5573dda..c5a1cc0df2 100644 > --- a/package/cog/cog.mk > +++ b/package/cog/cog.mk > @@ -31,4 +31,10 @@ else > COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF > endif > > +ifeq ($(BR2_PACKAGE_COG_USE_SYSTEM_DBUS),y) > +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=ON > +else > +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=OFF > +endif > + > $(eval $(cmake-package)) > -- > 2.25.1 > -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210204/7d0f72a4/attachment.asc> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/cog: add BR2_PACKAGE_COG_USE_SYSTEM_DBUS 2021-02-04 20:33 ` Adrian Perez de Castro @ 2021-03-01 16:55 ` Adrian Sweet 2021-03-04 15:25 ` Adrian Perez de Castro 0 siblings, 1 reply; 5+ messages in thread From: Adrian Sweet @ 2021-03-01 16:55 UTC (permalink / raw) To: buildroot All, Is there anything preventing this being merged? Can I help with any issues? Thanks, Adrian On Thu, 4 Feb 2021 at 20:33, Adrian Perez de Castro <aperez@igalia.com> wrote: > Hi Adrian, > > Thanks for the patch, I think adding the option is fine given that there > are people around who would use it?which seems to be the case. > > Unless somebody else has an opinion against, I think we could merge this > change =] > > On Tue, 02 Feb 2021 11:57:21 +0000 Adrian Sweet < > asweet at thegoodpenguin.co.uk> wrote: > > Added config option to expose browser remote control on the D-Bus system > bus > > > > Signed-off-by: Adrian Sweet <asweet@thegoodpenguin.co.uk> > > Reviewed-by: Adrian Perez de Castro <aperez@igalia.com> > > > --- > > package/cog/Config.in | 6 ++++++ > > package/cog/cog.mk | 6 ++++++ > > 2 files changed, 12 insertions(+) > > > > diff --git a/package/cog/Config.in b/package/cog/Config.in > > index a9ca7473a9..c19f1c200e 100644 > > --- a/package/cog/Config.in > > +++ b/package/cog/Config.in > > @@ -47,6 +47,12 @@ config BR2_PACKAGE_COG_PLATFORM_DRM > > with video drivers that support kernel mode-setting (KMS) > > via the DRM user-space API. > > > > +config BR2_PACKAGE_COG_USE_SYSTEM_DBUS > > + bool "Use D-Bus system bus" > > + default n > > + help > > + Expose remote control interface on system bus > > + > > comment "DRM platform needs mesa3d w/ EGL driver and GBM" > > depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL > > > > diff --git a/package/cog/cog.mk b/package/cog/cog.mk > > index 47a5573dda..c5a1cc0df2 100644 > > --- a/package/cog/cog.mk > > +++ b/package/cog/cog.mk > > @@ -31,4 +31,10 @@ else > > COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF > > endif > > > > +ifeq ($(BR2_PACKAGE_COG_USE_SYSTEM_DBUS),y) > > +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=ON > > +else > > +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=OFF > > +endif > > + > > $(eval $(cmake-package)) > > -- > > 2.25.1 > > > -- Adrian Sweet, Software Engineer https://www.thegoodpenguin.co.uk The Good Penguin Ltd is a company registered in England and Wales with company number 12374667 and VAT number 341687879. Registered office: The Good Penguin Ltd, Westcott, Glasllwch Lane, Newport, NP20 3PS. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210301/b9687bea/attachment.html> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/cog: add BR2_PACKAGE_COG_USE_SYSTEM_DBUS 2021-03-01 16:55 ` Adrian Sweet @ 2021-03-04 15:25 ` Adrian Perez de Castro 2021-03-04 16:18 ` Bartosz Bilas 0 siblings, 1 reply; 5+ messages in thread From: Adrian Perez de Castro @ 2021-03-04 15:25 UTC (permalink / raw) To: buildroot Hello Adrian, On Mon, 01 Mar 2021 16:55:49 +0000 Adrian Sweet <asweet@thegoodpenguin.co.uk> wrote: > All, > > Is there anything preventing this being merged? Can I help with any issues? The patch looks good to me (hence the "Reviewed-by" tag I sent earlier). What is left is for a Buildroot maintainer to merge it---if they agree that the patch is good to go :) Cheers, -Adrian > Thanks, Adrian > > On Thu, 4 Feb 2021 at 20:33, Adrian Perez de Castro <aperez@igalia.com> > wrote: > > > Hi Adrian, > > > > Thanks for the patch, I think adding the option is fine given that there > > are people around who would use it?which seems to be the case. > > > > Unless somebody else has an opinion against, I think we could merge this > > change =] > > > > On Tue, 02 Feb 2021 11:57:21 +0000 Adrian Sweet < > > asweet at thegoodpenguin.co.uk> wrote: > > > Added config option to expose browser remote control on the D-Bus system > > bus > > > > > > Signed-off-by: Adrian Sweet <asweet@thegoodpenguin.co.uk> > > > > Reviewed-by: Adrian Perez de Castro <aperez@igalia.com> > > > > > --- > > > package/cog/Config.in | 6 ++++++ > > > package/cog/cog.mk | 6 ++++++ > > > 2 files changed, 12 insertions(+) > > > > > > diff --git a/package/cog/Config.in b/package/cog/Config.in > > > index a9ca7473a9..c19f1c200e 100644 > > > --- a/package/cog/Config.in > > > +++ b/package/cog/Config.in > > > @@ -47,6 +47,12 @@ config BR2_PACKAGE_COG_PLATFORM_DRM > > > with video drivers that support kernel mode-setting (KMS) > > > via the DRM user-space API. > > > > > > +config BR2_PACKAGE_COG_USE_SYSTEM_DBUS > > > + bool "Use D-Bus system bus" > > > + default n > > > + help > > > + Expose remote control interface on system bus > > > + > > > comment "DRM platform needs mesa3d w/ EGL driver and GBM" > > > depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL > > > > > > diff --git a/package/cog/cog.mk b/package/cog/cog.mk > > > index 47a5573dda..c5a1cc0df2 100644 > > > --- a/package/cog/cog.mk > > > +++ b/package/cog/cog.mk > > > @@ -31,4 +31,10 @@ else > > > COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF > > > endif > > > > > > +ifeq ($(BR2_PACKAGE_COG_USE_SYSTEM_DBUS),y) > > > +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=ON > > > +else > > > +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=OFF > > > +endif > > > + > > > $(eval $(cmake-package)) > > > -- > > > 2.25.1 > > > > > > > > -- > Adrian Sweet, Software Engineer > https://www.thegoodpenguin.co.uk > > The Good Penguin Ltd is a company registered in England and Wales with > company number 12374667 and VAT number 341687879. Registered office: The > Good Penguin Ltd, Westcott, Glasllwch Lane, Newport, NP20 3PS. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210304/c99d60bf/attachment.asc> ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/cog: add BR2_PACKAGE_COG_USE_SYSTEM_DBUS 2021-03-04 15:25 ` Adrian Perez de Castro @ 2021-03-04 16:18 ` Bartosz Bilas 0 siblings, 0 replies; 5+ messages in thread From: Bartosz Bilas @ 2021-03-04 16:18 UTC (permalink / raw) To: buildroot Hello, On 04.03.2021 16:25, Adrian Perez de Castro wrote: > Hello Adrian, > > On Mon, 01 Mar 2021 16:55:49 +0000 Adrian Sweet <asweet@thegoodpenguin.co.uk> wrote: >> All, >> >> Is there anything preventing this being merged? Can I help with any issues? > The patch looks good to me (hence the "Reviewed-by" tag I sent earlier). > What is left is for a Buildroot maintainer to merge it---if they agree that > the patch is good to go :) > > Cheers, > -Adrian > >> Thanks, Adrian >> >> On Thu, 4 Feb 2021 at 20:33, Adrian Perez de Castro <aperez@igalia.com> >> wrote: >> >>> Hi Adrian, >>> >>> Thanks for the patch, I think adding the option is fine given that there >>> are people around who would use it?which seems to be the case. >>> >>> Unless somebody else has an opinion against, I think we could merge this >>> change =] >>> >>> On Tue, 02 Feb 2021 11:57:21 +0000 Adrian Sweet < >>> asweet at thegoodpenguin.co.uk> wrote: >>>> Added config option to expose browser remote control on the D-Bus system >>> bus >>>> Signed-off-by: Adrian Sweet <asweet@thegoodpenguin.co.uk> >>> Reviewed-by: Adrian Perez de Castro <aperez@igalia.com> >>> >>>> --- >>>> package/cog/Config.in | 6 ++++++ >>>> package/cog/cog.mk | 6 ++++++ >>>> 2 files changed, 12 insertions(+) >>>> >>>> diff --git a/package/cog/Config.in b/package/cog/Config.in >>>> index a9ca7473a9..c19f1c200e 100644 >>>> --- a/package/cog/Config.in >>>> +++ b/package/cog/Config.in >>>> @@ -47,6 +47,12 @@ config BR2_PACKAGE_COG_PLATFORM_DRM >>>> with video drivers that support kernel mode-setting (KMS) >>>> via the DRM user-space API. >>>> >>>> +config BR2_PACKAGE_COG_USE_SYSTEM_DBUS >>>> + bool "Use D-Bus system bus" >>>> + default n That's superfluous, boolean will default to n. Best Bartek >>>> + help >>>> + Expose remote control interface on system bus >>>> + >>>> comment "DRM platform needs mesa3d w/ EGL driver and GBM" >>>> depends on !BR2_PACKAGE_MESA3D_OPENGL_EGL >>>> >>>> diff --git a/package/cog/cog.mk b/package/cog/cog.mk >>>> index 47a5573dda..c5a1cc0df2 100644 >>>> --- a/package/cog/cog.mk >>>> +++ b/package/cog/cog.mk >>>> @@ -31,4 +31,10 @@ else >>>> COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF >>>> endif >>>> >>>> +ifeq ($(BR2_PACKAGE_COG_USE_SYSTEM_DBUS),y) >>>> +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=ON >>>> +else >>>> +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=OFF >>>> +endif >>>> + >>>> $(eval $(cmake-package)) >>>> -- >>>> 2.25.1 >>>> >> >> -- >> Adrian Sweet, Software Engineer >> https://www.thegoodpenguin.co.uk >> >> The Good Penguin Ltd is a company registered in England and Wales with >> company number 12374667 and VAT number 341687879. Registered office: The >> Good Penguin Ltd, Westcott, Glasllwch Lane, Newport, NP20 3PS. >> >> _______________________________________________ >> buildroot mailing list >> buildroot at busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210304/bf384d5b/attachment.html> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-04 16:18 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-02 11:57 [Buildroot] [PATCH 1/1] package/cog: add BR2_PACKAGE_COG_USE_SYSTEM_DBUS Adrian Sweet 2021-02-04 20:33 ` Adrian Perez de Castro 2021-03-01 16:55 ` Adrian Sweet 2021-03-04 15:25 ` Adrian Perez de Castro 2021-03-04 16:18 ` Bartosz Bilas
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.