All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Tushar Sugandhi <tusharsu@linux.microsoft.com>,
	stephen.smalley.work@gmail.com, casey@schaufler-ca.com,
	agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com,
	paul@paul-moore.com
Cc: tyhicks@linux.microsoft.com, sashal@kernel.org,
	jmorris@namei.org, nramas@linux.microsoft.com,
	linux-integrity@vger.kernel.org, selinux@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH v5 5/7] IMA: validate supported kernel data sources before measurement
Date: Fri, 06 Nov 2020 09:01:45 -0500	[thread overview]
Message-ID: <bef97a69db37d358db21668b179fd8821430b1b4.camel@linux.ibm.com> (raw)
In-Reply-To: <20201101222626.6111-6-tusharsu@linux.microsoft.com>

Hi Tushar,

On Sun, 2020-11-01 at 14:26 -0800, Tushar Sugandhi wrote:
> Currently, IMA does not restrict random data sources from measuring
> their data using ima_measure_critical_data(). Any kernel data source can
> call the function, and it's data will get measured as long as the input
> event_data_source is part of the IMA policy - CRITICAL_DATA+data_sources.
> 
> To ensure that only data from supported sources are measured, the kernel
> subsystem name needs to be added to a compile-time list of supported
> sources (an "allowed list of components"). IMA then validates the input
> parameter - "event_data_source" passed to ima_measure_critical_data()
> against this allowed list at run-time.
> 
> This compile-time list must be updated when kernel subsystems are
> updated to measure their data using IMA.
> 
> Provide an infrastructure for kernel data sources to be added to
> IMA's supported data sources list at compile-time. Update
> ima_measure_critical_data() to validate, at run-time, that the data
> source is supported before measuring the data coming from that source.

For those interested in limiting which critical data to measure, the
"data sources" IMA policy rule option already does that.   Why is this
needed?

thanks,

Mimi


WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Tushar Sugandhi <tusharsu@linux.microsoft.com>,
	stephen.smalley.work@gmail.com, casey@schaufler-ca.com,
	agk@redhat.com,  snitzer@redhat.com, gmazyland@gmail.com,
	paul@paul-moore.com
Cc: sashal@kernel.org, dm-devel@redhat.com, selinux@vger.kernel.org,
	jmorris@namei.org, linux-kernel@vger.kernel.org,
	nramas@linux.microsoft.com,
	linux-security-module@vger.kernel.org,
	tyhicks@linux.microsoft.com, linux-integrity@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v5 5/7] IMA: validate supported kernel data sources before measurement
Date: Fri, 06 Nov 2020 09:01:45 -0500	[thread overview]
Message-ID: <bef97a69db37d358db21668b179fd8821430b1b4.camel@linux.ibm.com> (raw)
In-Reply-To: <20201101222626.6111-6-tusharsu@linux.microsoft.com>

Hi Tushar,

On Sun, 2020-11-01 at 14:26 -0800, Tushar Sugandhi wrote:
> Currently, IMA does not restrict random data sources from measuring
> their data using ima_measure_critical_data(). Any kernel data source can
> call the function, and it's data will get measured as long as the input
> event_data_source is part of the IMA policy - CRITICAL_DATA+data_sources.
> 
> To ensure that only data from supported sources are measured, the kernel
> subsystem name needs to be added to a compile-time list of supported
> sources (an "allowed list of components"). IMA then validates the input
> parameter - "event_data_source" passed to ima_measure_critical_data()
> against this allowed list at run-time.
> 
> This compile-time list must be updated when kernel subsystems are
> updated to measure their data using IMA.
> 
> Provide an infrastructure for kernel data sources to be added to
> IMA's supported data sources list at compile-time. Update
> ima_measure_critical_data() to validate, at run-time, that the data
> source is supported before measuring the data coming from that source.

For those interested in limiting which critical data to measure, the
"data sources" IMA policy rule option already does that.   Why is this
needed?

thanks,

Mimi

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2020-11-06 14:03 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01 22:26 [PATCH v5 0/7] IMA: Infrastructure for measurement of critical kernel data Tushar Sugandhi
2020-11-01 22:26 ` [dm-devel] " Tushar Sugandhi
2020-11-01 22:26 ` [PATCH v5 1/7] IMA: generalize keyring specific measurement constructs Tushar Sugandhi
2020-11-01 22:26   ` [dm-devel] " Tushar Sugandhi
2020-11-01 22:26 ` [PATCH v5 2/7] IMA: update process_buffer_measurement to measure buffer hash Tushar Sugandhi
2020-11-01 22:26   ` [dm-devel] " Tushar Sugandhi
2020-11-05 14:30   ` Mimi Zohar
2020-11-05 14:30     ` [dm-devel] " Mimi Zohar
2020-11-12 21:47     ` Tushar Sugandhi
2020-11-12 21:47       ` [dm-devel] " Tushar Sugandhi
2020-11-12 22:19       ` Mimi Zohar
2020-11-12 22:19         ` [dm-devel] " Mimi Zohar
2020-11-12 23:16         ` Tushar Sugandhi
2020-11-12 23:16           ` [dm-devel] " Tushar Sugandhi
2020-11-06 12:11   ` Mimi Zohar
2020-11-06 12:11     ` [dm-devel] " Mimi Zohar
2020-11-12 21:48     ` Tushar Sugandhi
2020-11-12 21:48       ` [dm-devel] " Tushar Sugandhi
2020-11-01 22:26 ` [PATCH v5 3/7] IMA: add hook to measure critical data Tushar Sugandhi
2020-11-01 22:26   ` [dm-devel] " Tushar Sugandhi
2020-11-06 13:24   ` Mimi Zohar
2020-11-06 13:24     ` [dm-devel] " Mimi Zohar
2020-11-12 21:57     ` Tushar Sugandhi
2020-11-12 21:57       ` [dm-devel] " Tushar Sugandhi
2020-11-12 23:56       ` Mimi Zohar
2020-11-12 23:56         ` [dm-devel] " Mimi Zohar
2020-11-13 17:23         ` Tushar Sugandhi
2020-11-13 17:23           ` [dm-devel] " Tushar Sugandhi
2020-11-01 22:26 ` [PATCH v5 4/7] IMA: add policy " Tushar Sugandhi
2020-11-01 22:26   ` [dm-devel] " Tushar Sugandhi
2020-11-06 13:43   ` Mimi Zohar
2020-11-06 13:43     ` [dm-devel] " Mimi Zohar
2020-11-12 22:02     ` Tushar Sugandhi
2020-11-12 22:02       ` [dm-devel] " Tushar Sugandhi
2020-11-01 22:26 ` [PATCH v5 5/7] IMA: validate supported kernel data sources before measurement Tushar Sugandhi
2020-11-01 22:26   ` [dm-devel] " Tushar Sugandhi
2020-11-06 14:01   ` Mimi Zohar [this message]
2020-11-06 14:01     ` Mimi Zohar
2020-11-12 22:09     ` Tushar Sugandhi
2020-11-12 22:09       ` [dm-devel] " Tushar Sugandhi
2020-11-13  0:06       ` Mimi Zohar
2020-11-13  0:06         ` [dm-devel] " Mimi Zohar
2020-11-01 22:26 ` [PATCH v5 6/7] IMA: add critical_data to the built-in policy rules Tushar Sugandhi
2020-11-01 22:26   ` [dm-devel] " Tushar Sugandhi
2020-11-06 15:24   ` Mimi Zohar
2020-11-06 15:24     ` [dm-devel] " Mimi Zohar
2020-11-06 15:37     ` Lakshmi Ramasubramanian
2020-11-06 15:37       ` [dm-devel] " Lakshmi Ramasubramanian
2020-11-06 23:51       ` Lakshmi Ramasubramanian
2020-11-06 23:51         ` [dm-devel] " Lakshmi Ramasubramanian
2020-11-08 15:46         ` Mimi Zohar
2020-11-08 15:46           ` [dm-devel] " Mimi Zohar
2020-11-09 17:24           ` Lakshmi Ramasubramanian
2020-11-01 22:26 ` [PATCH v5 7/7] selinux: measure state and hash of the policy using IMA Tushar Sugandhi
2020-11-01 22:26   ` [dm-devel] " Tushar Sugandhi
2020-11-06 15:47   ` Mimi Zohar
2020-11-06 15:47     ` [dm-devel] " Mimi Zohar
2020-11-05  0:31 ` [PATCH v5 0/7] IMA: Infrastructure for measurement of critical kernel data Mimi Zohar
2020-11-05  0:31   ` [dm-devel] " Mimi Zohar
2020-11-12 22:18   ` Tushar Sugandhi
2020-11-12 22:18     ` [dm-devel] " Tushar Sugandhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bef97a69db37d358db21668b179fd8821430b1b4.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=agk@redhat.com \
    --cc=casey@schaufler-ca.com \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=jmorris@namei.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nramas@linux.microsoft.com \
    --cc=paul@paul-moore.com \
    --cc=sashal@kernel.org \
    --cc=selinux@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=stephen.smalley.work@gmail.com \
    --cc=tusharsu@linux.microsoft.com \
    --cc=tyhicks@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.