From: Matthias Brugger <matthias.bgg@gmail.com> To: Fabien Parent <fparent@baylibre.com>, robh+dt@kernel.org, mark.rutland@arm.com Cc: sean.wang@kernel.org, ryder.lee@mediatek.com, hsin-hsiung.wang@mediatek.com, wenzhen.yu@mediatek.com, chaotian.jing@mediatek.com, yong.mao@mediatek.com, jjian.zhou@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-clk@vger.kernel.org, stephane.leprovost@mediatek.com Subject: Re: [PATCH 04/24] soc: mediatek: pwrap: add missing check on rstc Date: Fri, 12 Apr 2019 19:44:15 +0200 [thread overview] Message-ID: <bfb3a38b-994c-ef4f-799c-8f8a4f012fa0@gmail.com> (raw) In-Reply-To: <20190323211612.860-5-fparent@baylibre.com> On 23/03/2019 22:15, Fabien Parent wrote: > The variable rstc is set only when the SoC PWRAP have the > PWRAP_CAP_RESET capability. Check whether rstc is set before > using it to avoid errors. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) applied to v5.1-next/soc Thanks! > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 8236a6c87e19..b3ba2301f569 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1478,7 +1478,8 @@ static int pwrap_init(struct pmic_wrapper *wrp) > { > int ret; > > - reset_control_reset(wrp->rstc); > + if (wrp->rstc) > + reset_control_reset(wrp->rstc); > if (wrp->rstc_bridge) > reset_control_reset(wrp->rstc_bridge); > >
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com> To: Fabien Parent <fparent@baylibre.com>, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, ryder.lee@mediatek.com, linux-watchdog@vger.kernel.org, jjian.zhou@mediatek.com, wenzhen.yu@mediatek.com, stephane.leprovost@mediatek.com, sean.wang@kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, yong.mao@mediatek.com, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, hsin-hsiung.wang@mediatek.com, linux-serial@vger.kernel.org, linux-clk@vger.kernel.org, chaotian.jing@mediatek.com, linux-i2c@vger.kernel.org Subject: Re: [PATCH 04/24] soc: mediatek: pwrap: add missing check on rstc Date: Fri, 12 Apr 2019 19:44:15 +0200 [thread overview] Message-ID: <bfb3a38b-994c-ef4f-799c-8f8a4f012fa0@gmail.com> (raw) In-Reply-To: <20190323211612.860-5-fparent@baylibre.com> On 23/03/2019 22:15, Fabien Parent wrote: > The variable rstc is set only when the SoC PWRAP have the > PWRAP_CAP_RESET capability. Check whether rstc is set before > using it to avoid errors. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) applied to v5.1-next/soc Thanks! > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 8236a6c87e19..b3ba2301f569 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1478,7 +1478,8 @@ static int pwrap_init(struct pmic_wrapper *wrp) > { > int ret; > > - reset_control_reset(wrp->rstc); > + if (wrp->rstc) > + reset_control_reset(wrp->rstc); > if (wrp->rstc_bridge) > reset_control_reset(wrp->rstc_bridge); > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-12 17:44 UTC|newest] Thread overview: 179+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-23 21:15 [PATCH 00/24] arm64: mediatek: add support for Pumpkin MT8516 board Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` [PATCH 01/24] dt-bindings: regulator: add support for MT6392 Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-28 19:17 ` Rob Herring 2019-03-28 19:17 ` Rob Herring 2019-03-28 19:17 ` Rob Herring 2019-03-23 21:15 ` [PATCH 02/24] regulator: mt6392: Add support for MT6392 regulator Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` [PATCH 05/24] soc: mediatek: pwrap: add support for MT8516 pwrap Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-04-12 17:44 ` Matthias Brugger 2019-04-12 17:44 ` Matthias Brugger 2019-03-23 21:15 ` [PATCH 06/24] mfd: mt6397: Add support for MT6397 pmic Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` [PATCH 07/24] arm64: dts: mt6392: Add PMIC mt6392 dtsi Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-28 19:18 ` Rob Herring 2019-03-28 19:18 ` Rob Herring 2019-03-28 19:18 ` Rob Herring 2019-03-23 21:15 ` [PATCH 08/24] dt-bindings: mmc: mtk-sd: add mtk-sd support for MT8516 Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` Fabien Parent [not found] ` <20190323211612.860-9-fparent-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 2019-03-25 13:26 ` Ulf Hansson [not found] ` <CAPDyKFrAxmBv+1i3qJpD=M1Wq33U2PMfQv_99xDm9MLhLxSWYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-05-03 15:12 ` Fabien Parent [not found] ` <CAOwMV_z8RrmoK+bfEqgwOv97uJarnuTCUo7aczZz=gyvg8CDzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-05-03 16:36 ` Ulf Hansson 2019-03-23 21:15 ` [PATCH 09/24] mmc: mtk-sd: check for valid optional memory resource Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-24 3:34 ` Yingjoe Chen 2019-03-24 3:34 ` Yingjoe Chen 2019-03-24 3:34 ` Yingjoe Chen 2019-03-24 15:18 ` Fabien Parent 2019-03-24 15:18 ` Fabien Parent [not found] ` <CAOwMV_zkHMZv8y_8C9kRCUsPtSbm+vPkJUNzU-_LK5=OhTkiPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-03-25 13:26 ` Ulf Hansson [not found] ` <20190323211612.860-1-fparent-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 2019-03-23 21:15 ` [PATCH 03/24] dt-bindings: pwrap: mediatek: add pwrap support for MT8516 Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-28 19:09 ` Rob Herring 2019-03-28 19:09 ` Rob Herring 2019-03-28 19:09 ` Rob Herring 2019-04-12 17:44 ` Matthias Brugger 2019-04-12 17:44 ` Matthias Brugger 2019-03-23 21:15 ` [PATCH 04/24] soc: mediatek: pwrap: add missing check on rstc Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-04-12 17:44 ` Matthias Brugger [this message] 2019-04-12 17:44 ` Matthias Brugger 2019-03-23 21:15 ` [PATCH 10/24] mmc: mtk-sd: add support for MT8516 Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-23 21:15 ` Fabien Parent [not found] ` <20190323211612.860-11-fparent-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 2019-03-25 13:26 ` Ulf Hansson 2019-03-23 21:15 ` [PATCH 11/24] dt-bindings: mediatek: topckgen: " Fabien Parent 2019-03-23 21:15 ` Fabien Parent 2019-03-28 19:09 ` Rob Herring 2019-03-28 19:09 ` Rob Herring 2019-03-28 19:09 ` Rob Herring 2019-04-25 21:34 ` Stephen Boyd 2019-04-25 21:34 ` Stephen Boyd 2019-04-25 21:34 ` Stephen Boyd 2019-03-23 21:16 ` [PATCH 12/24] dt-bindings: mediatek: infracfg: " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:10 ` Rob Herring 2019-03-28 19:10 ` Rob Herring 2019-03-28 19:10 ` Rob Herring 2019-04-25 21:34 ` Stephen Boyd 2019-04-25 21:34 ` Stephen Boyd 2019-04-25 21:34 ` Stephen Boyd 2019-03-23 21:16 ` [PATCH 13/24] dt-bindings: mediatek: apmixedsys: " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:11 ` Rob Herring 2019-03-28 19:11 ` Rob Herring 2019-03-28 19:11 ` Rob Herring 2019-04-25 21:35 ` Stephen Boyd 2019-04-25 21:35 ` Stephen Boyd 2019-04-25 21:35 ` Stephen Boyd 2019-03-23 21:16 ` [PATCH 14/24] clk: mediatek: add clock driver " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-04-25 21:39 ` Stephen Boyd 2019-04-25 21:39 ` Stephen Boyd 2019-04-25 21:39 ` Stephen Boyd 2019-03-23 21:16 ` [PATCH 15/24] dt-bindings: pinctrl: pinctrl-mt65xx: add support " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:11 ` Rob Herring 2019-03-28 19:11 ` Rob Herring 2019-03-28 19:11 ` Rob Herring 2019-04-08 20:44 ` Linus Walleij 2019-04-08 20:44 ` Linus Walleij 2019-04-08 20:44 ` Linus Walleij 2019-04-16 9:12 ` Matthias Brugger 2019-04-16 9:12 ` Matthias Brugger 2019-04-16 9:12 ` Matthias Brugger 2019-04-16 9:12 ` Matthias Brugger 2019-04-23 11:01 ` Linus Walleij 2019-04-23 11:01 ` Linus Walleij 2019-04-23 11:01 ` Linus Walleij 2019-04-23 14:24 ` Matthias Brugger 2019-04-23 14:24 ` Matthias Brugger 2019-04-23 14:24 ` Matthias Brugger 2019-03-23 21:16 ` [PATCH 16/24] pinctrl: mediatek: Add MT8516 Pinctrl driver Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-04-01 21:02 ` Sean Wang 2019-04-01 21:02 ` Sean Wang 2019-03-23 21:16 ` [PATCH 17/24] dt-bindings: wdog: mtk-wdt: add support for MT851 Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-24 15:13 ` Guenter Roeck 2019-03-24 15:13 ` Guenter Roeck 2019-03-28 19:13 ` Rob Herring 2019-03-28 19:13 ` Rob Herring 2019-03-28 19:13 ` Rob Herring 2019-03-23 21:16 ` [PATCH 18/24] dt-bindings: timer: mtk-timer: add support for MT8516 Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:12 ` Rob Herring 2019-03-28 19:12 ` Rob Herring 2019-03-28 19:12 ` Rob Herring 2019-04-16 7:54 ` Matthias Brugger 2019-04-16 7:54 ` Matthias Brugger 2019-04-16 8:09 ` Daniel Lezcano 2019-04-16 8:09 ` Daniel Lezcano 2019-03-23 21:16 ` [PATCH 19/24] dt-bindings: spi: spi-mt65xx: " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:12 ` Rob Herring 2019-03-28 19:12 ` Rob Herring 2019-03-28 19:12 ` Rob Herring 2019-04-16 7:55 ` Matthias Brugger 2019-04-16 7:55 ` Matthias Brugger 2019-04-16 8:25 ` lei liu 2019-04-16 8:25 ` lei liu 2019-04-16 8:25 ` lei liu 2019-04-16 8:52 ` Matthias Brugger 2019-04-16 8:52 ` Matthias Brugger 2019-04-18 8:05 ` Fabien Parent 2019-04-18 8:05 ` Fabien Parent 2019-04-18 8:18 ` lei liu 2019-04-18 8:18 ` lei liu 2019-04-18 8:18 ` lei liu 2019-04-16 14:28 ` Mark Brown 2019-04-16 14:28 ` Mark Brown 2019-04-17 8:19 ` Matthias Brugger 2019-04-17 8:19 ` Matthias Brugger 2019-03-23 21:16 ` [PATCH 20/24] dt-bindings: serial: mtk-uart: " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:12 ` Rob Herring 2019-03-28 19:12 ` Rob Herring 2019-03-28 19:12 ` Rob Herring 2019-04-16 7:56 ` Matthias Brugger 2019-04-16 7:56 ` Matthias Brugger 2019-03-23 21:16 ` [PATCH 21/24] dt-bindings: irq: mtk,sysirq: " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:13 ` Rob Herring 2019-03-28 19:13 ` [PATCH 21/24] dt-bindings: irq: mtk, sysirq: " Rob Herring 2019-03-28 19:13 ` [PATCH 21/24] dt-bindings: irq: mtk,sysirq: " Rob Herring 2019-04-16 7:57 ` Matthias Brugger 2019-04-16 7:57 ` Matthias Brugger 2019-03-23 21:16 ` [PATCH 22/24] dt-bindings: i2c: i2c-mtk: " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:13 ` Rob Herring 2019-03-28 19:13 ` Rob Herring 2019-03-28 19:13 ` Rob Herring 2019-04-16 7:58 ` Matthias Brugger 2019-04-16 7:58 ` Matthias Brugger 2019-04-16 8:14 ` Wolfram Sang 2019-04-16 8:14 ` Wolfram Sang 2019-04-16 8:53 ` Matthias Brugger 2019-04-16 8:53 ` Matthias Brugger 2019-04-16 11:05 ` Wolfram Sang 2019-04-16 11:05 ` Wolfram Sang 2019-03-23 21:16 ` [PATCH 23/24] arm64: dts: mediatek: add dtsi " Fabien Parent 2019-03-23 21:16 ` Fabien Parent 2019-03-28 19:22 ` Rob Herring 2019-03-28 19:22 ` Rob Herring 2019-03-28 19:22 ` Rob Herring 2019-04-16 8:04 ` Matthias Brugger 2019-04-16 8:04 ` Matthias Brugger 2019-04-16 8:04 ` Matthias Brugger 2019-04-16 8:04 ` Matthias Brugger 2019-03-23 21:16 ` [PATCH 24/24] arm64: dts: mediatek: add pumpkin board dts Fabien Parent 2019-03-23 21:16 ` Fabien Parent
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bfb3a38b-994c-ef4f-799c-8f8a4f012fa0@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=chaotian.jing@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=fparent@baylibre.com \ --cc=hsin-hsiung.wang@mediatek.com \ --cc=jjian.zhou@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=ryder.lee@mediatek.com \ --cc=sean.wang@kernel.org \ --cc=stephane.leprovost@mediatek.com \ --cc=wenzhen.yu@mediatek.com \ --cc=yong.mao@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.