* [PATCH v3 1/3] arm64: dts: meson-gxl: add support for phicomm n1
@ 2018-11-05 17:29 He Yangxuan
2018-11-09 9:47 ` Neil Armstrong
0 siblings, 1 reply; 4+ messages in thread
From: He Yangxuan @ 2018-11-05 17:29 UTC (permalink / raw)
To: linus-amlogic
This patch adds support for the Phicomm N1. This device based on P230 reference design.
The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE) to make it stable.
And this box doesn't have cvbs, so disable related section in device tree.
Signed-off-by: He Yangxuan <yangxuan8282@gmail.com>
---
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 26 ++++++++++++++++++++++
2 files changed, 27 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index c31f29d66..49f3ac5d8 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
new file mode 100644
index 000000000..1096509b2
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 He Yangxuan
+ */
+
+/dts-v1/;
+
+#include "meson-gxl-s905d-p230.dts"
+
+/ {
+ compatible = "phicomm,n1", "amlogic,s905d", "amlogic,meson-gxl";
+ model = "Phicomm N1";
+
+ cvbs-connector {
+ status = "disabled";
+ };
+};
+
+&cvbs_vdac_port {
+ status = "disabled";
+};
+
+&external_phy {
+ /* Realtek RTL8211F (0x001cc916) */
+ eee-broken-1000t;
+};
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 1/3] arm64: dts: meson-gxl: add support for phicomm n1
2018-11-05 17:29 [PATCH v3 1/3] arm64: dts: meson-gxl: add support for phicomm n1 He Yangxuan
@ 2018-11-09 9:47 ` Neil Armstrong
2018-11-09 10:07 ` He Yangxuan
0 siblings, 1 reply; 4+ messages in thread
From: Neil Armstrong @ 2018-11-09 9:47 UTC (permalink / raw)
To: linus-amlogic
Hi,
On 05/11/2018 18:29, He Yangxuan wrote:
> This patch adds support for the Phicomm N1. This device based on P230 reference design.
> The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE) to make it stable.
> And this box doesn't have cvbs, so disable related section in device tree.
>
> Signed-off-by: He Yangxuan <yangxuan8282@gmail.com>
> ---
> arch/arm64/boot/dts/amlogic/Makefile | 1 +
> .../dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 26 ++++++++++++++++++++++
> 2 files changed, 27 insertions(+)
> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index c31f29d66..49f3ac5d8 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> new file mode 100644
> index 000000000..1096509b2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> @@ -0,0 +1,26 @@
[...]
> +&external_phy {
> + /* Realtek RTL8211F (0x001cc916) */
> + eee-broken-1000t;
> +};
>
I was thinking about this, and the `eee-broken-1000t;` should go into meson-gxl-s905d-p230.dts
instead since the P230 should also have a broken EEE on the Realtek RTL8211F PHY.
Thanks,
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/3] arm64: dts: meson-gxl: add support for phicomm n1
2018-11-09 9:47 ` Neil Armstrong
@ 2018-11-09 10:07 ` He Yangxuan
2018-11-09 10:08 ` Neil Armstrong
0 siblings, 1 reply; 4+ messages in thread
From: He Yangxuan @ 2018-11-09 10:07 UTC (permalink / raw)
To: linus-amlogic
On Fri, Nov 09, 2018 at 10:47:37AM +0100, Neil Armstrong wrote:
> Hi,
>
> On 05/11/2018 18:29, He Yangxuan wrote:
> > This patch adds support for the Phicomm N1. This device based on P230 reference design.
> > The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE) to make it stable.
> > And this box doesn't have cvbs, so disable related section in device tree.
> >
> > Signed-off-by: He Yangxuan <yangxuan8282@gmail.com>
> > ---
> > arch/arm64/boot/dts/amlogic/Makefile | 1 +
> > .../dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 26 ++++++++++++++++++++++
> > 2 files changed, 27 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> > index c31f29d66..49f3ac5d8 100644
> > --- a/arch/arm64/boot/dts/amlogic/Makefile
> > +++ b/arch/arm64/boot/dts/amlogic/Makefile
> > @@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
> > +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
> > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> > new file mode 100644
> > index 000000000..1096509b2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> > @@ -0,0 +1,26 @@
>
> [...]
>
> > +&external_phy {
> > + /* Realtek RTL8211F (0x001cc916) */
> > + eee-broken-1000t;
> > +};
> >
>
> I was thinking about this, and the `eee-broken-1000t;` should go into meson-gxl-s905d-p230.dts
> instead since the P230 should also have a broken EEE on the Realtek RTL8211F PHY.
>
> Thanks,
> Neil
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
Neil, thanks for review. If add `eee-broken-1000t;` into meson-gxl-s905d-p230.dts, then this device
tree only include disable cvbs section, should I submit a separate patch for meson-gxl-s905d-p230.dts?
Yangxuan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/3] arm64: dts: meson-gxl: add support for phicomm n1
2018-11-09 10:07 ` He Yangxuan
@ 2018-11-09 10:08 ` Neil Armstrong
0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-11-09 10:08 UTC (permalink / raw)
To: linus-amlogic
On 09/11/2018 11:07, He Yangxuan wrote:
> On Fri, Nov 09, 2018 at 10:47:37AM +0100, Neil Armstrong wrote:
>> Hi,
>>
>> On 05/11/2018 18:29, He Yangxuan wrote:
>>> This patch adds support for the Phicomm N1. This device based on P230 reference design.
>>> The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE) to make it stable.
>>> And this box doesn't have cvbs, so disable related section in device tree.
>>>
>>> Signed-off-by: He Yangxuan <yangxuan8282@gmail.com>
>>> ---
>>> arch/arm64/boot/dts/amlogic/Makefile | 1 +
>>> .../dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 26 ++++++++++++++++++++++
>>> 2 files changed, 27 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>>>
>>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>>> index c31f29d66..49f3ac5d8 100644
>>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>>> @@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
>>> +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
>>> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb
>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>>> new file mode 100644
>>> index 000000000..1096509b2
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>>> @@ -0,0 +1,26 @@
>>
>> [...]
>>
>>> +&external_phy {
>>> + /* Realtek RTL8211F (0x001cc916) */
>>> + eee-broken-1000t;
>>> +};
>>>
>>
>> I was thinking about this, and the `eee-broken-1000t;` should go into meson-gxl-s905d-p230.dts
>> instead since the P230 should also have a broken EEE on the Realtek RTL8211F PHY.
>>
>> Thanks,
>> Neil
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
> Neil, thanks for review. If add `eee-broken-1000t;` into meson-gxl-s905d-p230.dts, then this device
> tree only include disable cvbs section, should I submit a separate patch for meson-gxl-s905d-p230.dts?
Yes please
>
> Yangxuan
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-09 10:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05 17:29 [PATCH v3 1/3] arm64: dts: meson-gxl: add support for phicomm n1 He Yangxuan
2018-11-09 9:47 ` Neil Armstrong
2018-11-09 10:07 ` He Yangxuan
2018-11-09 10:08 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.