[PATCH net] selftests: net: give more time for GRO aggregation

[PATCH net] selftests: net: give more time for GRO aggregation

[Paolo Abeni]

The gro.sh test-case relay on the gro_flush_timeout to ensure
that all the segments belonging to any given batch are properly
aggregated.

The other end, the sender is a user-space program transmitting
each packet with a separate write syscall. A busy host and/or
stracing the sender program can make the relevant segments reach
the GRO engine after the flush timeout triggers.

Give the GRO flush timeout more slack, to avoid sporadic self-tests
failures.

Fixes: 9af771d2ec04 ("selftests/net: allow GRO coalesce test on veth")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
 tools/testing/selftests/net/setup_veth.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/setup_veth.sh b/tools/testing/selftests/net/setup_veth.sh
index a9a1759e035c..1f78a87f6f37 100644
--- a/tools/testing/selftests/net/setup_veth.sh
+++ b/tools/testing/selftests/net/setup_veth.sh
@@ -11,7 +11,7 @@ setup_veth_ns() {
 	local -r ns_mac="$4"
 
 	[[ -e /var/run/netns/"${ns_name}" ]] || ip netns add "${ns_name}"
-	echo 100000 > "/sys/class/net/${ns_dev}/gro_flush_timeout"
+	echo 1000000 > "/sys/class/net/${ns_dev}/gro_flush_timeout"
 	ip link set dev "${ns_dev}" netns "${ns_name}" mtu 65535
 	ip -netns "${ns_name}" link set dev "${ns_dev}" up
 
-- 
2.43.0

Re: [PATCH net] selftests: net: give more time for GRO aggregation

[Eric Dumazet]

On Thu, Jan 25, 2024 at 7:09 PM Paolo Abeni <pabeni@redhat.com> wrote:
>
> The gro.sh test-case relay on the gro_flush_timeout to ensure
> that all the segments belonging to any given batch are properly
> aggregated.
>
> The other end, the sender is a user-space program transmitting
> each packet with a separate write syscall. A busy host and/or
> stracing the sender program can make the relevant segments reach
> the GRO engine after the flush timeout triggers.
>
> Give the GRO flush timeout more slack, to avoid sporadic self-tests
> failures.
>
> Fixes: 9af771d2ec04 ("selftests/net: allow GRO coalesce test on veth")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

Reviewed-by: Eric Dumazet <edumazet@google.com>
Tested-by: Eric Dumazet <edumazet@google.com>

Re: [PATCH net] selftests: net: give more time for GRO aggregation

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 25 Jan 2024 19:09:06 +0100 you wrote:
> The gro.sh test-case relay on the gro_flush_timeout to ensure
> that all the segments belonging to any given batch are properly
> aggregated.
> 
> The other end, the sender is a user-space program transmitting
> each packet with a separate write syscall. A busy host and/or
> stracing the sender program can make the relevant segments reach
> the GRO engine after the flush timeout triggers.
> 
> [...]

Here is the summary with links:
  - [net] selftests: net: give more time for GRO aggregation
    https://git.kernel.org/netdev/net/c/89abe6283753

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html