[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1406 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100395

            Bug ID: 100395
           Summary: DC, Powerplay, Tonga, top screen flicker with current
                    amd-staging-4.9
           Product: DRI
           Version: DRI git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: adf.lists@gmail.com

R9285 Tonga with current agd5f amd-staging-4.9 I am seeing the top few lines of
single DVI-D 1920x1080 monitor flicker when scrolling in eg, a maximised xterm,
browser also affected but less so.

Forcing clocks high fixes.

Bisect was a failure, I got as far as -

# good: [38eabe8ecaf5fed9e8122091b27b406563daa2ad] drm/amdgpu: add the HDP 4.0
register headers

# bad: [e2f744ea6cba6a2a7d938ec89def196a59dbdd2d] drm/amdgpu/gfx9: correct wptr
pointer value

IIRC said 40 something commits to go.

The next 20 or so are all skips because I got either build fails or startx
hangs.

Gave up with the intention of doing git reset --hard
e2f744ea6cba6a2a7d938ec89def196a59dbdd2d and going backwards, but as the
history after doing that was totally different from as seen from head I didn't
bother :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2702 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 236 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100395

--- Comment #1 from Michel Dänzer <michel@daenzer.net> ---
So this doesn't happen with amdgpu.dc=0?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1060 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 311 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100395

--- Comment #2 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Michel Dänzer from comment #1)
> So this doesn't happen with amdgpu.dc=0?

It's OK with amdgpu.dc=0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1205 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 537 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100395

--- Comment #3 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 130499
  --> https://bugs.freedesktop.org/attachment.cgi?id=130499&action=edit
dmesg

dmesg attached, plus a link to an external video of what it looks like.

As seen it's also visible when playing a vid, mpv is using opengl for output.

https://drive.google.com/file/d/0BxP5-S1t9VEEak90Tk9wM2dUVlU/view?usp=sharing

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1554 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 628 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100395

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |harry.wentland@amd.com

--- Comment #4 from Michel Dänzer <michel@daenzer.net> ---
Can you try finishing the bisect once again? Just continue with git bisect skip
until it either finds the regression commit or prints the minimal range of
candidate commits.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2019 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2011 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100395

--- Comment #5 from Andy Furniss <adf.lists@gmail.com> ---
Seems, I've found it. Many skips to work around vega build issues, but I got
past them and got a bad then good.

Further skips then due to startx hangs with dmesg logging ring test fails on 3
to 8.

Fortunately it then worked and only gave two choices one vega and -

possible first bad commit: [91561a39fa74e79b88e0e9d70f3072501c8df2ce]
drm/amdgpu: get display info from DC when DC enabled.

This cleanly reverts from head - and the issue is gone with it reverted.


# skip: [4513c8c07e243b77a36192a3c49845f85a656cea] drm/amd/display: Remove
DCE12 guards
git bisect skip 4513c8c07e243b77a36192a3c49845f85a656cea
# bad: [76cfd18b173dd61d24de2c28fa92443fcfe165d8] drm/amdgpu: gart fixes for
vega10
git bisect bad 76cfd18b173dd61d24de2c28fa92443fcfe165d8
# good: [6c59cf82dac54970284b3126ff9a15b6b0de6108] drm/amdgpu: add vega10 chip
name
git bisect good 6c59cf82dac54970284b3126ff9a15b6b0de6108
# skip: [9a493aa52c3a5176acd7b8ec32b66dc58bded8b2] drm/amdgpu: use atomfirmware
interfaces for scratch reg save/restore
git bisect skip 9a493aa52c3a5176acd7b8ec32b66dc58bded8b2
# skip: [d0a2e62fca3e502951bd1eb392e5331ad80dc88c] drm/amdgpu: add IV trace
point
git bisect skip d0a2e62fca3e502951bd1eb392e5331ad80dc88c
# skip: [40610a13a747afacb17fa2b9decfa8e5455671b4] drm/amdgpu: add 64bit
doorbell assignments
git bisect skip 40610a13a747afacb17fa2b9decfa8e5455671b4
# good: [d9693ee35fd55106b70bbd1dae9ce71b578ab3e9] drm/amdgpu: add psp firmware
header info
git bisect good d9693ee35fd55106b70bbd1dae9ce71b578ab3e9
# only skipped commits left to test
# possible first bad commit: [76cfd18b173dd61d24de2c28fa92443fcfe165d8]
drm/amdgpu: gart fixes for vega10
# possible first bad commit: [91561a39fa74e79b88e0e9d70f3072501c8df2ce]
drm/amdgpu: get display info from DC when DC enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2834 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 653 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100395

--- Comment #6 from Harry Wentland <harry.wentland@amd.com> ---
Thanks, Andy, for the report and taking the time to bisect.

Jordan from my team spotted the bug as well and is working on a solution.

If you're curious about the cause of this... The gist of it is that we don't
fill in some info for pplib on DCE 8 and 10 because we don't have the full
bandwidth formula implemented. So we either have to fill in some reasonable
values or make sure DCE 8 and 10 use the old codepath.

Hope to have a fix soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1481 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100395] DC, Powerplay, Tonga, top screen flicker with current amd-staging-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 699 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100395

Jordan L <jordan.lazare@amd.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dri-devel@lists.freedesktop |jordan.lazare@amd.com
                   |.org                        |

--- Comment #7 from Jordan L <jordan.lazare@amd.com> ---
Created attachment 130628
  --> https://bugs.freedesktop.org/attachment.cgi?id=130628&action=edit
Fix for Tonga screen flicker issue

Hi Andy,

This patch should fix the issue. 

Thanks,
Jordan

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel