[Bug 100577] DC + TearFree display lock

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1956 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

            Bug ID: 100577
           Summary: DC + TearFree  display lock
           Product: DRI
           Version: DRI git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: adf.lists@gmail.com

Created attachment 130688
  --> https://bugs.freedesktop.org/attachment.cgi?id=130688&action=edit
dmesg with errors and trace

This one may be hard to reproduce for some as it seems to rely a bit on cpufreq
ondemand being a bit rubbish on my old cpu. Lowest is 800MHz for me (high 3.4
GHz).

I don't use a compositing desktop and vids played in my browser (seamonkey)
don't get vsync.

Turning on TearFree gets me vsync, but while testing I got a screen lock. Seems
to involve timing luck - I couldn't reproduce with the browser in a sane
timescale so invented a different test that could run while AFK.

mpv -fs --vo=x11 a720p60video --loop=inf

Will usually lock in < 15 minutes with cpufreq ondemand.

It was still going after an hour with cpufreq set to perf.

Also seems OK with amdgpu.dc=0 on same kernel = amd-staging-4.9

As I've only recently started running DC, and never tried this test before, I
have no idea whether it ever worked.

xserver is latest release ddx is git.

dmesg attached shows errors and a trace starting with

[ 2009.442985] [drm:drm_atomic_helper_commit_cleanup_done [drm_kms_helper]]
*ERROR* [CRTC:39:crtc-0] flip_done timed out
[ 2013.027575] [drm:drm_atomic_helper_wait_for_dependencies [drm_kms_helper]]
*ERROR* [CRTC:39:crtc-0] flip_done timed out
[ 2013.027727] [drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR*
dm_dc_surface_commit: acrtc 0, already busy

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3379 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 497 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|michel@daenzer.net          |

--- Comment #1 from Michel Dänzer <michel@daenzer.net> ---
Removing myself from CC, I get notifications via the mailing list.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1777 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #2 from Nikola Forró <nikola.forro@gmail.com> ---
Same problem here. It was definitely working fine several weeks ago.
I'll try to bisect the issue if I'll find reliable reproducer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1072 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 304 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #3 from Nikola Forró <nikola.forro@gmail.com> ---
Created attachment 131193
  --> https://bugs.freedesktop.org/attachment.cgi?id=131193&action=edit
dmesg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1147 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 823 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #4 from Nikola Forró <nikola.forro@gmail.com> ---
Bisected to this commit:
https://cgit.freedesktop.org/~agd5f/linux/commit/?h=amd-staging-4.9&id=afbeb2d0961b2139bcf6553a710e6a8ae5d09d34

Which makes me think I'm experiencing a different issue, because this bug was
reported long before that commit emerged.

My reproducer is to fill the screen with two xterm windows next to each other
and generate random lines of text in both of them, using command like this for
example:

tr -dc a-z1-4 </dev/urandom | tr 1-2 ' \n' | awk 'length==0 || length>50' | tr
3-4 ' ' | sed 's/^ *//' | cat -s | sed 's/ / /g' | fmt

The screen lock will occur in a couple of minutes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1704 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 405 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #5 from Michel Dänzer <michel@daenzer.net> ---
(In reply to Nikola Forró from comment #4)
> Which makes me think I'm experiencing a different issue, because this bug
> was reported long before that commit emerged.

Indeed; please file your own report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1217 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 410 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #6 from Andy Furniss <adf.lists@gmail.com> ---
Testing current amd-staging-4.9 + patch from Bug 101053 I can't reproduce this
anymore.

It was a couple of hours running, I'll try longer and with 4.11 over the next
few days and either reconfirm or close this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1339 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 486 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #7 from Harry Wentland <harry.wentland@amd.com> ---
This might've been fixed by Mario's patches plus Andrey's scanline change

d58f8724e636 Mario Kleiner
    drm/amd/display: Prevent premature pageflip when comitting in vblank. (v3)  
8494f61e14ff Mario Kleiner
    drm/amd/display: Fix race between vblank irq and pageflip irq. (v2)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 338 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #8 from Andy Furniss <adf.lists@gmail.com> ---
I can still reproduce this.

Seems I may just get lucky runs - one 90 mins no issue, stopped and started
again later and it locked after 20.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1075 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 604 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #9 from Andy Furniss <adf.lists@gmail.com> ---
Can't reproduce this on current amd-staging-4.11 will keep trying and close
soon if OK.

One nit I notice is I may not be comparing like with like as current and some
older 4.11s I still have around all seem to peg memory clock high. 3.7s I still
have don't do this, neither does non DC current kernel.

I'll search/file a separate bug for this one in coming days, it causes +10
degrees idle GPU temp.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1341 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 554 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #10 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Andy Furniss from comment #9)

> One nit I notice is I may not be comparing like with like as current and
> some older 4.11s I still have around all seem to peg memory clock high. 3.7s

Ugh, not 3.7s, I mean amd-staging-4.9s didn't peg memclk high. I don't still
have all the 4.11s I've ever built so don't know when this started for them.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1366 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 589 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #11 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to Andy Furniss from comment #10)
> Ugh, not 3.7s, I mean amd-staging-4.9s didn't peg memclk high. I don't still
> have all the 4.11s I've ever built so don't know when this started for them.

What sort of display(s) do you have and what modes are you using?  Mclk dpm is
disabled if there are multiple monitors or if the vblank period is too short to
support mclk switching.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1404 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 620 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #12 from Andy Furniss <adf.lists@gmail.com> ---
Hmm, so I just booted back into current staging to get a dmesg and xrandr and
ended up noticing 2 more issues.

My monitor is 1920x1080 and can do 120Hz but pref and used by default is 60Hz.

Issue 1 - I can't see 120Hz with xrandr, I normally can - but then I normally
use non DC kernels.

Issue 2 I see a few errors at the end of the dmesg =

[drm] dc_get_validate_context:resource validation failed, dc_status:6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1358 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 355 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #13 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 132465
  --> https://bugs.freedesktop.org/attachment.cgi?id=132465&action=edit
dmesg on current staging memclk is stuck high + some errors

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1303 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 334 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #14 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 132466
  --> https://bugs.freedesktop.org/attachment.cgi?id=132466&action=edit
xrandr --verbose higher clocks missing

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1240 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 268 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #15 from Andy Furniss <adf.lists@gmail.com> ---
It seems the errors in the dmesg are created when I do xrandr --verbose.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1006 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 736 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

--- Comment #16 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 132467
  --> https://bugs.freedesktop.org/attachment.cgi?id=132467&action=edit
xrandr --verbose on 4.14-wip showing all modes

This is xrandr on 4.14-wip - the higher modes are shown, though the clocks
aren't  precise 100/110/120 - it's always been like this, I live in hope that
may get better one day!

I forgot to put earlier WRT 2 monitors, that HDMI-A-0 is physically connected,
but not seen as the TV is off, and as I said, 4.9 DC and all non DC kernels for
ages don't peg memclk high with the same setup.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1658 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100577] DC + TearFree display lock

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 596 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100577

Andy Furniss <adf.lists@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #17 from Andy Furniss <adf.lists@gmail.com> ---
Testing with amd-staging-drm-next, which doesn't peg memclk high I can't
reproduce this anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2043 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel