* [Bug 101189] Latest git fails to compile with radeon
@ 2017-05-25 16:47 bugzilla-daemon
2017-05-26 17:14 ` bugzilla-daemon
` (21 more replies)
0 siblings, 22 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-25 16:47 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1340 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
Bug ID: 101189
Summary: Latest git fails to compile with radeon
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: major
Priority: medium
Component: Drivers/Gallium/r600
Assignee: dri-devel@lists.freedesktop.org
Reporter: comeon@getbackinthe.kitchen
QA Contact: dri-devel@lists.freedesktop.org
It seems that commit de9dd4f9f1bb5984c554d0acf7d2592951ecc53f introduced a bug
in which you were not able to compile radeon drivers. The latest git currently
fails to build with:
/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/common/ac_gpu_info.h:31:20:
fatal error: amdgpu.h: No such file or directory
I'm building mesa-9999 on Gentoo. My use flags are:
USE="classic d3d9 dri3 egl gallium gbm gles2 llvm nptl opencl pax_kernel pic
vaapi vdpau wayland xa -bindist -debug -gles1 -openmax -osmesa (-selinux)
-unwind% -valgrind -vulkan -xvmc" ABI_X86="32 (64) (-x32)" VIDEO_CARDS="i965
intel r600 radeon (-freedreno) -i915 -imx -nouveau -r100 -r200 -r300 -radeonsi
(-vc4) (-vivante) -vmware"
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2734 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
@ 2017-05-26 17:14 ` bugzilla-daemon
2017-05-26 17:14 ` bugzilla-daemon
` (20 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-26 17:14 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 704 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
Eric Engestrom <fdo-bugs@engestrom.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Eric Engestrom <fdo-bugs@engestrom.ch> ---
Fixed by:
commit 44b29dd7b6cdc1a3fde58c367b9de8081ac4167b
Author: Eric Engestrom <eric.engestrom@imgtec.com>
Date: Fri May 26 11:59:20 2017 +0100
amd/common: add missing libdrm include path
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2243 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
2017-05-26 17:14 ` bugzilla-daemon
@ 2017-05-26 17:14 ` bugzilla-daemon
2017-05-26 19:20 ` bugzilla-daemon
` (19 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-26 17:14 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 516 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
Eric Engestrom <fdo-bugs@engestrom.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |acelists@atlas.sk
--- Comment #2 from Eric Engestrom <fdo-bugs@engestrom.ch> ---
*** Bug 101190 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2089 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
2017-05-26 17:14 ` bugzilla-daemon
2017-05-26 17:14 ` bugzilla-daemon
@ 2017-05-26 19:20 ` bugzilla-daemon
2017-05-26 19:23 ` bugzilla-daemon
` (18 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-26 19:20 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 559 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
Pavel Vinogradov <public@sourcemage.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #3 from Pavel Vinogradov <public@sourcemage.org> ---
drm from git doesn't provide amdgpu.h, but amdgpu_drm.h.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2000 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (2 preceding siblings ...)
2017-05-26 19:20 ` bugzilla-daemon
@ 2017-05-26 19:23 ` bugzilla-daemon
2017-05-26 19:34 ` bugzilla-daemon
` (17 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-26 19:23 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 453 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #4 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to Pavel Vinogradov from comment #3)
> drm from git doesn't provide amdgpu.h, but amdgpu_drm.h.
It provides both:
https://cgit.freedesktop.org/mesa/drm/tree/amdgpu/amdgpu.h
https://cgit.freedesktop.org/mesa/drm/tree/include/drm/amdgpu_drm.h
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1464 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (3 preceding siblings ...)
2017-05-26 19:23 ` bugzilla-daemon
@ 2017-05-26 19:34 ` bugzilla-daemon
2017-05-26 19:50 ` bugzilla-daemon
` (16 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-26 19:34 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 595 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #5 from Pavel Vinogradov <public@sourcemage.org> ---
hm, strange. do I need to build amdgpu kms as well? for simple radeon hd 4650?
(In reply to Alex Deucher from comment #4)
> (In reply to Pavel Vinogradov from comment #3)
> > drm from git doesn't provide amdgpu.h, but amdgpu_drm.h.
>
> It provides both:
> https://cgit.freedesktop.org/mesa/drm/tree/amdgpu/amdgpu.h
> https://cgit.freedesktop.org/mesa/drm/tree/include/drm/amdgpu_drm.h
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1668 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (4 preceding siblings ...)
2017-05-26 19:34 ` bugzilla-daemon
@ 2017-05-26 19:50 ` bugzilla-daemon
2017-05-26 20:04 ` bugzilla-daemon
` (15 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-26 19:50 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 372 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #6 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to Pavel Vinogradov from comment #5)
> hm, strange. do I need to build amdgpu kms as well? for simple radeon hd
> 4650?
You don't need the amdgpu kernel driver.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1231 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (5 preceding siblings ...)
2017-05-26 19:50 ` bugzilla-daemon
@ 2017-05-26 20:04 ` bugzilla-daemon
2017-05-27 10:51 ` bugzilla-daemon
` (14 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-26 20:04 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 486 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #7 from Pavel Vinogradov <public@sourcemage.org> ---
Sorry, I meant the amdgpu kms library in drm itself.
(In reply to Alex Deucher from comment #6)
> (In reply to Pavel Vinogradov from comment #5)
> > hm, strange. do I need to build amdgpu kms as well? for simple radeon hd
> > 4650?
>
> You don't need the amdgpu kernel driver.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1404 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (6 preceding siblings ...)
2017-05-26 20:04 ` bugzilla-daemon
@ 2017-05-27 10:51 ` bugzilla-daemon
2017-05-28 13:03 ` bugzilla-daemon
` (13 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-27 10:51 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 212 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #8 from aceman <acelists@atlas.sk> ---
Thanks, fixed for me too.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 987 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (7 preceding siblings ...)
2017-05-27 10:51 ` bugzilla-daemon
@ 2017-05-28 13:03 ` bugzilla-daemon
2017-05-28 13:04 ` bugzilla-daemon
` (12 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-28 13:03 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 322 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #9 from John Dallahan <comeon@getbackinthe.kitchen> ---
Created attachment 131547
--> https://bugs.freedesktop.org/attachment.cgi?id=131547&action=edit
Complete build log
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1242 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (8 preceding siblings ...)
2017-05-28 13:03 ` bugzilla-daemon
@ 2017-05-28 13:04 ` bugzilla-daemon
2017-05-28 15:07 ` bugzilla-daemon
` (11 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-28 13:04 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 289 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #10 from John Dallahan <comeon@getbackinthe.kitchen> ---
This bug is still occurring with the latest git. I attached the complete build
log.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1082 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (9 preceding siblings ...)
2017-05-28 13:04 ` bugzilla-daemon
@ 2017-05-28 15:07 ` bugzilla-daemon
2017-05-30 13:46 ` bugzilla-daemon
` (10 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-28 15:07 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 876 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #11 from jospezial <jospezial@gmx.de> ---
(In reply to Alex Deucher from comment #4)
> (In reply to Pavel Vinogradov from comment #3)
> > drm from git doesn't provide amdgpu.h, but amdgpu_drm.h.
>
> It provides both:
> https://cgit.freedesktop.org/mesa/drm/tree/amdgpu/amdgpu.h
> https://cgit.freedesktop.org/mesa/drm/tree/include/drm/amdgpu_drm.h
libdrm only installs amdgpu.h in /usr/include/libdrm/ if it is compiled with
amdgpu support.
If libdrm is compiled with radeon support only, then
/usr/include/libdrm/amdgpu_drm.h is installed only.
Tested with x11-libs/libdrm-2.4.80::gentoo
The bug is introduced in
https://cgit.freedesktop.org/mesa/mesa/commit/?id=f187a493225e33c5ce514c731a0a140d61dacb0b
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2043 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (10 preceding siblings ...)
2017-05-28 15:07 ` bugzilla-daemon
@ 2017-05-30 13:46 ` bugzilla-daemon
2017-05-30 16:38 ` bugzilla-daemon
` (9 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-30 13:46 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 357 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #12 from Emil Velikov <emil.l.velikov@gmail.com> ---
This series [1] should address it properly although there's some contentious
points around patch 2/5
[1] https://patchwork.freedesktop.org/series/24960/
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1208 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (11 preceding siblings ...)
2017-05-30 13:46 ` bugzilla-daemon
@ 2017-05-30 16:38 ` bugzilla-daemon
2017-06-02 16:39 ` bugzilla-daemon
` (8 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-05-30 16:38 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 442 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #13 from Pavel Vinogradov <public@sourcemage.org> ---
works like a charm. thanks.
(In reply to Emil Velikov from comment #12)
> This series [1] should address it properly although there's some contentious
> points around patch 2/5
>
> [1] https://patchwork.freedesktop.org/series/24960/
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1375 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (12 preceding siblings ...)
2017-05-30 16:38 ` bugzilla-daemon
@ 2017-06-02 16:39 ` bugzilla-daemon
2017-06-16 18:45 ` bugzilla-daemon
` (7 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-02 16:39 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 498 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #14 from Emil Velikov <emil.l.velikov@gmail.com> ---
For anyone wondering why patches have not been merged, yet.
Patch 2/5 neuters the partial Opencl support in r600, in an attempt to untangle
the convoluted dependencies. A few people are unhappy about it (understandably
so) and I've not pushed the patches so that they can resolve this better.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1287 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (13 preceding siblings ...)
2017-06-02 16:39 ` bugzilla-daemon
@ 2017-06-16 18:45 ` bugzilla-daemon
2017-06-17 3:14 ` bugzilla-daemon
` (6 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-16 18:45 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 435 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
Pavel Vinogradov <public@sourcemage.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1263 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (14 preceding siblings ...)
2017-06-16 18:45 ` bugzilla-daemon
@ 2017-06-17 3:14 ` bugzilla-daemon
2017-06-17 4:28 ` bugzilla-daemon
` (5 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-17 3:14 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1501 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
Benji Wiebe <benjiwiebe14@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #15 from Benji Wiebe <benjiwiebe14@gmail.com> ---
With this patch https://patchwork.freedesktop.org/patch/158696/ the build is
broken for me now, not using radeon. Two issues: 1) when you remove amdgpu.h
from ac_gpu_info.h, you need to (but didn't) add includes for stdint.h and
stdbool.h. 2) I get the following error when compiling (after adding the
stdint/stdbool includes):
In file included from ../../../src/amd/common/ac_gpu_info.c:37:0:
/usr/local/include/libdrm/amdgpu.h:107:31: error: conflicting types for
‘amdgpu_device_handle’
typedef struct amdgpu_device *amdgpu_device_handle;
^~~~~~~~~~~~~~~~~~~~
In file included from ../../../src/amd/common/ac_gpu_info.c:26:0:
../../../src/amd/common/ac_gpu_info.h:39:16: note: previous declaration of
‘amdgpu_device_handle’ was here
typedef void * amdgpu_device_handle;
^~~~~~~~~~~~~~~~~~~~
And then a few more compiler warnings/errors that I believe tie into the above
one and will be resolved when the above is resolved.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2997 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (15 preceding siblings ...)
2017-06-17 3:14 ` bugzilla-daemon
@ 2017-06-17 4:28 ` bugzilla-daemon
2017-06-17 6:36 ` bugzilla-daemon
` (4 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-17 4:28 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1354 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #16 from Pavel Vinogradov <public@sourcemage.org> ---
try current git, the patchset was applied there smoothly.
(In reply to Benji Wiebe from comment #15)
> With this patch https://patchwork.freedesktop.org/patch/158696/ the build is
> broken for me now, not using radeon. Two issues: 1) when you remove amdgpu.h
> from ac_gpu_info.h, you need to (but didn't) add includes for stdint.h and
> stdbool.h. 2) I get the following error when compiling (after adding the
> stdint/stdbool includes):
>
> In file included from ../../../src/amd/common/ac_gpu_info.c:37:0:
> /usr/local/include/libdrm/amdgpu.h:107:31: error: conflicting types for
> ‘amdgpu_device_handle’
> typedef struct amdgpu_device *amdgpu_device_handle;
> ^~~~~~~~~~~~~~~~~~~~
> In file included from ../../../src/amd/common/ac_gpu_info.c:26:0:
> ../../../src/amd/common/ac_gpu_info.h:39:16: note: previous declaration of
> ‘amdgpu_device_handle’ was here
> typedef void * amdgpu_device_handle;
> ^~~~~~~~~~~~~~~~~~~~
>
>
>
> And then a few more compiler warnings/errors that I believe tie into the
> above one and will be resolved when the above is resolved.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2338 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (16 preceding siblings ...)
2017-06-17 4:28 ` bugzilla-daemon
@ 2017-06-17 6:36 ` bugzilla-daemon
2017-06-17 6:37 ` bugzilla-daemon
` (3 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-17 6:36 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 454 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #17 from Benji Wiebe <benjiwiebe14@gmail.com> ---
(In reply to Pavel Vinogradov from comment #16)
> try current git, the patchset was applied there smoothly.
Yes, I tried current git. I did a git bisect and it pointed to that patch I
linked. I've also tried current git as of 1:30 AM CDT, still no go.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1312 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (17 preceding siblings ...)
2017-06-17 6:36 ` bugzilla-daemon
@ 2017-06-17 6:37 ` bugzilla-daemon
2017-06-17 6:44 ` bugzilla-daemon
` (2 subsequent siblings)
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-17 6:37 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 389 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #18 from Benji Wiebe <benjiwiebe14@gmail.com> ---
Tomorrow if you haven't gotten it figured out yet I can start up a VM and do a
completely fresh build (though to the best of my knowledge this was fresh too,
I deleted the build dir first).
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1175 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (18 preceding siblings ...)
2017-06-17 6:37 ` bugzilla-daemon
@ 2017-06-17 6:44 ` bugzilla-daemon
2017-06-17 11:46 ` bugzilla-daemon
2017-06-17 15:41 ` bugzilla-daemon
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-17 6:44 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 4322 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #19 from Mauro Rossi <issor.oruam@gmail.com> ---
Hi,
with current patch "ac: remove amdgpu.h dependency" applied,
on Android (nougat-x86) I get the following building errors:
In file included from external/mesa/src/amd/common/ac_gpu_info.c:26:
external/mesa/src/amd/common/ac_gpu_info.h:41:2: error: unknown type name
'uint32_t'
uint32_t pci_domain;
^
external/mesa/src/amd/common/ac_gpu_info.h:42:2: error: unknown type name
'uint32_t'
uint32_t pci_bus;
^
external/mesa/src/amd/common/ac_gpu_info.h:43:2: error: unknown type name
'uint32_t'
uint32_t pci_dev;
^
external/mesa/src/amd/common/ac_gpu_info.h:44:2: error: unknown type name
'uint32_t'
uint32_t pci_func;
^
external/mesa/src/amd/common/ac_gpu_info.h:47:2: error: unknown type name
'uint32_t'
uint32_t pci_id;
^
external/mesa/src/amd/common/ac_gpu_info.h:50:2: error: unknown type name
'uint32_t'
uint32_t pte_fragment_size;
^
external/mesa/src/amd/common/ac_gpu_info.h:51:2: error: unknown type name
'uint32_t'
uint32_t gart_page_size;
^
external/mesa/src/amd/common/ac_gpu_info.h:52:2: error: unknown type name
'uint64_t'
uint64_t gart_size;
^
external/mesa/src/amd/common/ac_gpu_info.h:53:2: error: unknown type name
'uint64_t'
uint64_t vram_size;
^
external/mesa/src/amd/common/ac_gpu_info.h:54:2: error: unknown type name
'uint64_t'
uint64_t vram_vis_size;
^
external/mesa/src/amd/common/ac_gpu_info.h:55:2: error: unknown type name
'uint64_t'
uint64_t max_alloc_size;
^
external/mesa/src/amd/common/ac_gpu_info.h:56:2: error: unknown type name
'uint32_t'
uint32_t min_alloc_size;
^
external/mesa/src/amd/common/ac_gpu_info.h:57:2: error: unknown type name
'bool'
bool has_dedicated_vram;
^
external/mesa/src/amd/common/ac_gpu_info.h:58:2: error: unknown type name
'bool'
bool has_virtual_memory;
^
external/mesa/src/amd/common/ac_gpu_info.h:59:2: error: unknown type name
'bool'
bool gfx_ib_pad_with_type2;
^
external/mesa/src/amd/common/ac_gpu_info.h:60:2: error: unknown type name
'bool'
bool has_hw_decode;
^
external/mesa/src/amd/common/ac_gpu_info.h:61:2: error: unknown type name
'uint32_t'
uint32_t num_sdma_rings;
^
external/mesa/src/amd/common/ac_gpu_info.h:62:2: error: unknown type name
'uint32_t'
uint32_t num_compute_rings;
^
external/mesa/src/amd/common/ac_gpu_info.h:63:2: error: unknown type name
'uint32_t'
uint32_t uvd_fw_version;
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
The following changes are necessary in src/amd/common/ac_gpu_info.h
utente@utente-System-Product-Name:~/nougat-x86/external/mesa$ git diff
diff --git a/src/amd/common/ac_gpu_info.h b/src/amd/common/ac_gpu_info.h
index a72ab58f9a..616a1df7fa 100644
--- a/src/amd/common/ac_gpu_info.h
+++ b/src/amd/common/ac_gpu_info.h
@@ -26,6 +26,9 @@
#ifndef AC_GPU_INFO_H
#define AC_GPU_INFO_H
+#include <stdint.h>
+#include <stdbool.h>
+
#include "amd_family.h"
#ifdef __cplusplus
Having applied that I still get the following build error:
In file included from external/mesa/src/amd/common/ac_surface.c:38:
external/libdrm/amdgpu/amdgpu.h:107:31: error: typedef redefinition with
different types ('struct amdgpu_device *' vs 'void *')
typedef struct amdgpu_device *amdgpu_device_handle;
^
1 error generated.
Could you please check on the latter and provide corrective patch?
I am available to test build on nougat-x86
Thanks
Mauro
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 5159 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (19 preceding siblings ...)
2017-06-17 6:44 ` bugzilla-daemon
@ 2017-06-17 11:46 ` bugzilla-daemon
2017-06-17 15:41 ` bugzilla-daemon
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-17 11:46 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 860 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
Emil Velikov <emil.l.velikov@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #20 from Emil Velikov <emil.l.velikov@gmail.com> ---
The issues should be resolved in master, as of
commit 1f958c1337290b4062a77f79fc101bb9f4bdf515 (origin/master, origin/HEAD)
Author: Emil Velikov <emil.velikov@collabora.com>
Date: Fri Jun 16 19:53:50 2017 +0100
radeonsi: include ac_binary.h for struct ac_shader_binary
For seemingly unrelated build issues, please file a separate report.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2408 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Bug 101189] Latest git fails to compile with radeon
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
` (20 preceding siblings ...)
2017-06-17 11:46 ` bugzilla-daemon
@ 2017-06-17 15:41 ` bugzilla-daemon
21 siblings, 0 replies; 23+ messages in thread
From: bugzilla-daemon @ 2017-06-17 15:41 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 235 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101189
--- Comment #21 from Benji Wiebe <benjiwiebe14@gmail.com> ---
Yes this fixes it for me now. Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1053 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2017-06-17 15:41 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-25 16:47 [Bug 101189] Latest git fails to compile with radeon bugzilla-daemon
2017-05-26 17:14 ` bugzilla-daemon
2017-05-26 17:14 ` bugzilla-daemon
2017-05-26 19:20 ` bugzilla-daemon
2017-05-26 19:23 ` bugzilla-daemon
2017-05-26 19:34 ` bugzilla-daemon
2017-05-26 19:50 ` bugzilla-daemon
2017-05-26 20:04 ` bugzilla-daemon
2017-05-27 10:51 ` bugzilla-daemon
2017-05-28 13:03 ` bugzilla-daemon
2017-05-28 13:04 ` bugzilla-daemon
2017-05-28 15:07 ` bugzilla-daemon
2017-05-30 13:46 ` bugzilla-daemon
2017-05-30 16:38 ` bugzilla-daemon
2017-06-02 16:39 ` bugzilla-daemon
2017-06-16 18:45 ` bugzilla-daemon
2017-06-17 3:14 ` bugzilla-daemon
2017-06-17 4:28 ` bugzilla-daemon
2017-06-17 6:36 ` bugzilla-daemon
2017-06-17 6:37 ` bugzilla-daemon
2017-06-17 6:44 ` bugzilla-daemon
2017-06-17 11:46 ` bugzilla-daemon
2017-06-17 15:41 ` bugzilla-daemon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.