[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1270 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

            Bug ID: 104306
           Summary: Mesa 17.3 breaks Firefox and other Xwayland apps on
                    AMD HD7750
           Product: Mesa
           Version: 17.3
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: mesabug11@p33.org
        QA Contact: dri-devel@lists.freedesktop.org

On latest stable Archlinux with AMD HD7750, Mesa 17.3 breaks Firefox,
Libreoffice, mpv with X11 backend and Chromium (when running WebGL).

Launching firefox or glxinfo from command line results in no response and no
crashes. There are no errors in dmesg or journalctl, except Probe failed with
amdkfd, but blacklisting amdkfd doesn't solve the issue. Using strace on
firefox there are system interrupted notices. Chromium works, but opening any
WebGL page freezes Chromium. mpv with X11 backend shows Bad Drawable, server
failed to allocate resource.

Downgrading to mesa 17.2.6 solves the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2636 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 901 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #1 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Similar experience here on Arch Linux with a Radeon HD 8870M / R9 M270X/M370X. 
Firefox hangs on launch before drawing a window, and Chromium won't start
either unless I --disable-gpu.  Similar strace results, no amdkfd errors.

Archive package 2017/12/15/extra/os/x86_64/mesa-17.2.6-1 works fine,
2017/12/16/extra/os/x86_64/mesa-17.3.0-2 doesn't.  Kernel 4.9.69-1-lts #1 SMP
Thu Dec 14 19:51:07 CET 2017 x86_64 GNU/Linux, if it matters.

I notice the Arch maintainer changed the build arg --enable-omx to
--enable-omx-bellagio in this release.  I know nothing of Mesa's build process,
this being my first encounter, but I thought that might be useful to mention in
case it's relevant.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1720 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 497 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #2 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Working on narrowing down the source of the issue, I've found so far that
17.2.7 builds work fine (though I had to change --enable-omx-bellagio back to
--enable-omx), and 17.3.0-rc3 does not.  I'll try an -rc1 build, then I may be
on to learning how to package from a locally bisected git.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1316 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 987 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #3 from eric vz <evonzee+freedesktop@themxgroup.com> ---
A cycle of git bisect building leads me here:

255573996cc997cb61be9adad3e8fcaa78db5d1f is the first bad commit
commit 255573996cc997cb61be9adad3e8fcaa78db5d1f
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Mon Oct 9 18:56:22 2017 +0200

    st/dri: implement __DRIimageExtension::validateUsage properly

    Reviewed-by: Daniel Stone <daniels@collabora.com>
    Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>

:040000 040000 691ace5458e444a262bd2632b0234f7c08711674
181aa1f345cafc40db98187dd9e66b115c8f7e52 M      src

I'm not familiar enough with C or this codebase to render an opinion about why
this commit would have broken things, but I'd love to assist if someone with
more perspective needs me to run/test things to determine a resolution here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1977 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 454 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #4 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Created attachment 136333
  --> https://bugs.freedesktop.org/attachment.cgi?id=136333&action=edit
Bisect log

Bisect log attached.  I also had to revert c4ed39f85b (which I did via
cherrypick applying b6f41e393e)to build some of these versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1385 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 376 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #5 from Michel Dänzer <michel@daenzer.net> ---
I can't reproduce this with weston or gnome-shell.

Which Wayland compositor and which version of Xwayland are you using?

Can you get a gdb backtrace of glxinfo when it hangs?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1186 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 494 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #6 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Created attachment 136345
  --> https://bugs.freedesktop.org/attachment.cgi?id=136345&action=edit
Hung glxinfo backtrace

gnome-shell 3.26.2+9+ga3736d3a3-1
xorg-server-xwayland 1.19.5-1

Backtrace attached.  I've also got strace output if it would be useful.  Thanks
for your help!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1449 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 792 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

eric vz <evonzee+freedesktop@themxgroup.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136345|0                           |1
        is obsolete|                            |

--- Comment #7 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Created attachment 136350
  --> https://bugs.freedesktop.org/attachment.cgi?id=136350&action=edit
Hung glxinfo backtrace - mesa 17.3.1-1

On the chance you'd want to see a newer version, I built mesa 17.3.1-1 (with
debug symbols this time!) and have the same issue.  Backtrace attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2321 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 519 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

Emil Velikov <emil.l.velikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |breno.ec@gmail.com

--- Comment #8 from Emil Velikov <emil.l.velikov@gmail.com> ---
*** Bug 104351 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2108 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #9 from Jonathan Williams <hazies@gmail.com> ---
I also have this problem on Arch Linux with a Radeon HD 7770, mesa 17.3.1-2,
gnome-shell 3.26.2+9+ga3736d3a3-1.  The Gnome Wayland session starts, but
several XWayland apps (Firefox, Thunderbird, steam client) do not.  glxinfo
shows no response when run, as reported above.

Downgrading to mesa 17.2.6 appears to fix it, but for this card I can also work
around it by switching to the amdgpu kernel module instead of the default
radeon, which appears to resolve the issues under mesa 17.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1504 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 428 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #10 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Following up on this, it looks like my bisect wa bad.  I retried commit
255573996cc997cb61be9adad3e8fcaa78db5d1f and it works fine. 

I will re-bisect to find the real offending commit and report when I have an
answer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1248 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 491 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #11 from Sergey Kvachonok <ravenexp@gmail.com> ---
I can confirm that switching from radeon to amdgpu on

03:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
Pitcairn XT [Radeon HD 7870 GHz Edition]

Device: AMD Radeon HD 7800 Series (PITCAIRN / DRM 3.19.0 / 4.14.11-1-ARCH, LLVM
5.0.1) (0x6818)

fixes the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1304 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1436 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #12 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Subsequent bisects (starting at different ranges so different commits would be
tested) have led me to the same place. No idea why I thought 255573996 worked
for a while; all new builds from it break for me.  I have Pacman packages for
every build I've made if anyone would find them useful.

I narrowed the problem to the final return statement by replacing it with
"return true;" which resulted in a working build.  I also tried to rule out
side-effects from the call by adding "bind =
screen->check_resource_capability(screen, image->texture, bind) ? 1 : 0;"
before the return true so the method would be called but its return value
ignored, assuming the compiler is not smart enough to optimize that out.  That
build worked too. 

I assume that capability check must sometimes be returning false in some
unexpected situations, and something is not handling that.  I tried making a
debug build of mesa-demos, then gdb glxinfo and set a breakpoint on
dri2_validate_usage, but that method appears not to be called before the
process hangs.  I assume something during system startup calls it, caches the
result, and leads to these issues downstream?

If anyone has any guidance on next steps, I'd appreciate it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2282 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 466 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #13 from Michel Dänzer <michel@daenzer.net> ---
(In reply to eric vz from comment #12)
> [...] gdb glxinfo and set a breakpoint on dri2_validate_usage, but that method
> appears not to be called before the process hangs.

It's not called in the client but in the Wayland compositor process, or maybe
in Xwayland.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1352 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1637 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #14 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Thanks, Michel.  On a hanging call to glxinfo, dri2_validate_usage is being
called from gbm_dri_bo_import, which gets parameters of a 100x100 FD image
buffer for usage 5 (scanout | rendering).  However, the image texture winds up
with is_displayable = 0, so si_check_resource_capabilities returns false,
gbm_dri_bo_import destroys the image, and glxinfo hangs.  I confirmed that if I
set variable usage = 0 the problem does not occur.  I have not yet been able to
trace where the texture flags are set, but I got far enough to find that
they're being read from the image buffer as metadata.  

However, it occurs to me that as a newcomer to the domain (e.g., I had to
google what a scanout is), I don't know the real problem:

* Should usage include scanout?
* Should the image metadata include is_displayable? 
* Should the null return from gbm_dri_bo_import cause the caller to hang?

Either point 1 or point 2 seems like it must be wrong, and might be the easiest
fix. Point 1 seems the stronger case, since glxinfo doesn't actually draw
anything as far as I'm aware. Since Firefox, Chromium, and other apps also seem
to fail on this, I'm expecting to find some kind of common initialization code
that does it.  Will report back when I get time to dig.  Or, if anyone knows
better than I do which avenue to pursue, I'm happy to be redirected.  I don't
expect to have time to look at this until the weekend.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2457 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 293 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #15 from Michel Dänzer <michel@daenzer.net> ---
Thanks for the help, Eric.

https://patchwork.freedesktop.org/patch/200999/ fixes this for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1166 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

--- Comment #16 from eric vz <evonzee+freedesktop@themxgroup.com> ---
Thanks a lot, Michel!  I confirmed that 255573996 plus the linked patch works
for me as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1120 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104306] Mesa 17.3 breaks Firefox and other Xwayland apps on AMD HD7750

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 901 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104306

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #17 from Michel Dänzer <michel@daenzer.net> ---
Thanks for the report, fixed in Git master (and should get backported to a
future 17.3.y release):

Commit: 1cf1bf32eff5ffca0b928c0884b0e792207b61b7
URL:   
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1cf1bf32eff5ffca0b928c0884b0e792207b61b7

Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Fri Jan 26 18:32:32 2018 +0100

winsys/radeon: Compute is_displayable in surf_drm_to_winsys

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2605 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel