From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 107065] "BUG: unable to handle kernel paging request at 0000000000002000" in amdgpu_vm_cpu_set_ptes at amdgpu_vm.c:921
Date: Mon, 02 Jul 2018 11:03:45 +0000 [thread overview]
Message-ID: <bug-107065-502-43yIQHsBrt@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-107065-502@http.bugs.freedesktop.org/>
[-- Attachment #1.1: Type: text/plain, Size: 1364 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=107065
--- Comment #11 from Christian König <ckoenig.leichtzumerken@gmail.com> ---
(In reply to Andrey Grodzovsky from comment #10)
> Created attachment 140418 [details] [review]
> drm/amdgpu: Verify root PD is mapped into kernel address space.
>
> dwagner, please try this patch. Fixes the issue for me and I observed no
> suspend/resume issues.
>
> Christian, please take a look at the patch, problem was that in
> amdgpu_vm_update_directories the parent BO didn't have a kernel mapping and
> so later inside amdgpu_vm_cpu_set_ptes
> pe += (unsigned long)amdgpu_bo_kptr(bo); would equal to 0000000000002000
> since
> parent amdgpu_bo_kptr woudld return NULL. The parent was the root PD.
>
> This was still working in 67b8d5c Linus Torvalds 7 weeks ago Linux
> 4.17-rc5 (tag: v4.17-rc5) but I wasn't able to exactly pinpoint which
> change broke it. I am not sure my fix is the right one so please advise.
No idea when that broke either, CPU based updates is not something we usually
test.
Anyway it's a good catch, but I would rather add that to
amdgpu_vm_bo_base_init() (with the appropriate checks).
That would also allow us to remove the duplicated code from
amdgpu_vm_alloc_levels().
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2791 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-02 11:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 19:33 [Bug 107065] "BUG: unable to handle kernel paging request at 0000000000002000" at amdgpu_vm_cpu_set_ptes at S3 resume bugzilla-daemon
2018-06-28 19:42 ` bugzilla-daemon
2018-06-28 19:52 ` bugzilla-daemon
2018-06-28 20:49 ` bugzilla-daemon
2018-06-28 22:50 ` bugzilla-daemon
2018-06-29 0:37 ` bugzilla-daemon
2018-06-29 16:16 ` bugzilla-daemon
2018-06-29 19:10 ` bugzilla-daemon
2018-06-29 19:10 ` [Bug 107065] "BUG: unable to handle kernel paging request at 0000000000002000" in amdgpu_vm_cpu_set_ptes at amdgpu_vm.c:921 bugzilla-daemon
2018-06-29 19:17 ` bugzilla-daemon
2018-06-29 19:21 ` bugzilla-daemon
2018-07-02 3:11 ` bugzilla-daemon
2018-07-02 11:03 ` bugzilla-daemon [this message]
2018-07-02 19:48 ` bugzilla-daemon
2018-07-02 22:55 ` bugzilla-daemon
2018-07-03 20:42 ` bugzilla-daemon
2018-07-03 22:58 ` bugzilla-daemon
2018-07-04 22:55 ` bugzilla-daemon
2018-07-06 23:03 ` bugzilla-daemon
2018-07-09 18:16 ` bugzilla-daemon
2018-07-11 22:04 ` bugzilla-daemon
2018-07-11 22:23 ` bugzilla-daemon
2018-07-13 21:01 ` bugzilla-daemon
2018-07-13 23:45 ` bugzilla-daemon
2018-07-14 4:28 ` bugzilla-daemon
2018-07-14 13:15 ` bugzilla-daemon
2018-07-14 13:16 ` bugzilla-daemon
2018-07-16 13:52 ` bugzilla-daemon
2018-07-19 16:42 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-107065-502-43yIQHsBrt@http.bugs.freedesktop.org/ \
--to=bugzilla-daemon@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.