[Bug 108486] Iincompatible result.json generation between igt_runner and piglit summary

[Bug 108486] Iincompatible result.json generation between igt_runner and piglit summary

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1923 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108486

            Bug ID: 108486
           Summary: Iincompatible result.json generation between
                    igt_runner and piglit summary
           Product: DRI
           Version: DRI git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: IGT
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: andi.shyti@intel.com

Created attachment 142081
  --> https://bugs.freedesktop.org/attachment.cgi?id=142081&action=edit
Test list I'm trying to test

I tried to simulate (dry-run) a test using the runner/igt_runner but the
result.json created fails to be parsed by piglit. The test list is in the
attachment in case it's needed.

Steps to reproduce the error:

$ <path_to_igt>/build/runner/igt_runner -d --test-list test_list
<path_to_igt>/build/tests <output_dir>

$ cd <output_dir>

$ mkdir res

$ piglist summary html res/ result.json

I get the following error:

Traceback (most recent call last):
  File "/usr/bin/piglit", line 178, in <module>
    main()
  File "/usr/bin/piglit", line 174, in main
    sys.exit(runner(args))
  File "/usr/lib/x86_64-linux-gnu/piglit/framework/exceptions.py", line 51, in
_inner
    func(*args, **kwargs)
  File "/usr/lib/x86_64-linux-gnu/piglit/framework/programs/summary.py", line
119, in html
    summary.html(args.resultsFiles, args.summaryDir, args.exclude_details)
  File "/usr/lib/x86_64-linux-gnu/piglit/framework/summary/html_.py", line 178,
in html
    _make_testrun_info(results, destination, exclude)
  File "/usr/lib/x86_64-linux-gnu/piglit/framework/summary/html_.py", line 99,
in _make_testrun_info
    totals=each.totals['root'],
KeyError: 'root'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3462 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108486] Incompatible result.json generation between igt_runner and piglit summary

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 581 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108486

Andi <andi.shyti@intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Iincompatible result.json   |Incompatible result.json
                   |generation between          |generation between
                   |igt_runner and piglit       |igt_runner and piglit
                   |summary                     |summary

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1208 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108486] Incompatible result.json generation between igt_runner and piglit summary

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 361 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108486

--- Comment #1 from Andi <andi.shyti@intel.com> ---
the incompatible result.json happens also without the -d (dry-run) and with
different test list inputs. I guess the igt_runner generates always an
incompatible result.json

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1185 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108486] Incompatible result.json generation between igt_runner and piglit summary

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 334 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108486

--- Comment #2 from Petri Latvala <petri.latvala@intel.com> ---
https://patchwork.freedesktop.org/series/51238/ sent for a fix. Won't merge it
yet until it gets through the currently overloaded CI.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1232 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108486] Incompatible result.json generation between igt_runner and piglit summary

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108486

Petri Latvala <petri.latvala@intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Petri Latvala <petri.latvala@intel.com> ---
commit b633344e7407f2086199b9d835aa980ba4c29dfa
Author: Petri Latvala <petri.latvala@intel.com>
Date:   Fri Oct 19 11:46:48 2018 +0300

    runner: Add "root" also to the "totals" object

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2354 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108486] Incompatible result.json generation between igt_runner and piglit summary

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108486

Andi <andi.shyti@intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #4 from Andi <andi.shyti@intel.com> ---
I tested and it works... thanks Petri!

Andi

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1919 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108486] Incompatible result.json generation between igt_runner and piglit summary

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 376 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108486

Petri Latvala <petri.latvala@intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|VERIFIED                    |CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1120 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel