[Bug 108542] hdmi issues with kernel 4.18

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1490 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

            Bug ID: 108542
           Summary: hdmi issues with kernel 4.18
           Product: DRI
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: davide26079@gmail.com

- since 4.18, the hdmi output says "12 bit"
- since 4.18.8 there's no video output !!

You can find more details in this thread

https://bbs.archlinux.org/viewtopic.php?id=241212

I did a bisection to find the bad commit for the first regression already, and
that's the result:

e03fd3f300f6184c1264186a4c815e93bf658abb is the first bad commit
commit e03fd3f300f6184c1264186a4c815e93bf658abb
Author: Mikita Lipski <mikita.lipski@amd.com>
Date:   Wed May 16 16:46:18 2018 -0400

    drm/amd/display: Do not limit color depth to 8bpc

    Delete if statement that would force any display's color depth higher
    than 8 bpc to 8

    Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
    Reviewed-by: Harry Wentland <Harry.Wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

:040000 040000 57c7a743a10059addbfdd1a122f90c4053d377fa
13139317e62ef56db1748bf48f31f81eb986c7f8 M      drivers

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3073 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 302 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #1 from Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> ---
Thanks for the bisection.

Would you mind posting a full dmesg log for your 4.18.8 kernel?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1058 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 287 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #2 from davide26079@gmail.com ---
Created attachment 142207
  --> https://bugs.freedesktop.org/attachment.cgi?id=142207&action=edit
dmesg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1114 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 570 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #3 from davide26079@gmail.com ---
(In reply to Nicholas Kazlauskas from comment #1)
> Thanks for the bisection.
> 
> Would you mind posting a full dmesg log for your 4.18.8 kernel?

done. Dunno if that's what you asked for, I am just a newbie...

I did start bisecting the second issue as well, but my free time is limited. I
think I'll finish this weekend though.

May I hope to get things fixed in a few weeks?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1372 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 758 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #4 from Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> ---
(In reply to davide26079 from comment #3)
> (In reply to Nicholas Kazlauskas from comment #1)
> > Thanks for the bisection.
> > 
> > Would you mind posting a full dmesg log for your 4.18.8 kernel?
> 
> done. Dunno if that's what you asked for, I am just a newbie...
> 
> I did start bisecting the second issue as well, but my free time is limited.
> I think I'll finish this weekend though.
> 
> May I hope to get things fixed in a few weeks?

The log you posted should be sufficient. I'm not sure about a timeline for a
fix, however.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1664 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1480 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #5 from davide26079@gmail.com ---
> The log you posted should be sufficient. I'm not sure about a timeline for a
> fix, however.

Couldn't you just reverse the commits ?

I did complete the bisection btw:

691f2d763d0731224439686ecf2d440df8fe910e is the first bad commit
commit 691f2d763d0731224439686ecf2d440df8fe910e
Author: Mikita Lipski <mikita.lipski@amd.com>
Date:   Fri Jul 13 09:07:35 2018 -0400

    drm/amd/display: update clk for various HDMI color depths

    commit 81aca8e75c1b046865fb2badef95a0dcff6f73de upstream.

    [why]
    When programming tonga's connector's backend we didn't take
    in account that HDMI's colour depth might be more than 8bpc
    therefore we need to add a switch statement that would adjust
    the pixel clock accordingly.

    [how]
    Add a switch statement updating clock by its appropriate
    coefficient.

    Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
    Reviewed-by: Charlene Liu <Charlene.Liu@amd.com>
    Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

:040000 040000 ef9f989910439dc8749f1440863e3e26646d5fa1
c9ae9b8a137f9ef9d62147fcc28ea25fc4ffbc1e M      drivers

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2645 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 239 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #6 from davide26079@gmail.com ---
Built 4.19 reverting both commits, everything works fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 964 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 475 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #7 from Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> ---
Created attachment 142278
  --> https://bugs.freedesktop.org/attachment.cgi?id=142278&action=edit
0001-Fix-unsigned-short-unsigned-long-mixup-for-usSymCloc.patch

Does applying this patch help?

Try this on top of the tree without reverting the other patches.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1535 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 498 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #8 from davide26079@gmail.com ---
(In reply to Nicholas Kazlauskas from comment #7)
> Created attachment 142278 [details] [review]
> 0001-Fix-unsigned-short-unsigned-long-mixup-for-usSymCloc.patch
> 
> Does applying this patch help?
> 
> Try this on top of the tree without reverting the other patches.

Just tried, unfortunately it does not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1676 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 421 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #9 from Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> ---
The patchset from:

https://patchwork.freedesktop.org/patch/260799/

...will likely resolve this issue.

It has been merged into amd-staging-drm-next branch at:

https://cgit.freedesktop.org/~agd5f/linux

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1295 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 504 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

--- Comment #10 from davide26079@gmail.com ---
(In reply to Nicholas Kazlauskas from comment #9)
> The patchset from:
> 
> https://patchwork.freedesktop.org/patch/260799/
> 
> ...will likely resolve this issue.
> 
> It has been merged into amd-staging-drm-next branch at:
> 
> https://cgit.freedesktop.org/~agd5f/linux

Tried amd-staging-drm-next, it works!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1443 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108542] hdmi issues with kernel 4.18

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 806 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108542

Martin Peres <martin.peres@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #11 from Martin Peres <martin.peres@free.fr> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/drm/amd/issues/568.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2310 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel