* [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend
@ 2019-01-10 1:56 bugzilla-daemon
2019-01-11 14:18 ` bugzilla-daemon
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: bugzilla-daemon @ 2019-01-10 1:56 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1054 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109265
Bug ID: 109265
Summary: [regression, bisected] arb_texture_multisample
texelfetch piglit test failing on NIR backend
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/Gallium/radeonsi
Assignee: dri-devel@lists.freedesktop.org
Reporter: t_arceri@yahoo.com.au
QA Contact: dri-devel@lists.freedesktop.org
For example:
R600_DEBUG=nir ./bin/texelFetch fs sampler2DMS 4 1x71-501x71 -auto -fbo
Bisected to (on VEGA 64):
commit f7ffa504a065dc2631fd38cc5fe885b277f4e7e7 (refs/bisect/bad)
Author: Marek Olšák <marek.olsak@amd.com>
Date: Sat Jul 29 01:40:48 2017 +0200
ac/surface: compute tile swizzle for GFX9
Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2561 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend
2019-01-10 1:56 [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend bugzilla-daemon
@ 2019-01-11 14:18 ` bugzilla-daemon
2019-01-11 14:19 ` bugzilla-daemon
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2019-01-11 14:18 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 340 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109265
--- Comment #1 from Marek Olšák <maraeo@gmail.com> ---
The commit has no effect on shaders. The bisecting has most likely been
unsuccessful. Setting tile_swizzle = 0 in ac_surface.c reverts the commit.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1207 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend
2019-01-10 1:56 [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend bugzilla-daemon
2019-01-11 14:18 ` bugzilla-daemon
@ 2019-01-11 14:19 ` bugzilla-daemon
2019-01-11 14:28 ` bugzilla-daemon
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2019-01-11 14:19 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 296 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109265
--- Comment #2 from Marek Olšák <maraeo@gmail.com> ---
Note that f7ffa504a065dc2631fd38cc5fe885b277f4e7e7 indeed broke MSAA, but it
was fixed by c5c6e0187fd.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1163 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend
2019-01-10 1:56 [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend bugzilla-daemon
2019-01-11 14:18 ` bugzilla-daemon
2019-01-11 14:19 ` bugzilla-daemon
@ 2019-01-11 14:28 ` bugzilla-daemon
2019-01-14 6:19 ` bugzilla-daemon
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2019-01-11 14:28 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 240 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109265
--- Comment #3 from Marek Olšák <maraeo@gmail.com> ---
The test passes with MESA_GLSL_CACHE_DISABLE=1.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1107 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend
2019-01-10 1:56 [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend bugzilla-daemon
` (2 preceding siblings ...)
2019-01-11 14:28 ` bugzilla-daemon
@ 2019-01-14 6:19 ` bugzilla-daemon
2019-02-27 23:07 ` bugzilla-daemon
2019-02-28 0:52 ` bugzilla-daemon
5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2019-01-14 6:19 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1568 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109265
--- Comment #4 from Timothy Arceri <t_arceri@yahoo.com.au> ---
This is odd. As far as I can tell the shader variant produced after loading
from the case is the same as the one produced when the cache is disabled.
Its also a fairly simple program. From tests/texturing/shaders/texelFetch.c the
offending program is:
int vs = piglit_compile_shader_text(GL_VERTEX_SHADER,
"#version 130\n"
"#extension GL_ARB_explicit_attrib_location: require\n"
"layout(location=0) in vec4 pos;\n"
"void main() {\n"
" gl_Position = pos;\n"
"}\n");
(void)!asprintf(&fs_code,
"#version 130\n"
"#extension GL_ARB_explicit_attrib_location: require\n"
"#extension GL_ARB_fragment_coord_conventions: require\n"
"uniform int layer;\n"
"uniform int si;\n"
"layout(pixel_center_integer) in vec4 gl_FragCoord;\n"
"layout(location=0) out %s o;\n"
"void main() {\n"
" o = %s(%sgl_FragCoord.x, gl_FragCoord.y, layer, si);\n"
"}\n",
sampler.return_type,
sampler.return_type,
sampler.data_type == GL_UNSIGNED_INT ? "" : "-");
We must not be setting a flag somewhere, but I've looked over the code that
handles the cache multiple time now and can't spot any real difference between
tgsi and nir.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2625 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend
2019-01-10 1:56 [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend bugzilla-daemon
` (3 preceding siblings ...)
2019-01-14 6:19 ` bugzilla-daemon
@ 2019-02-27 23:07 ` bugzilla-daemon
2019-02-28 0:52 ` bugzilla-daemon
5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2019-02-27 23:07 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 369 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109265
--- Comment #5 from Timothy Arceri <t_arceri@yahoo.com.au> ---
You were right it was a bad bisect due to that patch breaking MSAA also. I
found the real issue, fix sent to the list.
https://patchwork.freedesktop.org/patch/288934/
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1304 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend
2019-01-10 1:56 [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend bugzilla-daemon
` (4 preceding siblings ...)
2019-02-27 23:07 ` bugzilla-daemon
@ 2019-02-28 0:52 ` bugzilla-daemon
5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2019-02-28 0:52 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1249 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109265
Timothy Arceri <t_arceri@yahoo.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Timothy Arceri <t_arceri@yahoo.com.au> ---
Fixed by:
commit 7536af670b7501228628a8c90f9e8456b5aec9e1
Author: Timothy Arceri <tarceri@itsqueeze.com>
Date: Wed Feb 27 18:26:07 2019 +1100
glsl: fix shader cache for packed param list
Some types of params such as some builtins are always padded. We
need to keep track of this so we can restore the list correctly.
Here we also remove a couple of cache entries that are not actually
required as they get rebuilt by the _mesa_add_parameter() calls.
This patch fixes a bunch of arb_texture_multisample and
arb_sample_shading piglit tests for the radeonsi NIR backend.
Fixes: edded1237607 ("mesa: rework ParameterList to allow packing")
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 3008 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-02-28 0:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 1:56 [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend bugzilla-daemon
2019-01-11 14:18 ` bugzilla-daemon
2019-01-11 14:19 ` bugzilla-daemon
2019-01-11 14:28 ` bugzilla-daemon
2019-01-14 6:19 ` bugzilla-daemon
2019-02-27 23:07 ` bugzilla-daemon
2019-02-28 0:52 ` bugzilla-daemon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.