* [Buildroot] [Bug 12841] New: util-linux/sfdisk 2.35.1 fails on sector-size header
@ 2020-05-02 20:02 bugzilla at busybox.net
2020-05-08 9:10 ` [Buildroot] [Bug 12841] " bugzilla at busybox.net
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: bugzilla at busybox.net @ 2020-05-02 20:02 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=12841
Bug ID: 12841
Summary: util-linux/sfdisk 2.35.1 fails on sector-size header
Product: buildroot
Version: 2020.02.1
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: sebaroth at gmx.de
CC: buildroot at uclibc.org
Target Milestone: ---
Hi,
using sfdisk to print out and re-deploy the partition layout fails in version
2.35 and 2.35.1:
# sfdisk -v
sfdisk from util-linux 2.35.1
# sfdisk --dump /dev/sda > sda.partitions
# sfdisk /dev/sda < sda.partitions
...
>>> Script header accepted.
>>> line 5: unsupported command
...
Some more details can be found in this bugreport:
https://gitlab.alpinelinux.org/alpine/aports/issues/11200 (I know Alpine is
unrelated but it's got all the details in there)
Seems like this is fixed upstream already:
https://github.com/karelzak/util-linux/commit/d8c68b52cc939a16f04ec976648a37f5f5de718c
I am wondering if buildroot wants to add a patch to fix this while waiting for
the next util-linux version to be released. Suggested fix:
--- a/libfdisk/src/script.c
+++ b/libfdisk/src/script.c
@@ -837,6 +837,7 @@
|| strcmp(name, "grain") == 0
|| strcmp(name, "first-lba") == 0
|| strcmp(name, "last-lba") == 0
+ || strcmp(name, "sector-size") == 0
|| strcmp(name, "table-length") == 0) {
; /* whatever is possible
*/
} else
Thanks in advance!
Sebastian
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [Bug 12841] util-linux/sfdisk 2.35.1 fails on sector-size header
2020-05-02 20:02 [Buildroot] [Bug 12841] New: util-linux/sfdisk 2.35.1 fails on sector-size header bugzilla at busybox.net
@ 2020-05-08 9:10 ` bugzilla at busybox.net
2020-05-09 13:04 ` bugzilla at busybox.net
2020-05-09 13:08 ` bugzilla at busybox.net
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla at busybox.net @ 2020-05-08 9:10 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=12841
--- Comment #1 from Fabrice Fontaine <fontaine.fabrice@gmail.com> ---
Hi,
Instead of adding a custom patch, I retrieved the upstream patch:
https://patchwork.ozlabs.org/project/buildroot/patch/20200507224150.242211-2-fontaine.fabrice at gmail.com
Can you confirm that the patch above fixes your issue?
Best Regards,
Fabrice
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [Bug 12841] util-linux/sfdisk 2.35.1 fails on sector-size header
2020-05-02 20:02 [Buildroot] [Bug 12841] New: util-linux/sfdisk 2.35.1 fails on sector-size header bugzilla at busybox.net
2020-05-08 9:10 ` [Buildroot] [Bug 12841] " bugzilla at busybox.net
@ 2020-05-09 13:04 ` bugzilla at busybox.net
2020-05-09 13:08 ` bugzilla at busybox.net
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla at busybox.net @ 2020-05-09 13:04 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=12841
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
Thanks! Fixed by Fabrice in
https://git.buildroot.org/buildroot/commit/?id=af787a4cf5a19c3411d83ddbd8840b9486b6fcad
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [Bug 12841] util-linux/sfdisk 2.35.1 fails on sector-size header
2020-05-02 20:02 [Buildroot] [Bug 12841] New: util-linux/sfdisk 2.35.1 fails on sector-size header bugzilla at busybox.net
2020-05-08 9:10 ` [Buildroot] [Bug 12841] " bugzilla at busybox.net
2020-05-09 13:04 ` bugzilla at busybox.net
@ 2020-05-09 13:08 ` bugzilla at busybox.net
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla at busybox.net @ 2020-05-09 13:08 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=12841
--- Comment #3 from SR <sebaroth@gmx.de> ---
Hi,
testing with the patch you provided it seems all fine too. Probably a good idea
to use the upstream patch.
Thanks for adding this!
Sebastian
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-09 13:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-02 20:02 [Buildroot] [Bug 12841] New: util-linux/sfdisk 2.35.1 fails on sector-size header bugzilla at busybox.net
2020-05-08 9:10 ` [Buildroot] [Bug 12841] " bugzilla at busybox.net
2020-05-09 13:04 ` bugzilla at busybox.net
2020-05-09 13:08 ` bugzilla at busybox.net
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.