All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 137351] New: MSG_NOSIGNAL not documented
@ 2016-07-21 21:06 bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
       [not found] ` <bug-137351-11311-3bo0kxnWaOQUvHkbgXJLS5sdmw4N0Rt+2LY78lusg7I@public.gmane.org/>
  0 siblings, 1 reply; 7+ messages in thread
From: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r @ 2016-07-21 21:06 UTC (permalink / raw)
  To: linux-man-u79uwXL29TY76Z2rM5mHXA

https://bugzilla.kernel.org/show_bug.cgi?id=137351

            Bug ID: 137351
           Summary: MSG_NOSIGNAL not documented
           Product: Documentation
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P1
         Component: man-pages
          Assignee: documentation_man-pages-ztI5WcYan/vQLgFONoPN62D2FQJk+8+b@public.gmane.org
          Reporter: ivan.kharpalev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
        Regression: No

MSG_NOSIGNAL is not documented in man 2 recv.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)."
       [not found] ` <bug-137351-11311-3bo0kxnWaOQUvHkbgXJLS5sdmw4N0Rt+2LY78lusg7I@public.gmane.org/>
@ 2016-07-21 21:28   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
  2016-07-22  6:29   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
                     ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r @ 2016-07-21 21:28 UTC (permalink / raw)
  To: linux-man-u79uwXL29TY76Z2rM5mHXA

https://bugzilla.kernel.org/show_bug.cgi?id=137351

Ivan Kharpalev <ivan.kharpalev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|MSG_NOSIGNAL not documented |MSG_NOSIGNAL not documented
                   |                            |in man 2 recv, OR misprint
                   |                            |in man recvmsg in the line
                   |                            |"This can be avoided by
                   |                            |passing the MSG_NOSIGNAL
                   |                            |flag to sendmsg(2) or
                   |                            |recvmsg(2)."

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)."
       [not found] ` <bug-137351-11311-3bo0kxnWaOQUvHkbgXJLS5sdmw4N0Rt+2LY78lusg7I@public.gmane.org/>
  2016-07-21 21:28   ` [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)." bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
@ 2016-07-22  6:29   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
  2016-07-22  6:45   ` [PATCH] unix.7: Explain that MSG_NOSIGNAL is useless for recvmsg(2) Laurent Georget
                     ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r @ 2016-07-22  6:29 UTC (permalink / raw)
  To: linux-man-u79uwXL29TY76Z2rM5mHXA

https://bugzilla.kernel.org/show_bug.cgi?id=137351

Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

--- Comment #1 from Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
But, as far as I know, it does nothing for recv(2). If you believe otherwise,
please add some supporting info.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] unix.7: Explain that MSG_NOSIGNAL is useless for recvmsg(2)
       [not found] ` <bug-137351-11311-3bo0kxnWaOQUvHkbgXJLS5sdmw4N0Rt+2LY78lusg7I@public.gmane.org/>
  2016-07-21 21:28   ` [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)." bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
  2016-07-22  6:29   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
@ 2016-07-22  6:45   ` Laurent Georget
       [not found]     ` <20160722064522.5159-1-laurent.georget-vbcOdlJ0SulGWvitb5QawA@public.gmane.org>
  2016-07-22  6:51   ` [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)." bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
  2016-07-24 20:35   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
  4 siblings, 1 reply; 7+ messages in thread
From: Laurent Georget @ 2016-07-22  6:45 UTC (permalink / raw)
  To: linux-man-u79uwXL29TY76Z2rM5mHXA, Michael Kerrisk; +Cc: Laurent Georget

recvmsg(2) never causes a "Broken pipe" error but the unix(7) man page implies
that MSG_NOSIGNAL can be used in the flags of recvmsg(2) to avoid sending a
SIGPIPE. Fixes Bug 137351.

Signed-Off-By: Laurent Georget <laurent.georget-vbcOdlJ0SulGWvitb5QawA@public.gmane.org>

---
 man7/unix.7 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Hi Michael,

I found the culprit line in unix(7). It can be misleading indeed because it
that it makes sense to use MSG_NOSIGNAL as a flag to recvmsg(2) to avoid a
SIGPIPE but recvmsg(2) actually never triggers such an error. I propose the
patch below to fix this.

Best regards,

Laurent Georget

diff --git a/man7/unix.7 b/man7/unix.7
index 82715f9..fce5eb2 100644
--- a/man7/unix.7
+++ b/man7/unix.7
@@ -515,12 +515,12 @@ Remote socket was closed on a stream socket.
 If enabled, a
 .B SIGPIPE
 is sent as well.
-This can be avoided by passing the
+Sending the signal can be avoided by passing the
 .B MSG_NOSIGNAL
 flag to
 .BR sendmsg (2)
-or
-.BR recvmsg (2).
+.RB ( recvmsg (2)
+never causes such an error).
 .TP
 .B EPROTONOSUPPORT
 Passed protocol is not
-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)."
       [not found] ` <bug-137351-11311-3bo0kxnWaOQUvHkbgXJLS5sdmw4N0Rt+2LY78lusg7I@public.gmane.org/>
                     ` (2 preceding siblings ...)
  2016-07-22  6:45   ` [PATCH] unix.7: Explain that MSG_NOSIGNAL is useless for recvmsg(2) Laurent Georget
@ 2016-07-22  6:51   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
  2016-07-24 20:35   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
  4 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r @ 2016-07-22  6:51 UTC (permalink / raw)
  To: linux-man-u79uwXL29TY76Z2rM5mHXA

https://bugzilla.kernel.org/show_bug.cgi?id=137351

--- Comment #2 from Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
I see that you changed the title of the bug. This is far too cryptic as a way
of reporting a bug. I can't find the text you refer to. Please note in a
comment exactly the text and exactly the page you are referring to, and also
check that the bug is present in the latest man page.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] unix.7: Explain that MSG_NOSIGNAL is useless for recvmsg(2)
       [not found]     ` <20160722064522.5159-1-laurent.georget-vbcOdlJ0SulGWvitb5QawA@public.gmane.org>
@ 2016-07-24 19:32       ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 7+ messages in thread
From: Michael Kerrisk (man-pages) @ 2016-07-24 19:32 UTC (permalink / raw)
  To: Laurent Georget, linux-man-u79uwXL29TY76Z2rM5mHXA
  Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w, Ivan Kharpalev

Hello Laurent,

On 07/22/2016 08:45 AM, Laurent Georget wrote:
> recvmsg(2) never causes a "Broken pipe" error but the unix(7) man page implies
> that MSG_NOSIGNAL can be used in the flags of recvmsg(2) to avoid sending a
> SIGPIPE. Fixes Bug 137351.
>
> Signed-Off-By: Laurent Georget <laurent.georget-vbcOdlJ0SulGWvitb5QawA@public.gmane.org>
>
> ---
>  man7/unix.7 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> Hi Michael,
>
> I found the culprit line in unix(7). It can be misleading indeed because it
> that it makes sense to use MSG_NOSIGNAL as a flag to recvmsg(2) to avoid a
> SIGPIPE but recvmsg(2) actually never triggers such an error. I propose the
> patch below to fix this.

Thanks for delving into this and finding the page that had the problem
reported in https://bugzilla.kernel.org/show_bug.cgi?id=137351

I applied a slightly somewhat different patch. See below.

> Best regards,
>
> Laurent Georget
>
> diff --git a/man7/unix.7 b/man7/unix.7
> index 82715f9..fce5eb2 100644
> --- a/man7/unix.7
> +++ b/man7/unix.7
> @@ -515,12 +515,12 @@ Remote socket was closed on a stream socket.
>  If enabled, a
>  .B SIGPIPE
>  is sent as well.
> -This can be avoided by passing the
> +Sending the signal can be avoided by passing the
>  .B MSG_NOSIGNAL
>  flag to
>  .BR sendmsg (2)
> -or
> -.BR recvmsg (2).
> +.RB ( recvmsg (2)
> +never causes such an error).

I think the parenthetical comment isn't needed. The previous page text was
obviously wrong, but we don't need to mention recvmsg() in the fix.

>  .TP
>  .B EPROTONOSUPPORT
>  Passed protocol is not


I applied this patch:

[[
diff --git a/man7/unix.7 b/man7/unix.7
index e111734..0d44dd6 100644
--- a/man7/unix.7
+++ b/man7/unix.7
@@ -518,9 +518,9 @@ is sent as well.
  This can be avoided by passing the
  .B MSG_NOSIGNAL
  flag to
-.BR sendmsg (2)
+.BR send (2)
  or
-.BR recvmsg (2).
+.BR sendmsg (2).
  .TP
  .B EPROTONOSUPPORT
  Passed protocol is not
]]

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)."
       [not found] ` <bug-137351-11311-3bo0kxnWaOQUvHkbgXJLS5sdmw4N0Rt+2LY78lusg7I@public.gmane.org/>
                     ` (3 preceding siblings ...)
  2016-07-22  6:51   ` [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)." bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
@ 2016-07-24 20:35   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
  4 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r @ 2016-07-24 20:35 UTC (permalink / raw)
  To: linux-man-u79uwXL29TY76Z2rM5mHXA

https://bugzilla.kernel.org/show_bug.cgi?id=137351

Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #3 from Michael Kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
Applied the patch below. Closing this bug...

diff --git a/man7/unix.7 b/man7/unix.7
index e111734..0d44dd6 100644
--- a/man7/unix.7
+++ b/man7/unix.7
@@ -518,9 +518,9 @@ is sent as well.
 This can be avoided by passing the
 .B MSG_NOSIGNAL
 flag to
-.BR sendmsg (2)
+.BR send (2)
 or
-.BR recvmsg (2).
+.BR sendmsg (2).
 .TP
 .B EPROTONOSUPPORT
 Passed protocol is not

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-07-24 20:35 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 21:06 [Bug 137351] New: MSG_NOSIGNAL not documented bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
     [not found] ` <bug-137351-11311-3bo0kxnWaOQUvHkbgXJLS5sdmw4N0Rt+2LY78lusg7I@public.gmane.org/>
2016-07-21 21:28   ` [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)." bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
2016-07-22  6:29   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
2016-07-22  6:45   ` [PATCH] unix.7: Explain that MSG_NOSIGNAL is useless for recvmsg(2) Laurent Georget
     [not found]     ` <20160722064522.5159-1-laurent.georget-vbcOdlJ0SulGWvitb5QawA@public.gmane.org>
2016-07-24 19:32       ` Michael Kerrisk (man-pages)
2016-07-22  6:51   ` [Bug 137351] MSG_NOSIGNAL not documented in man 2 recv, OR misprint in man recvmsg in the line "This can be avoided by passing the MSG_NOSIGNAL flag to sendmsg(2) or recvmsg(2)." bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r
2016-07-24 20:35   ` bugzilla-daemon-590EEB7GvNiWaY/ihj7yzEB+6BGkLq7r

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.