[Bug 178421] New: [regression] Radeon Oops on shutdown

[Bug 178421] New: [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

            Bug ID: 178421
           Summary: [regression] Radeon Oops on shutdown
           Product: Drivers
           Version: 2.5
    Kernel Version: 4.9-rc1
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: jtmettala@gmail.com
        Regression: No

Created attachment 241971
  --> https://bugzilla.kernel.org/attachment.cgi?id=241971&action=edit
picture of panic

Between 4.8 and 4.9-rc1 shutdown stopped working without power button. There
was blinking caps- and scroll lock leds on custom kernel. There was no blinking
leds on 4.9.0-040900rc1-generic from ubuntu kernel ppa. But it didn't power off
either. Suspend worked at least with custom kernel.

I tried to bisect. There was some uncertainity. Still bisect said
c0d5fb4d0d9224ccaad0475c9b58740873970e7e is the first bad commit. I tried git
revert -n -m 1 c0d5fb4d0d9224ccaad0475c9b58740873970e7e which gave Oops on
screen after shutdown attemp. Picture is attached.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com

--- Comment #1 from Alex Deucher <alexdeucher@gmail.com> ---
Already fixed:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=b0c80bd5d2e317f7596fe2badc1a3379fb3211e5
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9305ee6fe52035f63d70d023235b792ba22107f0

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

Kevin <kvbevsauce@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kvbevsauce@gmail.com

--- Comment #2 from Kevin <kvbevsauce@gmail.com> ---
Will these fixes be added to kernel 4.8 in a future minor version? or will I
have to wait till 4.9?

I cant shutdown since update to 4.8. reboot is ok though.


radeon 7870
arch linux at 4.8.3-ck

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

--- Comment #3 from Jouni Mettälä <jtmettala@gmail.com> ---
Created attachment 242511
  --> https://bugzilla.kernel.org/attachment.cgi?id=242511&action=edit
recent picture of panic

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

--- Comment #4 from Jouni Mettälä <jtmettala@gmail.com> ---
I still get oops on 4.9-rc2. Picture is attached. It looks different than
already fixed bug, for me at least.

Kevin, you have probably different bug. Reboot doesn't work for me. What is
last known good kernel for you?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

--- Comment #5 from Michel Dänzer <michel@daenzer.net> ---
(In reply to Jouni Mettälä from comment #0)
> I tried to bisect. There was some uncertainity. Still bisect said
> c0d5fb4d0d9224ccaad0475c9b58740873970e7e is the first bad commit.

That's a pure merge commit, so the problem can't really have started at that
commit. In order to avoid getting an incorrect bisection result again:

* Manually apply the patches referenced in comment 1 for each commit where
they're not applied yet
* Test every commit multiple times before marking it as "good"
* Only mark commits as "bad" which show exactly the same symptoms, otherwise
"skip" (for commits which fail to shut down / reboot for other reasons) or
"good"

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

Jouni Mettälä <jtmettala@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Regression|No                          |Yes

--- Comment #6 from Jouni Mettälä <jtmettala@gmail.com> ---
With patches referenced in comment 1, bisect pointed to
6b25e21fa6f26d0f0d45f161d169029411c84286
Merge tag 'drm-for-v4.9' of git://people.freedesktop.org/~airlied/linux

I was still bit unsure but after removing these shutdown seems to work.

@@ -362,6 +361,17 @@ radeon_pci_remove(struct pci_dev *pdev)
     drm_put_dev(dev);
 }

+static void
+radeon_pci_shutdown(struct pci_dev *pdev)
+{
+    /* if we are running in a VM, make sure the device
+     * torn down properly on reboot/shutdown.
+     * unfortunately we can't detect certain
+     * hypervisors so just do this all the time.
+     */
+    radeon_pci_remove(pdev);
+}
+
 static int radeon_pmops_suspend(struct device *dev)
 {
     struct pci_dev *pdev = to_pci_dev(dev);


@@ -574,6 +588,7 @@ static struct pci_driver radeon_kms_pci_driver = {
     .id_table = pciidlist,
     .probe = radeon_pci_probe,
     .remove = radeon_pci_remove,
+    .shutdown = radeon_pci_shutdown,
     .driver.pm = &radeon_pm_ops,
 };

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/drivers/gpu/drm/radeon/radeon_drv.c?id=6b25e21fa6f26d0f0d45f161d169029411c84286

During bisect some kernels failed to boot with initrd and UUID. Without initrd
they booted but still didn't shutdown.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

--- Comment #7 from Alex Deucher <alexdeucher@gmail.com> ---
As per comment 1, shutdown was working even with the commit that adds the
shutdown callback earlier in the cycle.  Some other change appears to have
regressed it.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

--- Comment #8 from Borislav Petkov <bp@alien8.de> ---
What about this one:

https://lkml.kernel.org/r/3b57a593-776b-b008-a5f2-672b9343f18a@lwfinger.net

I don't know the code so I can't say whether testing the ->ddc_bus ptr is the
proper fix...

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

--- Comment #9 from Alex Deucher <alexdeucher@gmail.com> ---
Yes, that should fix it.  All of the board I tested with had a ddc bus on all
connectors so it never came up before.  This only triggers on really old boards
with TV connectors which don't have a DDC bus for those connectors.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

--- Comment #10 from Borislav Petkov <bp@alien8.de> ---
Yap, it does. Just did two suspend-to-disk runs.

Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

Jouni Mettälä <jtmettala@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #11 from Jouni Mettälä <jtmettala@gmail.com> ---
This bug is fixed between 4.9-rc4 and 4.9-rc5.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel