[Bug 201067] New: [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[Bug 201067] New: [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

            Bug ID: 201067
           Summary: [bisected] [4.19-rc2 regression] Display corruption
                    with Vega 64 in 4.19-rc2
           Product: Drivers
           Version: 2.5
    Kernel Version: 4.19-rc2
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: sarnex@gentoo.org
        Regression: No

Created attachment 278389
  --> https://bugzilla.kernel.org/attachment.cgi?id=278389&action=edit
dmesg

Hi all,

When using a kernel after the below commit, I get visual corruption only on the
right most vertical column of my screen:

Author: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Date:   Mon Jul 23 14:13:23 2018 -0400

    drm/amd/display: Use calculated disp_clk_khz value for dce110


Video: 
https://www.youtube.com/watch?v=HrJUrBWMRXU

Using a kernel without this commit does not have the issue.

My GPU is a Sapphire Nitro+ Vega 64. I am using Gentoo with Mesa git and KDE
Plasma 5.

My main monitor is connected over DP and runs at 2560x1440 at 144hz. My second
monitor is connected over HDMI and runs at 1920x1080 at 60hz. I tried disabling
the second monitor in KDE, but the issue still occurs.

It also occurs in fullscreen applications.

I will also attach dmesg.

I can test any patches or answer any questions.

Thanks,
Sarnex

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

Nick Sarnie (sarnex@gentoo.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Regression|No                          |Yes

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #1 from Nicholas Kazlauskas (nicholas.kazlauskas@amd.com) ---
Created attachment 278423
  --> https://bugzilla.kernel.org/attachment.cgi?id=278423&action=edit
Patch that reverts the 15% reduction in set dispclk

While I can't reproduce your issue under a similar setup I think I have an idea
of what the issue is.

Can you try this patch?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #2 from Nick Sarnie (sarnex@gentoo.org) ---
Hi Nicholas,

Thank you for the fast response. 

I can confirm the patch fixes the issue.

If you intend to submit this:
Tested-by: Nick Sarnie <sarnex@gentoo.org>

Thanks,
Sarnex

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

Nicholas Kazlauskas (nicholas.kazlauskas@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278423|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicholas Kazlauskas (nicholas.kazlauskas@amd.com) ---
Created attachment 278455
  --> https://bugzilla.kernel.org/attachment.cgi?id=278455&action=edit
0001-drm-amd-display-Use-higher-dispclk-value-for-dce120.patch

Do you mind testing another patch?

This patch has a narrower impact than the previous one (since it should only
target Vega). I imagine that it would also fix your issue but it'd be nice to
have verification.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #4 from Nick Sarnie (sarnex@gentoo.org) ---
Hi Nicholas,

I can also confirm that the second patch fixes the issue. 

Tested-by: Nick Sarnie <sarnex@gentoo.org>

Please let me know if you need anything else.

Thanks,
Sarnex

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

Dave Johnson (dave@locochino.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dave@locochino.com

--- Comment #5 from Dave Johnson (dave@locochino.com) ---
This is possibly related to my issue that popped up in 4.18, Vega 64 works with
one of my displayPort monitors but not the DVI.  from what I've seen others
reporting on various searches on my issue, it's something with a clock setting
where a khz value is referenced as "10" instead of "1" or something like that. 
Vague, I know, but I dunno.

Some get black screen, I get one display but not multi, and the user above me
has corruption.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #6 from Nicholas Kazlauskas (nicholas.kazlauskas@amd.com) ---
I think you're referencing this patch:

https://patchwork.freedesktop.org/patch/238065/

Which should be fixed in 4.18.

Please post a new ticket with a full dmesg log, Xorg log and your
distro/desktop environment if you can still reproduce the problem.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #7 from Dave Johnson (dave@locochino.com) ---
(In reply to Nicholas Kazlauskas from comment #6)
> I think you're referencing this patch:
> 
> https://patchwork.freedesktop.org/patch/238065/
> 
> Which should be fixed in 4.18.
> 
> Please post a new ticket with a full dmesg log, Xorg log and your
> distro/desktop environment if you can still reproduce the problem.

Ok, so yes and no I guess.  I was assuming a single bug while there are
apparently two.  The one that causes video corruption and artifacts is in fact
fixed for me now, but the multi-head support is still broken.  It worked a
couple of kernels ago, opening a new bug report over at opensuse since it seems
to be opensuse specific for some reason (other live CDs work fine, looks like
it's just something with Tumbleweed for whatever reason)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #8 from Dave Johnson (dave@locochino.com) ---
Update: for my possibly-separate-issue I can confirm that multi-head works on
4.16.13 and not 4.19_RC3

For now I'm staying on 4.16 as it's working perfectly back there.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #9 from Benjamin Xiao (ben.r.xiao@gmail.com) ---
I get the same visual corruption as well. It only appears when I run the
monitor at 144Hz. 120Hz seems fine.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #10 from Benjamin Xiao (ben.r.xiao@gmail.com) ---
(In reply to Nicholas Kazlauskas from comment #3)
> Created attachment 278455 [details]
> 0001-drm-amd-display-Use-higher-dispclk-value-for-dce120.patch
> 
> Do you mind testing another patch?
> 
> This patch has a narrower impact than the previous one (since it should only
> target Vega). I imagine that it would also fix your issue but it'd be nice
> to have verification.

Will this patch be backported to 4.19? Seems like right now its only in 4.20.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #11 from Harry Wentland (harry.wentland@amd.com) ---
GregKH just added the patch for 4.19-stable.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #12 from Dave Johnson (dave@locochino.com) ---
This is fixed for me in 4.19-stable

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

Axel (at46n@t-online.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |at46n@t-online.de

--- Comment #13 from Axel (at46n@t-online.de) ---
In which version should this bug being fixed? I still have this bug with
4.19.9. Or is this only fixed for vega? Because I've only a rx570.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #14 from Nicholas Kazlauskas (nicholas.kazlauskas@amd.com) ---
(In reply to Axel from comment #13)
> In which version should this bug being fixed? I still have this bug with
> 4.19.9. Or is this only fixed for vega? Because I've only a rx570.

This was fixed for both Vega and Polaris but I think there was another
regression that only affected Polaris in that release.

It should be fixed in amd-staging-drm-next. It'll probably make its way into
stable at some point.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=201067

--- Comment #15 from Axel (at46n@t-online.de) ---
It is fixed for me with kernel 4.20.0

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel