[Bug 206435] New: dwc3 dwc3.3.auto: no usb2 phy configured

[Bug 206435] New: dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

            Bug ID: 206435
           Summary: dwc3 dwc3.3.auto: no usb2 phy configured
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.6
          Hardware: x86-64
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: drivers_usb@kernel-bugs.kernel.org
          Reporter: youling257@gmail.com
        Regression: No

android_x86:/ $ dmesg | grep dwc
[    8.956913] dwc3 dwc3.3.auto: failed to create device link to
dwc3.3.auto.ulpi
[    8.979682] dwc3 dwc3.3.auto: no usb2 phy configured
[    8.986984] dwc3 dwc3.3.auto: failed to initialize core: -22
[    8.993597] dwc3: probe of dwc3.3.auto failed with error -22
android_x86:/ $

some Bay trail device has a phy_tusb1210 used for dwc3.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

--- Comment #1 from youling257@gmail.com ---
kernel 5.6 coming soon, test the master branch, dwc3 not work on my z3735f,
work on z8350.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]


Hi,

bugzilla-daemon@bugzilla.kernel.org writes:
> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>
> --- Comment #1 from youling257@gmail.com ---
> kernel 5.6 coming soon, test the master branch, dwc3 not work on my z3735f,
> work on z8350.

What is z3735f and z8350? Are these platforms supported upstream? Who
maintains those platforms?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

--- Comment #2 from Felipe Balbi (balbi@kernel.org) ---
Hi,

bugzilla-daemon@bugzilla.kernel.org writes:
> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>
> --- Comment #1 from youling257@gmail.com ---
> kernel 5.6 coming soon, test the master branch, dwc3 not work on my z3735f,
> work on z8350.

What is z3735f and z8350? Are these platforms supported upstream? Who
maintains those platforms?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

--- Comment #3 from youling257@gmail.com ---
Revert 987351e1ea7772cf2f0795e917fb33b2e282e1c1 phy: core: Add consumer device
link support, dwc3 work for my z3735f device.

android_x86:/ $ su
android_x86:/ # dmesg | grep dwc
[    9.724606] dwc3 dwc3.3.auto: changing max_speed on rev 5533210a
[   47.488501] udc dwc3.3.auto: registering UDC driver [g1]

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]


Hi,

bugzilla-daemon@bugzilla.kernel.org writes:
> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>
> --- Comment #3 from youling257@gmail.com ---
> Revert 987351e1ea7772cf2f0795e917fb33b2e282e1c1 phy: core: Add consumer device
> link support, dwc3 work for my z3735f device.
>
> android_x86:/ $ su
> android_x86:/ # dmesg | grep dwc
> [    9.724606] dwc3 dwc3.3.auto: changing max_speed on rev 5533210a
> [   47.488501] udc dwc3.3.auto: registering UDC driver [g1]

reverting that commit makes dwc3 work? Then you don't have a bug on
dwc3. You have a regression caused by another commit.

Alexandre, any idea what's going on?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

--- Comment #4 from Felipe Balbi (balbi@kernel.org) ---
Hi,

bugzilla-daemon@bugzilla.kernel.org writes:
> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>
> --- Comment #3 from youling257@gmail.com ---
> Revert 987351e1ea7772cf2f0795e917fb33b2e282e1c1 phy: core: Add consumer
> device
> link support, dwc3 work for my z3735f device.
>
> android_x86:/ $ su
> android_x86:/ # dmesg | grep dwc
> [    9.724606] dwc3 dwc3.3.auto: changing max_speed on rev 5533210a
> [   47.488501] udc dwc3.3.auto: registering UDC driver [g1]

reverting that commit makes dwc3 work? Then you don't have a bug on
dwc3. You have a regression caused by another commit.

Alexandre, any idea what's going on?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]


+ Heikki, since this is, apparently, Bay Trail

Felipe Balbi <balbi@kernel.org> writes:

> Hi,
>
> bugzilla-daemon@bugzilla.kernel.org writes:
>> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>>
>> --- Comment #3 from youling257@gmail.com ---
>> Revert 987351e1ea7772cf2f0795e917fb33b2e282e1c1 phy: core: Add consumer device
>> link support, dwc3 work for my z3735f device.
>>
>> android_x86:/ $ su
>> android_x86:/ # dmesg | grep dwc
>> [    9.724606] dwc3 dwc3.3.auto: changing max_speed on rev 5533210a
>> [   47.488501] udc dwc3.3.auto: registering UDC driver [g1]
>
> reverting that commit makes dwc3 work? Then you don't have a bug on
> dwc3. You have a regression caused by another commit.
>
> Alexandre, any idea what's going on?

Heikki, any ideas?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

--- Comment #5 from Felipe Balbi (balbi@kernel.org) ---
+ Heikki, since this is, apparently, Bay Trail

Felipe Balbi <balbi@kernel.org> writes:

> Hi,
>
> bugzilla-daemon@bugzilla.kernel.org writes:
>> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>>
>> --- Comment #3 from youling257@gmail.com ---
>> Revert 987351e1ea7772cf2f0795e917fb33b2e282e1c1 phy: core: Add consumer
>> device
>> link support, dwc3 work for my z3735f device.
>>
>> android_x86:/ $ su
>> android_x86:/ # dmesg | grep dwc
>> [    9.724606] dwc3 dwc3.3.auto: changing max_speed on rev 5533210a
>> [   47.488501] udc dwc3.3.auto: registering UDC driver [g1]
>
> reverting that commit makes dwc3 work? Then you don't have a bug on
> dwc3. You have a regression caused by another commit.
>
> Alexandre, any idea what's going on?

Heikki, any ideas?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

--- Comment #6 from youling257@gmail.com ---
/sys/module/dwc3/drivers/platform:dwc3/dwc3.3.auto/dwc3.3.auto.ulpi/driver
Symbolic link /sys/module/bus/ulpi/drivers/tusb1210

“phy: core: Add consumer device link support” cause failed to create link.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[Alexandre Torgue]

Hi Felipe,

On 2/6/20 7:33 PM, Felipe Balbi wrote:
> 
> + Heikki, since this is, apparently, Bay Trail
> 
> Felipe Balbi <balbi@kernel.org> writes:
> 
>> Hi,
>>
>> bugzilla-daemon@bugzilla.kernel.org writes:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>>>
>>> --- Comment #3 from youling257@gmail.com ---
>>> Revert 987351e1ea7772cf2f0795e917fb33b2e282e1c1 phy: core: Add consumer device
>>> link support, dwc3 work for my z3735f device.
>>>
>>> android_x86:/ $ su
>>> android_x86:/ # dmesg | grep dwc
>>> [    9.724606] dwc3 dwc3.3.auto: changing max_speed on rev 5533210a
>>> [   47.488501] udc dwc3.3.auto: registering UDC driver [g1]
>>
>> reverting that commit makes dwc3 work? Then you don't have a bug on
>> dwc3. You have a regression caused by another commit.
>>
>> Alexandre, any idea what's going on?
> 

It's probably due to error returned by "device_link-add" function called 
in phy-get (phy-core.c). Maybe because phy dev is not present. I wonder 
if we should update device_link_add error management in phy-get (if link 
add fails it's maybe not a reason to make the consumer probe fail)

regards
Alex

> Heikki, any ideas?
> 

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

--- Comment #7 from alexandre.torgue@st.com ---
Hi Felipe,

On 2/6/20 7:33 PM, Felipe Balbi wrote:
> 
> + Heikki, since this is, apparently, Bay Trail
> 
> Felipe Balbi <balbi@kernel.org> writes:
> 
>> Hi,
>>
>> bugzilla-daemon@bugzilla.kernel.org writes:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=206435
>>>
>>> --- Comment #3 from youling257@gmail.com ---
>>> Revert 987351e1ea7772cf2f0795e917fb33b2e282e1c1 phy: core: Add consumer
>>> device
>>> link support, dwc3 work for my z3735f device.
>>>
>>> android_x86:/ $ su
>>> android_x86:/ # dmesg | grep dwc
>>> [    9.724606] dwc3 dwc3.3.auto: changing max_speed on rev 5533210a
>>> [   47.488501] udc dwc3.3.auto: registering UDC driver [g1]
>>
>> reverting that commit makes dwc3 work? Then you don't have a bug on
>> dwc3. You have a regression caused by another commit.
>>
>> Alexandre, any idea what's going on?
> 

It's probably due to error returned by "device_link-add" function called 
in phy-get (phy-core.c). Maybe because phy dev is not present. I wonder 
if we should update device_link_add error management in phy-get (if link 
add fails it's maybe not a reason to make the consumer probe fail)

regards
Alex

> Heikki, any ideas?
>

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

--- Comment #8 from youling257@gmail.com ---
https://patchwork.kernel.org/patch/11225949/#23142545

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 206435] dwc3 dwc3.3.auto: no usb2 phy configured

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=206435

Luca Weiss (bugzilla@z3ntu.xyz) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@z3ntu.xyz

--- Comment #9 from Luca Weiss (bugzilla@z3ntu.xyz) ---
Also happening on msm8974, see e.g.
https://storage.kernelci.org/next/master/next-20200213/arm/qcom_defconfig/gcc-8/lab-bjorn/boot-qcom-msm8974-sony-xperia-castor.html
(msm_hsusb f9a55000.usb: failed to create device link to ci_hdrc.0.ulpi)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.