[Bug 207717] New: reiserfs: data race on inode->i_size in reiserfs_write_full_page()

[Bug 207717] New: reiserfs: data race on inode->i_size in reiserfs_write_full_page()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=207717

            Bug ID: 207717
           Summary: reiserfs: data race on inode->i_size in
                    reiserfs_write_full_page()
           Product: File System
           Version: 2.5
    Kernel Version: 5.4
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: ReiserFS
          Assignee: reiserfs-devel@vger.kernel.org
          Reporter: baijiaju1990@gmail.com
        Regression: No

The functions reiserfs_write_full_page() and reiserfs_write_end() are
concurrently executed at runtime in the following call contexts:

Thread 1:
reiserfs_writepage()
  reiserfs_write_full_page()

Thread 2:
reiserfs_write_end()

In reiserfs_write_full_page():
  unsigned long end_index = inode->i_size >> PAGE_SHIFT;

In reiserfs_write_end():
  inode->i_size = pos + copied;

Thus, a data race on inode->i_size occurs.

This data race was found and actually reproduced by our concurrency fuzzer.

I am not sure whether this data race is harmful and how to fix this data race
properly, so I want to listen to your opinions, thanks :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 207717] reiserfs: data race on inode->i_size in reiserfs_write_full_page()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=207717

Jia-Ju Bai (baijiaju1990@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baijiaju1990@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 207717] reiserfs: data race on inode->i_size in reiserfs_write_full_page()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=207717

Jia-Ju Bai (baijiaju1990@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeffm@suse.com

-- 
You are receiving this mail because:
You are the assignee for the bug.