[Bug 212725] New: USB CDC ACM device stop working

[Bug 212725] New: USB CDC ACM device stop working

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=212725

            Bug ID: 212725
           Summary: USB CDC ACM device stop working
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.11.15
          Hardware: x86-64
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: USB
          Assignee: drivers_usb@kernel-bugs.kernel.org
          Reporter: stefan@agner.ch
        Regression: No

When trying to use USB CDC ACM devices (open using screen) opening fails and
the kernel dmesg shows the following error:

kernel: cdc_acm 1-3.3.3:1.0: acm_port_activate - usb_submit_urb(ctrl irq)
failed

This happens with STM32 microcontroller based device as well as a Segger JTAG
adapter, so it seems not device related. The issue must have been introduced
recently (within the last month) as those devices used to work previously. I
can reproduce the issue also with latest LTS kernel release 5.10.31.

Builds:
- 5.10.31-1-lts
- 5.11.15-arch1-2

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 212725] USB CDC ACM device stop working

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=212725

--- Comment #1 from Stefan Agner (stefan@agner.ch) ---
I went back and installed some older LTS kernel I had at hand. It seems that
5.10.26 was still working and 5.10.29 is broken. I don't have kernels at hand
inbetween, but hopefully this narrows it down already sufficently.

This is on a AMD Ryzen 9 3900X platform using a AMD X570 motherboard. The USB
2.0 devices are connected through USB 3.0 hub, but also connecting them
directly to the root port seems to exhibit the issue.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 212725] USB CDC ACM device stop working

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=212725

Stefan Agner (stefan@agner.ch) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver@neukum.org

--- Comment #2 from Stefan Agner (stefan@agner.ch) ---
Some possible candidates:
https://lore.kernel.org/linux-usb/20210311130126.15972-1-oneukum@suse.com/
https://lore.kernel.org/linux-usb/20210311133714.31881-1-oneukum@suse.com/

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 212725] USB CDC ACM device stop working

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=212725

--- Comment #3 from Oliver Neukum (oliver@neukum.org) ---
Created attachment 296439
  --> https://bugzilla.kernel.org/attachment.cgi?id=296439&action=edit
fix a poison/unpoison imbalance

Please test this patch

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 212725] USB CDC ACM device stop working

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=212725

--- Comment #4 from Stefan Agner (stefan@agner.ch) ---
Thanks for the quick response!

Applied and built a 5.11.15 kernel with that patch. It indeed seems to fix the
issue!

It did not apply cleanly on 5.11.15 or master, there is a `spin_lock_irq` in
that area. I just moved the acm_unpoison_urbs after the suspend counter
decrement, not sure if that is the correct fix though.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 212725] USB CDC ACM device stop working

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=212725

Stefan Agner (stefan@agner.ch) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #5 from Stefan Agner (stefan@agner.ch) ---
Addressed with:
https://lore.kernel.org/linux-usb/20210421074513.4327-1-oneukum@suse.com/T/#u

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 212725] USB CDC ACM device stop working

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=212725

--- Comment #6 from Stefan Agner (stefan@agner.ch) ---
FWIW, the issue is now fixed in kernels v5.11.17/v5.10.33. I guess it will make
it into v5.12.1 (at this point not yet released).

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.