* [Bug 214875] USB 3.1 device cannot be detected
[not found] <bug-214875-208809@https.bugzilla.kernel.org/>
@ 2021-10-30 5:49 ` bugzilla-daemon
2021-10-30 5:57 ` bugzilla-daemon
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2021-10-30 5:49 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=214875
--- Comment #1 from Walt Jr. Brake (mr.yming81@gmail.com) ---
Yesterday I try to fix it myself, and after I revert the patch [usb: core:
reduce power-on-good delay time of root
hub](https://lore.kernel.org/all/1618017645-12259-1-git-send-email-chunfeng.yun%40mediatek.com/),
compile the kernel and test, it works.
Here is the patch:
diff --git a/drivers/usb/core/hub.h b/drivers/usb/core/hub.h
index 22ea1f4f2d66..73f4482d833a 100644
--- a/drivers/usb/core/hub.h
+++ b/drivers/usb/core/hub.h
@@ -148,10 +148,8 @@ static inline unsigned hub_power_on_good_delay(struct
usb_hub *hub)
{
unsigned delay = hub->descriptor->bPwrOn2PwrGood * 2;
- if (!hub->hdev->parent) /* root hub */
- return delay;
- else /* Wait at least 100 msec for power to become stable */
- return max(delay, 100U);
+ /* Wait at least 100 msec for power to become stable */
+ return max(delay, 100U);
}
static inline int hub_port_debounce_be_connected(struct usb_hub *hub,
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Bug 214875] USB 3.1 device cannot be detected
[not found] <bug-214875-208809@https.bugzilla.kernel.org/>
2021-10-30 5:49 ` [Bug 214875] USB 3.1 device cannot be detected bugzilla-daemon
@ 2021-10-30 5:57 ` bugzilla-daemon
2021-12-11 11:33 ` bugzilla-daemon
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2021-10-30 5:57 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=214875
--- Comment #2 from Walt Jr. Brake (mr.yming81@gmail.com) ---
correct the patch display format
```
diff --git a/drivers/usb/core/hub.h b/drivers/usb/core/hub.h
index 22ea1f4f2d66..73f4482d833a 100644
--- a/drivers/usb/core/hub.h
+++ b/drivers/usb/core/hub.h
@@ -148,10 +148,8 @@ static inline unsigned hub_power_on_good_delay(struct
usb_hub *hub)
{
unsigned delay = hub->descriptor->bPwrOn2PwrGood * 2;
- if (!hub->hdev->parent) /* root hub */
- return delay;
- else /* Wait at least 100 msec for power to become stable */
- return max(delay, 100U);
+ /* Wait at least 100 msec for power to become stable */
+ return max(delay, 100U);
}
static inline int hub_port_debounce_be_connected(struct usb_hub *hub,
```
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Bug 214875] USB 3.1 device cannot be detected
[not found] <bug-214875-208809@https.bugzilla.kernel.org/>
2021-10-30 5:49 ` [Bug 214875] USB 3.1 device cannot be detected bugzilla-daemon
2021-10-30 5:57 ` bugzilla-daemon
@ 2021-12-11 11:33 ` bugzilla-daemon
2022-04-02 15:47 ` bugzilla-daemon
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2021-12-11 11:33 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=214875
Walt Jr. Brake (mr.yming81@gmail.com) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |PATCH_ALREADY_AVAILABLE
--- Comment #4 from Walt Jr. Brake (mr.yming81@gmail.com) ---
It was fixed by the patch [xhci: Fix USB 3.1 enumeration issues by increasing
roothub power-on-good
delay](https://lore.kernel.org/all/20211105160036.549516-1-mathias.nyman@linux.intel.com/)
Thanks for your works.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 214875] USB 3.1 device cannot be detected
[not found] <bug-214875-208809@https.bugzilla.kernel.org/>
` (2 preceding siblings ...)
2021-12-11 11:33 ` bugzilla-daemon
@ 2022-04-02 15:47 ` bugzilla-daemon
2022-05-30 5:34 ` bugzilla-daemon
2022-05-30 6:09 ` bugzilla-daemon
5 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2022-04-02 15:47 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=214875
Michele Tucci (tucci.michele@gmail.com) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tucci.michele@gmail.com
--- Comment #5 from Michele Tucci (tucci.michele@gmail.com) ---
My USB 3 external hard drive cannot be detected after this fix.
To get it working again, I restored to 10 (20ms) the value of
desc->bPwrOn2PwrGood in drivers/usb/host/xhci-hub.c:347.
This is how the device looks like from lsusb:
```
Bus 004 Device 002: ID 174c:55aa ASMedia Technology Inc. ASM1051E ...
```
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 214875] USB 3.1 device cannot be detected
[not found] <bug-214875-208809@https.bugzilla.kernel.org/>
` (3 preceding siblings ...)
2022-04-02 15:47 ` bugzilla-daemon
@ 2022-05-30 5:34 ` bugzilla-daemon
2022-05-30 6:09 ` bugzilla-daemon
5 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2022-05-30 5:34 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=214875
--- Comment #6 from Walt Jr. Brake (mr.yming81@gmail.com) ---
(In reply to Michele Tucci from comment #5)
> My USB 3 external hard drive cannot be detected after this fix.
>
> To get it working again, I restored to 10 (20ms) the value of
> desc->bPwrOn2PwrGood in drivers/usb/host/xhci-hub.c:347.
>
> This is how the device looks like from lsusb:
> ```
> Bus 004 Device 002: ID 174c:55aa ASMedia Technology Inc. ASM1051E ...
> ```
Maybe you should using the reply to instructions from
https://lore.kernel.org/all/1618017645-12259-1-git-send-email-chunfeng.yun%40mediatek.com/
to raise the issue on the linux-usb mailing list.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 214875] USB 3.1 device cannot be detected
[not found] <bug-214875-208809@https.bugzilla.kernel.org/>
` (4 preceding siblings ...)
2022-05-30 5:34 ` bugzilla-daemon
@ 2022-05-30 6:09 ` bugzilla-daemon
5 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2022-05-30 6:09 UTC (permalink / raw)
To: linux-usb
https://bugzilla.kernel.org/show_bug.cgi?id=214875
--- Comment #7 from Chunfeng Yun (chunfeng.yun@mediatek.com) ---
(In reply to Michele Tucci from comment #5)
> My USB 3 external hard drive cannot be detected after this fix.
>
> To get it working again, I restored to 10 (20ms) the value of
> desc->bPwrOn2PwrGood in drivers/usb/host/xhci-hub.c:347.
>
> This is how the device looks like from lsusb:
> ```
> Bus 004 Device 002: ID 174c:55aa ASMedia Technology Inc. ASM1051E ...
> ```
Then will be reproduced if revert below patch?
https://lore.kernel.org/all/1618017645-12259-1-git-send-email-chunfeng.yun%40mediatek.com/
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-30 6:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-214875-208809@https.bugzilla.kernel.org/>
2021-10-30 5:49 ` [Bug 214875] USB 3.1 device cannot be detected bugzilla-daemon
2021-10-30 5:57 ` bugzilla-daemon
2021-12-11 11:33 ` bugzilla-daemon
2022-04-02 15:47 ` bugzilla-daemon
2022-05-30 5:34 ` bugzilla-daemon
2022-05-30 6:09 ` bugzilla-daemon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.