All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: platform-driver-x86@vger.kernel.org
Subject: [Bug 214899] ideapad-laptop: platform backlight device not working
Date: Mon, 01 Nov 2021 22:34:23 +0000	[thread overview]
Message-ID: <bug-214899-215701-0eWjuwEFPD@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-214899-215701@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=214899

--- Comment #7 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
The ideapad-laptop code seems to log to dmesg on most unknown events, I assume
nothing shows up in dmesg?

I think based on your other experiments that it would be interesting to log the
value of now in this function in ideapad-laptop.c:


static void ideapad_backlight_notify_brightness(struct ideapad_private *priv)
{
        unsigned long now;

        /* if we control brightness via acpi video driver */
        if (!priv->blightdev)
                read_ec_data(priv->adev->handle, VPCCMD_R_BL, &now);
        else
                backlight_force_update(priv->blightdev,
BACKLIGHT_UPDATE_HOTKEY);
}

Changing it to:

static void ideapad_backlight_notify_brightness(struct ideapad_private *priv)
{
        unsigned long now;

        /* if we control brightness via acpi video driver */
        if (!priv->blightdev) {
                read_ec_data(priv->adev->handle, VPCCMD_R_BL, &now);
                pr_info("EC's LCD backlight value is now: %ld\n", now);
        } else
                backlight_force_update(priv->blightdev,
BACKLIGHT_UPDATE_HOTKEY);
}


I suspect that we will see that value change (note this assumes you do not
specify an acpi_backlight= kernel cmdline option).

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2021-11-01 22:34 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-31 19:28 [Bug 214899] New: ideapad-laptop: platform backlight device not working bugzilla-daemon
2021-11-01 19:35 ` [Bug 214899] " bugzilla-daemon
2021-11-01 20:33 ` bugzilla-daemon
2021-11-01 21:22 ` bugzilla-daemon
2021-11-01 22:17 ` bugzilla-daemon
2021-11-01 22:34 ` bugzilla-daemon [this message]
2021-11-01 22:44 ` bugzilla-daemon
2021-11-02  8:13 ` bugzilla-daemon
2021-11-02 14:15 ` bugzilla-daemon
2021-11-02 14:20 ` bugzilla-daemon
2021-11-02 14:30 ` bugzilla-daemon
2021-11-02 14:53 ` bugzilla-daemon
2021-11-02 22:06 ` bugzilla-daemon
2021-11-02 22:15 ` bugzilla-daemon
2021-11-04 21:22 ` bugzilla-daemon
2021-11-15 14:28 ` bugzilla-daemon
2022-02-17  1:20 ` [Bug 214899] ideapad-laptop: brightness hotkeys " bugzilla-daemon
2022-02-17  1:21 ` bugzilla-daemon
2022-04-12 18:45 ` bugzilla-daemon
2022-04-12 21:46 ` bugzilla-daemon
2022-04-25 16:30 ` bugzilla-daemon
2022-04-26 12:54 ` bugzilla-daemon
2022-04-26 12:56 ` bugzilla-daemon
2022-04-27 12:03 ` bugzilla-daemon
2022-04-29 15:04 ` bugzilla-daemon
2022-04-29 16:29 ` bugzilla-daemon
2022-06-10 20:07 ` bugzilla-daemon
2022-06-12 15:25 ` bugzilla-daemon
2022-06-12 15:32 ` bugzilla-daemon
2022-06-13  9:18 ` bugzilla-daemon
2022-06-13 10:30 ` bugzilla-daemon
2022-06-13 13:17 ` bugzilla-daemon
2022-06-13 21:23 ` bugzilla-daemon
2022-06-14 13:41 ` bugzilla-daemon
2022-06-14 18:48 ` bugzilla-daemon
2022-06-14 19:14 ` bugzilla-daemon
2022-06-15  9:39 ` bugzilla-daemon
2022-06-15  9:46 ` bugzilla-daemon
2022-06-15 16:36 ` bugzilla-daemon
2022-06-15 20:27 ` bugzilla-daemon
2022-06-26 15:38 ` bugzilla-daemon
2022-07-03 20:44 ` bugzilla-daemon
2022-07-04 10:12 ` bugzilla-daemon
2022-07-04 10:12 ` bugzilla-daemon
2022-07-04 10:14 ` bugzilla-daemon
2022-07-04 10:34 ` bugzilla-daemon
2022-07-05  7:59 ` bugzilla-daemon
2022-07-10 15:30 ` bugzilla-daemon
2022-07-30 19:04 ` bugzilla-daemon
2022-07-31  1:46 ` bugzilla-daemon
2022-07-31  3:41 ` bugzilla-daemon
2022-10-03 14:32 ` bugzilla-daemon
2022-10-03 14:32 ` bugzilla-daemon
2022-10-03 14:33 ` bugzilla-daemon
2022-10-03 14:33 ` bugzilla-daemon
2022-10-05 23:21 ` bugzilla-daemon
2022-10-06  7:38 ` bugzilla-daemon
2022-10-29  2:48 ` bugzilla-daemon
2022-10-30  9:54 ` bugzilla-daemon
2023-01-24  8:20 ` bugzilla-daemon
2023-01-24  9:32 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-214899-215701-0eWjuwEFPD@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.