All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@kernel.org
To: platform-driver-x86@vger.kernel.org
Subject: [Bug 214899] ideapad-laptop: brightness hotkeys not working
Date: Mon, 25 Apr 2022 16:30:13 +0000	[thread overview]
Message-ID: <bug-214899-215701-iWgVTvxy5L@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-214899-215701@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=214899

--- Comment #22 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Sorry for the slow reply (note I'm afraid my next reply will likely also be a
bit slow).

Good find on the methods, so this means that the key-press events are supposed
to come from the "Video Bus" device and as you point out for some reason this
is not happening. I guess that the drivers/acpi/acpi_video.c is not making some
call to enable the events which your laptop requires; or it is making a call
which it should not make which disables the events...

One thing which I just noticed is that when passing acpi_backlight=video you
get 2 acpi_video# backlight devices. Given that AFAICT your laptop has only a
single GPU,  may be an indication of a problem.

I wonder what happens when you pass:

video.only_lcd=1 acpi_backlight=video

on the kernel cmdline, I would expect there to only be 1 acpi_video# backlight
device under /sys/class/backlight then ?    And maybe this also fixes the
brightness keys?

I assume that without any "acpi_backlight=xxx" on the kernel cmdline you only
get the intel_backlight device, right? You could also check to see if adding
just "video.only_lcd=1" to the kernel cmdline helps.

If that does not help, you may want to play with the acpi_video_bus_DOS() call
from 
drivers/acpi/acpi_video.c .

This gets called from the acpi_video_bus_start_devices() function:

static int acpi_video_bus_start_devices(struct acpi_video_bus *video)
{
        return acpi_video_bus_DOS(video, 0,
                                  acpi_osi_is_win8() ? 1 : 0);
}

You may want to modify this trying the following:

        return acpi_video_bus_DOS(video, 3,
                                  acpi_osi_is_win8() ? 1 : 0);

Looking at your acpidump it seems the second parameter is ignored, so changing
that will likely not matter.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2022-04-25 16:30 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-31 19:28 [Bug 214899] New: ideapad-laptop: platform backlight device not working bugzilla-daemon
2021-11-01 19:35 ` [Bug 214899] " bugzilla-daemon
2021-11-01 20:33 ` bugzilla-daemon
2021-11-01 21:22 ` bugzilla-daemon
2021-11-01 22:17 ` bugzilla-daemon
2021-11-01 22:34 ` bugzilla-daemon
2021-11-01 22:44 ` bugzilla-daemon
2021-11-02  8:13 ` bugzilla-daemon
2021-11-02 14:15 ` bugzilla-daemon
2021-11-02 14:20 ` bugzilla-daemon
2021-11-02 14:30 ` bugzilla-daemon
2021-11-02 14:53 ` bugzilla-daemon
2021-11-02 22:06 ` bugzilla-daemon
2021-11-02 22:15 ` bugzilla-daemon
2021-11-04 21:22 ` bugzilla-daemon
2021-11-15 14:28 ` bugzilla-daemon
2022-02-17  1:20 ` [Bug 214899] ideapad-laptop: brightness hotkeys " bugzilla-daemon
2022-02-17  1:21 ` bugzilla-daemon
2022-04-12 18:45 ` bugzilla-daemon
2022-04-12 21:46 ` bugzilla-daemon
2022-04-25 16:30 ` bugzilla-daemon [this message]
2022-04-26 12:54 ` bugzilla-daemon
2022-04-26 12:56 ` bugzilla-daemon
2022-04-27 12:03 ` bugzilla-daemon
2022-04-29 15:04 ` bugzilla-daemon
2022-04-29 16:29 ` bugzilla-daemon
2022-06-10 20:07 ` bugzilla-daemon
2022-06-12 15:25 ` bugzilla-daemon
2022-06-12 15:32 ` bugzilla-daemon
2022-06-13  9:18 ` bugzilla-daemon
2022-06-13 10:30 ` bugzilla-daemon
2022-06-13 13:17 ` bugzilla-daemon
2022-06-13 21:23 ` bugzilla-daemon
2022-06-14 13:41 ` bugzilla-daemon
2022-06-14 18:48 ` bugzilla-daemon
2022-06-14 19:14 ` bugzilla-daemon
2022-06-15  9:39 ` bugzilla-daemon
2022-06-15  9:46 ` bugzilla-daemon
2022-06-15 16:36 ` bugzilla-daemon
2022-06-15 20:27 ` bugzilla-daemon
2022-06-26 15:38 ` bugzilla-daemon
2022-07-03 20:44 ` bugzilla-daemon
2022-07-04 10:12 ` bugzilla-daemon
2022-07-04 10:12 ` bugzilla-daemon
2022-07-04 10:14 ` bugzilla-daemon
2022-07-04 10:34 ` bugzilla-daemon
2022-07-05  7:59 ` bugzilla-daemon
2022-07-10 15:30 ` bugzilla-daemon
2022-07-30 19:04 ` bugzilla-daemon
2022-07-31  1:46 ` bugzilla-daemon
2022-07-31  3:41 ` bugzilla-daemon
2022-10-03 14:32 ` bugzilla-daemon
2022-10-03 14:32 ` bugzilla-daemon
2022-10-03 14:33 ` bugzilla-daemon
2022-10-03 14:33 ` bugzilla-daemon
2022-10-05 23:21 ` bugzilla-daemon
2022-10-06  7:38 ` bugzilla-daemon
2022-10-29  2:48 ` bugzilla-daemon
2022-10-30  9:54 ` bugzilla-daemon
2023-01-24  8:20 ` bugzilla-daemon
2023-01-24  9:32 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-214899-215701-iWgVTvxy5L@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.